[PATCH]: BUILD/MINOR listener

2019-03-27 Thread David CARLIER
Hi Here a little patch proposal. Kind regards. From 3ffe96e6a68b5364ecd5364083c9c753e1097d9c Mon Sep 17 00:00:00 2001 From: David Carlier Date: Wed, 27 Mar 2019 16:08:42 + Subject: [PATCH] BUILD/MINOR: listener Silenting couple of warning related to signness. --- src/listener.c | 4 ++-- 1

Re: Haproxy 1.9 / DeviceAtlas module

2019-01-15 Thread David Carlier
Thanks a lot. Do you have a rough ETA for 1.9.2. ? Sorry for pressure Willy :-), thanks to dyndynamic for pointing it out. On Tue, 15 Jan 2019 at 14:09, Willy Tarreau wrote: > > On Tue, Jan 15, 2019 at 01:16:05PM +, David Carlier wrote: > > Thanks here a proposed patch. >

Re: Haproxy 1.9 / DeviceAtlas module

2019-01-15 Thread David Carlier
I forgot to mention, might be obvious though, to b backported to 1.9. Cheers. On Tue, 15 Jan 2019 at 13:16, David Carlier wrote: > > Thanks here a proposed patch. > > Kind regards. > > On Tue, 15 Jan 2019 at 13:10, Willy Tarreau wrote: > > > > Hi David, > &g

Re: Haproxy 1.9 / DeviceAtlas module

2019-01-15 Thread David Carlier
Thanks here a proposed patch. Kind regards. On Tue, 15 Jan 2019 at 13:10, Willy Tarreau wrote: > > Hi David, > > On Tue, Jan 15, 2019 at 11:12:16AM +, David Carlier wrote: > > Hi dear list, > > > > A customer of use encountered an issue while compiling w

Haproxy 1.9 / DeviceAtlas module

2019-01-15 Thread David Carlier
Hi dear list, A customer of use encountered an issue while compiling with the DeviceAtlas module. Seems due to the struct buffer changes it underwent a little while ago ... Could you confirm the area member is equivalent to the previous p one ? Thanks in advance. Kindest regards.

Re: [PATCH]: BUILD/SMALL htx

2018-11-27 Thread David CARLIER
No worries as long it is fixed. Cheers ! On Wed, 28 Nov 2018 at 03:25, Willy Tarreau wrote: > > Hi David, > > On Tue, Nov 27, 2018 at 09:17:20AM +, David CARLIER wrote: > > Hi there, > > > > Here a tiny change to make every OS "happy" when displaying

[PATCH]: BUILD/SMALL htx

2018-11-27 Thread David CARLIER
Hi there, Here a tiny change to make every OS "happy" when displaying the extra bytes. Hope it s good enough. Kind regards. From edb65e47c6230d23d1078e41a603b7e5df3c9ac6 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 26 Nov 2018 15:02:38 + Subject: [PATCH] BUILD/SMALL

h1 buffer / confirmation

2018-11-20 Thread David CARLIER
Hi Christopher (I think you maintain it), Just to confirm into src/h1_mux.c, line 131 you meant h1c->flags & *(H1C_F_CS_ERROR|H1C_F_CS_SHUTW*) instead ? Kind regards.

Re: [PATCH]: BUILD/MEDIUM: DragonFly fix

2018-11-12 Thread David CARLIER
The correct patch is in the second message, in case it was missed :-) Thanks. Regards. On Mon, 12 Nov 2018 at 16:28, David CARLIER wrote: > > No sorry that was a bad patch, I thought earlier DragonFlyBSD did not > support but in fact it does. > On Mon, 12 Nov 2018 at 16:25, Willy TA

Re: [PATCH]: BUILD/MEDIUM: DragonFly fix

2018-11-12 Thread David CARLIER
No sorry that was a bad patch, I thought earlier DragonFlyBSD did not support but in fact it does. On Mon, 12 Nov 2018 at 16:25, Willy TARREAU wrote: > > Hi David, > > On Mon, Nov 12, 2018 at 04:16:17PM +, David CARLIER wrote: > > Subject: [PATCH] BUILD/MEDIUM: Drag

Re: [PATCH]: BUILD/MEDIUM: DragonFly fix

2018-11-12 Thread David CARLIER
Sorry, bas patch... Here the correct one. Regards. On Mon, 12 Nov 2018 at 16:16, David CARLIER wrote: > > Hi, > > Here a little patch proposal to fix this plarticular platform build. > > Cheers. From e16a4199362748b2492c89e9693e845df28a2eb4 Mon Sep 17 00:00:00 2001 From: David

[PATCH]: BUILD/MEDIUM: DragonFly fix

2018-11-12 Thread David CARLIER
Hi, Here a little patch proposal to fix this plarticular platform build. Cheers. From 3155cfe8230a1adc6f4878c038474ec9d2aadbc3 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 12 Nov 2018 16:11:14 + Subject: [PATCH] BUILD/MEDIUM: DragonFlyBSD build fix This platform does not have

[PATCH]: MINOR :task another explicit cast

2018-06-05 Thread David CARLIER
Hi, Did a full rebuild and caught it only. Regards. From c8cda198a8315d780f11ebf03b44a7d2f686f733 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Tue, 5 Jun 2018 10:41:03 + Subject: [PATCH] MINOR: task: Fix compiler warning. Waking up task, when checking if it is a valid entry

Re: [PATCH]: silencing compilation warning

2018-06-01 Thread David CARLIER
Sure the comment above is sufficiently explanatory anyway. Whatever suits you best. Regards. On Fri, 1 Jun 2018 at 12:38, Olivier Houchard wrote: > Hi David, > > On Fri, Jun 01, 2018 at 12:27:15PM +0000, David CARLIER wrote: > > Hi, > > > > Here a little proposal t

[PATCH]: silencing compilation warning

2018-06-01 Thread David CARLIER
Hi, Here a little proposal to fix a compilation warning. Hope it s useful. Kind regards. From 2c1919351bbf5e1e03302b455a81315859bd3c41 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 1 Jun 2018 12:22:33 + Subject: [PATCH] CLEANUP: task_insert_into_tasklet_list explicit cast We

[PATCH] Mod security

2018-05-31 Thread David CARLIER
Hi list, Here a small diff for fixing few typos. Cheers ! 0001-Tiny-typos.patch Description: Binary data

Re: [PATCH 1/5]: random generator functions wrapper

2018-04-11 Thread David CARLIER
Plus not sure it really fits the usage here after second thoughts. Regards. On Wed 11 Apr 2018 6:36 PM David CARLIER <devne...@gmail.com> wrote: > Hi aleks. Getrandom is available since 3.17 kernel version (I think > correct me if I m wrong) as a syscall. Plus good care needs

Re: [PATCH 1/5]: random generator functions wrapper

2018-04-11 Thread David CARLIER
o use getrandom instead of random? > > http://man7.org/linux/man-pages/man2/getrandom.2.html > https://lwn.net/Articles/711013/ > > Best regards > Aleks > > > ---------- > *Von:* David CARLIER <devne...@gmail.com> > *Gesendet:* 11. April 20

[PATCH 1/5]: random generator functions wrapper

2018-04-11 Thread David CARLIER
Hi dear list, Here a patch proposal to have a wrapper around rand/random calls. If it s ok with this one I ll send the rest. Thanks. Kind regards. From 01b29c12410dba2797815aed1be602abc435902e Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Wed, 11 Apr 2018 17

Re: haproxy-1.8 build failure on FreeBSD/i386 (clang)

2018-02-21 Thread David CARLIER
Well, Haproxy uses directly a handmade Makefile and it might be possible to write a short c code test to detect such features (just thinking aloud). On 21 February 2018 at 14:15, Dmitry Sivachenko <trtrmi...@gmail.com> wrote: > > > On 21 Feb 2018, at 16:33, David CARLIER <

Re: haproxy-1.8 build failure on FreeBSD/i386 (clang)

2018-02-21 Thread David CARLIER
Might be irrelevant idea, but is it not possible to detect it via simple code test into the Makefile eventually ?

Re: Fwd: Plans for 1.9

2018-02-21 Thread David CARLIER
at 07:46, David CARLIER <devne...@gmail.com> wrote: > Yes in the case of LLVM/fuzzer, it defines main entry point (thus if your > tests you need to define a function entry point to receive the data) hence > it is better if haproxy was a library. Now since haproxy always has been &

Re: [PATCH]; BUILD/(VERY) MINOR

2018-02-19 Thread David CARLIER
Oh right makes a lot of sense let s drop it then :-) On 19 February 2018 at 07:19, Willy Tarreau <w...@1wt.eu> wrote: > Hi David, > > On Mon, Feb 12, 2018 at 02:14:28PM +, David CARLIER wrote: > > Hi > > > > I had this patch locally for couple of weeks

Re: Fwd: Plans for 1.9

2018-02-18 Thread David CARLIER
2018 at 07:26, Willy Tarreau <w...@1wt.eu> wrote: > Hi David, > > On Mon, Feb 12, 2018 at 03:38:15PM +, David CARLIER wrote: > > -- Forwarded message ------ > > From: David CARLIER <devne...@gmail.com> > > Date: 12 February 2018 at 15:

[PATCH]: BUILD/MINOR OpenBSD build fix

2018-02-18 Thread David CARLIER
Hi, Here a little patch proposal to fix OpenBSD build. Regards. From 999db97d098e1498321808544112a4e441c981c0 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Sun, 18 Feb 2018 19:36:42 + Subject: [PATCH] BUILD/MINOR: haproxy stdint.h is needed on OpenBSD fr uin

Re: haproxy-1.8 build failure on FreeBSD/i386 (clang)

2018-02-14 Thread David CARLIER
Whatever works best for you. Regards. On 14 February 2018 at 11:09, Dmitry Sivachenko <trtrmi...@gmail.com> wrote: > > > On 12 Feb 2018, at 17:37, David CARLIER <devne...@gmail.com> wrote: > > > > I think I m the one behing this relatively recent change ...

Fwd: Plans for 1.9

2018-02-12 Thread David CARLIER
-- Forwarded message -- From: David CARLIER <devne...@gmail.com> Date: 12 February 2018 at 15:37 Subject: Plans for 1.9 To: w...@1wt.eu Was thinking as a contrib work, making haproxy more fuzzer "compliant" (AFL and LLVM/fuzzer for example) which would mean

Fwd: haproxy-1.8 build failure on FreeBSD/i386 (clang)

2018-02-12 Thread David CARLIER
-- Forwarded message -- From: David CARLIER <devne...@gmail.com> Date: 12 February 2018 at 14:37 Subject: Re: haproxy-1.8 build failure on FreeBSD/i386 (clang) To: trtrmi...@gmail.com I think I m the one behing this relatively recent change ... why not adding in the con

[PATCH]; BUILD/(VERY) MINOR

2018-02-12 Thread David CARLIER
Hi I had this patch locally for couple of weeks just having the proper current year reliably for the verbosity information part, relying on the startup date. Kind regards. From deab708b01f90a14e466dcca29056b007eddd600 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Dat

Re: [PATCH]: hathread / atomic code for clang too

2018-01-11 Thread David CARLIER
:-) I forgot to mention can be backported to 1.8 as well. Cheers ! On 11 January 2018 at 14:30, Willy TARREAU <wtarr...@haproxy.com> wrote: > On Thu, Jan 11, 2018 at 02:26:06PM +0000, David CARLIER wrote: > > Hi here a tiny fix proposal for the previous commit. > > Hi D

[PATCH]: hathread / atomic code for clang too

2018-01-11 Thread David CARLIER
Hi here a tiny fix proposal for the previous commit. Hope it is good. Kind regards. From c1f299b45e56c77fc51b2e773272195ddaee46a7 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Thu, 11 Jan 2018 14:20:43 + Subject: [PATCH] BUILD/MINOR: ancient gcc versions atom

Re: [PATCH]: spoa example build update

2017-12-27 Thread David CARLIER
gt; don't worry) : > > On Wed, Dec 27, 2017 at 06:26:56PM +, David CARLIER wrote: > > From 2e76de286db0e4672a9173e52a070e4b61452983 Mon Sep 17 00:00:00 2001 > > From: David Carlier <devne...@gmail.com> > > Date: Wed, 27 Dec 2017 13:19:14 + > > Subject: [PATCH]

Re: [PATCH]: spoa example build update

2017-12-27 Thread David CARLIER
On 27 December 2017 at 18:18, Willy Tarreau <w...@1wt.eu> wrote: > Hi David, > > On Wed, Dec 27, 2017 at 01:23:34PM +, David CARLIER wrote: > > diff --git a/contrib/spoa_example/Makefile b/contrib/spoa_example/ > Makefile > > index c44c2b879..71ba6107a 100644

[PATCH]: spoa example build update

2017-12-27 Thread David CARLIER
Hi, Here a little patch proposal to build the example. Kind regards. Thanks in advance. From e9be79654d9b1f7b63e3f13b9f61b5ad4543cdf3 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Wed, 27 Dec 2017 13:19:14 + Subject: [PATCH] BUILD/SMALL: contrib : spoa e

[PATCH]: BUILD/MINOR : cfgparse: parse_cpu_set under condition

2017-12-01 Thread David CARLIER
Hi, Here a little patch proposal to compile this function only when needed. Hope it is good. Thanks. From 7a1053f25331d21e164eae30dc1bad2400914f8d Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Fri, 1 Dec 2017 09:14:02 + Subject: [PATCH] BUILD/MINOR: h

[PATCH]: BUILD FreeBSD and cpu afifnity

2017-11-29 Thread David CARLIER
17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Wed, 29 Nov 2017 11:02:32 + Subject: [PATCH 1/2] BUILD/MINOR: haproxy : FreeBSD/cpu affinity needs pthread_np header for pthread_*_np calls, pthread_np.h is needed under FreeBSD. --- src/haproxy.c | 1 + 1 file chan

[PATCH]: BUILD/MINOR : TLS support check

2017-11-27 Thread David CARLIER
Hi, I m not sure this patch will be accepted and I ll understand ... this patch just check thread local storage support at compile time. I give more explanations in the commit message. Thanks. Kind regards. 0001-BUILD-MINOR-haproxy-check-TLS-support-at-compile-tim.patch Description: Binary

[PATCH]: BUILD : deviceatlas allow MT support

2017-11-27 Thread David Carlier
Hi, Following up the 1.8 release, deviceatlas being MT safe, we enable this new Haproxy feature from this module. Needs to be backported to 1.8 branch. Thanks in advance. Regards. From b2e649193e5707244638122d3df04e1224bd060d Mon Sep 17 00:00:00 2001 From: David Carlier <dcarl...@afilias.i

[PATCH] BUG/MEDIUM: deviceatlas

2017-11-17 Thread David Carlier
Hi, Here a patch to fix a potential crash in the deviceatlas module due to a customer report. Needs to be backported into the 1.7 branch. Thanks in advance. Kindest regards. From 537c91a8f20922001d5f2a857ec0adb3b57547bf Mon Sep 17 00:00:00 2001 From: David Carlier <dcarl...@afilias.info>

Re: [PATCH] : BUG/MINOR

2017-11-03 Thread David CARLIER
Sure makes sense in this case. Cheers. On 3 November 2017 at 14:50, Willy Tarreau <w...@1wt.eu> wrote: > On Fri, Nov 03, 2017 at 02:45:43PM +0000, David CARLIER wrote: > > Hi again, > > > > while testing a build, clang spotted the health desc field improper check

[PATCH] : BUG/MINOR

2017-11-03 Thread David CARLIER
Hi again, while testing a build, clang spotted the health desc field improper check so here a little patch proposal. That should be all after it :-). Kind regards. From e96a3190ada573dc39eb16e721dd1b9c297f9c45 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Fri,

Re: [PATCH]: BUG/MINOR

2017-11-03 Thread David CARLIER
Sure thing. and it does :-) On 3 November 2017 at 14:05, Willy TARREAU <wtarr...@haproxy.com> wrote: > Hi David, > > On Fri, Nov 03, 2017 at 12:03:53PM +, David CARLIER wrote: > > Hi > > > > Here is a tiny diff while I was trying to build under OpenBSD

[PATCH]: BUG/MINOR

2017-11-03 Thread David CARLIER
Hi Here is a tiny diff while I was trying to build under OpenBSD (not sure if few other oses are affected like Solaris but this change is not overkill I think). Kind regards. From deb8a3aca9aec73d2edd3461e5bf2d0f7c9153f5 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Dat

Re: PATCH/CLEANUP: log

2017-09-21 Thread David CARLIER
There are valid points especially about possible usage in memprintf :-) On 21 September 2017 at 16:28, Willy Tarreau <w...@1wt.eu> wrote: > Hi David, > > On Thu, Sep 21, 2017 at 04:15:51PM +0100, David CARLIER wrote: > > Hi all, > > > > At first my patch was su

PATCH/CLEANUP: log

2017-09-21 Thread David CARLIER
Hi all, At first my patch was supposed to be a bit more important but either some changes are already taking care of or after second thoughts some were not worthy enough. Hope it s good enough. Kind regards. From 4c694b4ff20a6ec88bc73c51a93c23de3f781c01 Mon Sep 17 00:00:00 2001 From: David

Re: [PATCH]: CLEANUP

2017-07-28 Thread David CARLIER
Good points :-) sorry for the noise. On 28 July 2017 at 14:07, Willy Tarreau <w...@1wt.eu> wrote: > Hi David, > > On Fri, Jul 28, 2017 at 01:58:29PM +0100, David CARLIER wrote: > > Hi all, > > > > Nothing serious, just a patch proposal to silent compiler war

[PATCH]: CLEANUP

2017-07-28 Thread David CARLIER
Hi all, Nothing serious, just a patch proposal to silent compiler warning about function parameter types. Kind regards. From 6ed9b28287440ca74e7a29016f9c4d081cd902d5 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Fri, 28 Jul 2017 14:42:42 +0100 Subject: [PATCH] C

Re: [PATCH]: using custom allocators into regex.

2017-07-21 Thread David CARLIER
After discussion with Willy I finally drop this change. Kind regards. On 21 July 2017 at 08:23, Willy Tarreau <w...@1wt.eu> wrote: > On Fri, Jul 21, 2017 at 08:17:14AM +0100, David CARLIER wrote: > > Hi Willy, fair points. > > I don't understand, this the patch still uses MALLOC/FREE. > > Willy >

Re: [PATCH]: using custom allocators into regex.

2017-07-21 Thread David CARLIER
no benefit in trying to optimize for > performance during this stage. However I agree that instrumenting a > malloc() call is sometimes quite useful. > > Willy > From a5bcdc300651d4bca888ba151a6055a3760a5e27 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com>

[PATCH]: using custom allocators into regex.

2017-07-21 Thread David CARLIER
{ void *(*alloc)(void *, size_t), void (*free)(void *, void *)} } to allow using hierarical based allocators like talloc for example ... just thinking aloud not sure it s relevant. Kind regards. From aab0ca1fd9e9f6584f2e2ab57ec290bbcd2bde23 Mon Sep 17 00:00:00 2001 From: David Carlier <de

[PATCH]: BUG/MINOR: general build fix for solaris based oses

2017-06-07 Thread David CARLIER
Hi, just tried a build under Illumos and the CMSG* macros implies XPG4V2 enabled. Hope it is useful. Kind regards. From 9ec3a111fc885528d7ac5d78d40f0b89079b5bb3 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Wed, 7 Jun 2017 20:02:43 +0100 Subject: [PATCH] BUG

[PATCH] BUG/MINOR: contrib/mod_defender

2017-06-07 Thread David CARLIER
Hi all, similarly to modsecurity, here is a proposal for mod_defender. Hope it is useful. Kind regards. From 8cbe58187a71eb505f7439b28847dccbc82a328a Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Wed, 7 Jun 2017 12:39:16 +0100 Subject: [PATCH] BUG/MINOR: c

Re: [PATCH] bis contrib mod security

2017-06-06 Thread David CARLIER
inux systems. > Maybe it will be better to add some variables like EVENT_INC and EVENT_LIB > > Thierry > > On 6 Jun 2017, at 09:44, David CARLIER <devne...@gmail.com> wrote: > > ping > > On 4 May 2017 at 21:50, David CARLIER <devne...@gmail.com> wrote: > >

Re: [PATCH] bis contrib mod security

2017-06-06 Thread David CARLIER
ping On 4 May 2017 at 21:50, David CARLIER <devne...@gmail.com> wrote: > Hi apologies the patch sent yesterday was not the correct one. > > Kind regards. >

[PATCH] bis contrib mod security

2017-05-04 Thread David CARLIER
Hi apologies the patch sent yesterday was not the correct one. Kind regards. 0001-BUG-MINOR-contrib-modsecurity-BSD-build-fix.patch Description: Binary data

[PATCH]: BUG/MINOR: contrib/modsecurity wrapper

2017-05-03 Thread David CARLIER
not sure about this last one but I needed it) Hope it helps. Regards. From 30ee992c0151419be0c21d98f3f7ea05192f6221 Mon Sep 17 00:00:00 2001 From: David CARLIER <devne...@gmail.com> Date: Wed, 3 May 2017 10:23:08 +0100 Subject: [PATCH] BUG/MINOR: contrib/mod_security: fix build on FreeBSD Fix

Re: [PATCH]: BUG/MINOR

2017-04-07 Thread David CARLIER
Apologies I did not read the mailing list :-). Regards. On 7 April 2017 at 21:03, Pavlos Parissis <pavlos.paris...@gmail.com> wrote: > On 07/04/2017 08:52 μμ, David CARLIER wrote: > > Hi all, > > > > I was trying to compile the 1.8 branch under DragonflyBSD and went

[PATCH]: BUG/MINOR

2017-04-07 Thread David CARLIER
Hi all, I was trying to compile the 1.8 branch under DragonflyBSD and went into a build failure, thus this patch proposal. Kindest regards. From 21d6dfd1a038e90ecb5103fb52322eae29fbbb86 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Fri, 7 Apr 2017 20:48:00 +0100 S

PATCH : CLEANUP

2017-04-03 Thread David CARLIER
Hi all, This is small necessary change for OpenBSD at least, hopes it finds its way. Kind regards. From 334acf5219fcc3bad9c965ce9f8725a48444ff34 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Mon, 3 Apr 2017 21:58:04 +0100 Subject: [PATCH] CLEANUP: server: moving n

Re: [PATCH] MEDIUM : regex : draft of pcre2 support

2016-12-28 Thread David CARLIER
Hi Willy looks good to me thanks. On 28 December 2016 at 11:54, Willy Tarreau wrote: > Hi David, > > On Tue, Nov 22, 2016 at 11:11:09AM +0100, Willy TARREAU wrote: >> Thanks, your patch looks pretty clean so I'm keeping it for 1.8. > > So I've merged it now. I had to slightly adapt

Re: lua support does not build on FreeBSD

2016-12-14 Thread David CARLIER
nion about this ? > > Thierry > > > On Wed, 14 Dec 2016 13:42:26 + > David CARLIER <devne...@gmail.com> wrote: > >> On Linux it s also an "alias" if I m not mistaken, someone might >> confirm it or not though. Kind regards. >> >> On

Re: lua support does not build on FreeBSD

2016-12-14 Thread David CARLIER
On Linux it s also an "alias" if I m not mistaken, someone might confirm it or not though. Kind regards. On 14 December 2016 at 13:32, Dmitry Sivachenko <trtrmi...@gmail.com> wrote: > >> On 14 Dec 2016, at 16:24, David CARLIER <devne...@gmail.com> wrote: >>

lua support does not build on FreeBSD

2016-12-14 Thread David CARLIER
Hi, I ve made a small patch for 1.8 branch though. Does it suit ? (ie I made all the fields available, not sure if would be useful one day). Kind regards. From 7dff470cdbe0ea00ce78b504e95f8c639a11a365 Mon Sep 17 00:00:00 2001 From: David CARLIER <devne...@gmail.com> Date: Wed, 14 Dec 2016

Re: [PATCH] MEDIUM : regex : draft of pcre2 support

2016-11-22 Thread David CARLIER
tu. Small detail I hardcoded lpcre2-posix ldflag due to this https://bugs.exim.org/show_bug.cgi?id=1924#c1 but that s ok as it is :-) Kindest regards. On 22 November 2016 at 10:11, Willy TARREAU <wtarr...@haproxy.com> wrote: > Hi David, > > On Mon, Nov 21, 2016 at 09:42:10PM +, D

[PATCH] MEDIUM : regex : draft of pcre2 support

2016-11-21 Thread David CARLIER
distributions (current debian stable, centos without EPEL repository, ...). I willingly kept it the changes smooth, simple and close to the pcre's part. Regards. From d0e5c5a85af2e06749f0b2f3958692b1cdc92af1 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Mon, 21 Nov 2016

Re: [PATCH] BUG/MEDIUM : fix Solaris build

2016-11-20 Thread David CARLIER
Ok fair enough, if I miss anything let me know, I put it simply before the function pointer of the main function. Kind regards. On 20 November 2016 at 09:46, Willy Tarreau <w...@1wt.eu> wrote: > Hi David, > > On Sat, Nov 19, 2016 at 07:34:44PM +, David CARLIER wrote: > &

[PATCH] BUG/MEDIUM : fix Solaris build

2016-11-19 Thread David CARLIER
Hi all, I was testng quickly a build on Solaris 10 and 11 and was wondering if this fix made sense ? Thanks in advance. Kind regards. From c2a10dc311c5ee353d0041eff04dbd10b74a6c3b Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Sat, 19 Nov 2016 19:14:26 + S

Re: [PATCH] MINOR: build: Allow linking to device-atlas library file

2016-10-10 Thread David CARLIER
Hi willy, I think that would be useful to backport it, even when 1.7 will be out, the 1.6 branch will be still used. Kind regards. On 8 October 2016 at 09:17, Willy Tarreau wrote: > Hi Bertrand, David, > > On Thu, Oct 06, 2016 at 11:15:08PM +0100, Bertrand Jacquin wrote: >>

Re: [PATCH] MINOR: build: Allow linking to device-atlas library file

2016-10-06 Thread David CARLIER
Hi, DEVICEATLAS_SRC instead of DEVICEATLAS_LIB might be more appropriated here ... +ifeq ($(DEVICEATLAS_LIB),) ... Otherwise seems ok to me. Cheers. On 6 October 2016 at 00:39, Bertrand Jacquin wrote: > DeviceAtlas might be installed in a location where a user might not

[PATCH]: MINOR: small memory leak fixes

2016-08-22 Thread David CARLIER
Hi all, I hope this little patch will find its use. Kind regards. From 7bf231bf75280bf63d9c69f6f8a782257daf6ce8 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Mon, 22 Aug 2016 23:27:42 +0100 Subject: [PATCH] MINOR: cfgparse: few memory leaks fixes. Some minor

Re: Fwd: [PATCH] : cleanup : connection

2016-07-04 Thread David CARLIER
Is this patch more suited ? On 4 July 2016 at 21:36, Cyril Bonté <cyril.bo...@free.fr> wrote: > Hi Willy, > > Le 04/07/2016 à 22:27, Willy TARREAU a écrit : > >> On Mon, Jul 04, 2016 at 10:20:05PM +0200, Cyril Bonté wrote: >> >>> Le 04/07/2016 à 14:21, Da

Fwd: [PATCH] : cleanup : connection

2016-07-04 Thread David CARLIER
Oh sorry did not get you I admit I did not look at all at Linux header ... On 4 July 2016 at 13:16, Cyril Bonté <cyril.bo...@free.fr> wrote: > Hi again, > > > De: "David CARLIER" <devne...@gmail.com> > > À: "Cyril Bonté" <cyril.bo...@free.fr&

Re: [PATCH] : cleanup : connection

2016-07-04 Thread David CARLIER
If you all prefer a patch like ? ... #ifndef BSD #define th_sport source #define th_dport dest #endif ... On 4 July 2016 at 12:55, Cyril Bonté <cyril.bo...@free.fr> wrote: > Hi all, > > > De: "David CARLIER" <devne...@gmail.com> > > À: haproxy@formilux.or

[PATCH] : cleanup : connection

2016-07-04 Thread David CARLIER
Hi, this is a patch for making it compilable on all BSD. PS: after reading the mailing list I saw somebody already proposed a patch but my patch fixes all BSD not only Darwin. Kind regards. From f88246058caf16f12435dd3230dbd0399fac85d8 Mon Sep 17 00:00:00 2001 From: David CARLIER <de

[PATCH]: CLEANUP dumpstats

2016-06-27 Thread David CARLIER
Hi all, Here an harmless little cleanup patch. Hope it finds its way. Regards. From 50f7117a14780b491c33a12fc631e5e75e8c185e Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Mon, 27 Jun 2016 14:12:59 +0100 Subject: [PATCH] CLEANUP: dumpstats: u64 field is an unsigne

Re: PATCH 1/2: BUG/MEDIUM lua argument boundary fix

2016-04-28 Thread David CARLIER
> > On Wed, 27 Apr 2016 16:27:16 +0100 > David CARLIER <devne...@gmail.com> wrote: > > > Hi all, > > > > This is a first patch for the lua module already overviewed by Thierry > > Fournier. > > This one concerns a bug fix which was spotted by ca

PATCH 2/2: MINOR: lua : convertors / fetches -> migration to 64 bits for the argument mask

2016-04-27 Thread David CARLIER
The second patch which is just the migration to 64 bits type. Kindest regards. From 10a595d2e7ce93d39a03ce1a46863135bb4b4c18 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Wed, 27 Apr 2016 16:21:56 +0100 Subject: [PATCH 2/2] MINOR: lua: migrate the argument mask

PATCH 1/2: BUG/MEDIUM lua argument boundary fix

2016-04-27 Thread David CARLIER
:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Wed, 27 Apr 2016 16:14:50 +0100 Subject: [PATCH 1/2] BUG/MEDIUM: lua: protects the upper boundary of the argument list for converters/fetches. When a converter or sample is called from within a Lua code, there is a risk of invalid ar

[PATCH 1/4]: BUG/MINOR : server: risk of over reading the pref_net array.

2016-04-08 Thread David CARLIER
Hi, here a first patch among a small patchset. Kind regards. From 65b5807cfbdebf28f01695fa02a34cd0353d4212 Mon Sep 17 00:00:00 2001 From: David Carlier <dcarl...@afilias.info> Date: Fri, 8 Apr 2016 10:26:44 +0100 Subject: [PATCH 1/4] BUG/MINOR: server: risk of over reading the pref_net

[PATCH 4/4]: CLEANUP: proto_uxst: initialize socket before setting.

2016-04-08 Thread David CARLIER
Hi, This one might not find this way as it might then having a performance hit, I was outweighting the outcome for this patch myself ... We ll see. Regards. From f8713e332f99aee682ef12c7bbbc39766be3d3ff Mon Sep 17 00:00:00 2001 From: David Carlier <dcarl...@afilias.info> Date: Fri, 8 Apr 2

[CLEANUP]: proto_http

2016-04-04 Thread David CARLIER
HI all, After the important cleanup of this week end, here a much more modest one. Basically some gcc warnings suppressions. Hope it is useful. From 39d833189abea2f6c4671cc969302365dc7d9c45 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Mon, 4 Apr 2016 11:54:42

Re: CLEANUP: connection

2016-03-24 Thread David CARLIER
Sure :) but just "respected" the original form. On 24 March 2016 at 10:05, Willy TARREAU <wtarr...@haproxy.com> wrote: > On Thu, Mar 24, 2016 at 09:34:48AM +, David CARLIER wrote: > > - if (!memcmp(line, "TCP4 ", 5) != 0) { > > + if (!(memcmp(

CLEANUP: connection

2016-03-24 Thread David CARLIER
/ev_poll.c). Kind regards. From 377ae8167a051d0209d04b702bcbc5e78d64d53c Mon Sep 17 00:00:00 2001 From: David CARLIER <devne...@gmail.com> Date: Thu, 24 Mar 2016 09:22:36 + Subject: [PATCH] CLEANUP: connection: adding missing parenthesis Nothing harmful in here, just clarify that it appl

CLEANUP: chunk

2016-03-24 Thread David CARLIER
Hi all, Here a cleanup patch for the chunk_dup function. hope it can be useful. Regards. From 3d904193dc041bad266fd04f69b50a66b8429f54 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Wed, 23 Mar 2016 17:50:57 + Subject: [PATCH] CLEANUP: chunk: adding NULL

[PATCH] MINOR: DeviceAtlas slight update

2016-03-16 Thread David Carlier
17 00:00:00 2001 From: David Carlier <dcarl...@afilias.info> Date: Wed, 16 Mar 2016 10:09:55 + Subject: [PATCH] MINOR: da: Using ARG12 macro for the sample fetch and the convertor. Regarding the minor update introduced in the cd6c3c7cb4fdc9cf694b62241840e3fea30e03dd commit, the Devic

Re: PATCH 1/1: OPTIM: args

2016-03-15 Thread David CARLIER
()) */ > + int64_t arg_mask; /* arguments (ARG*()) */ > > It's nicer to leave it unsigned (uint64_t), as seeing negative numbers for > bitfields it really annoying when debugging. > > Ok no problems. > Thanks! > willy > > From bde853a0702e12

Re: PATCH 1/1: OPTIM: args

2016-03-14 Thread David CARLIER
Hi again, There is the same changes made in one patch to make the review more effective as the changes, finally, depend to each other. Cheers. On 14 March 2016 at 09:00, David CARLIER <devne...@gmail.com> wrote: > Hi all, > > This patch is in fact not exactly an OPTIM's kind b

PATCH 2/2 : OPTIM: sample

2016-03-14 Thread David CARLIER
Hi, this is the second part of the change, updating sample/convertors mask fields. Regards. From 69fec151d9715aadc5880374027a1ab018ed4b21 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Mon, 14 Mar 2016 08:42:48 + Subject: [PATCH 2/2] OPTIM: sample: Update th

PATCH 1/1: OPTIM: args

2016-03-14 Thread David CARLIER
: David Carlier <devne...@gmail.com> Date: Mon, 14 Mar 2016 08:39:28 + Subject: [PATCH 1/2] OPTIM: arg: Moves arg underlying type from 32 to 64 bits. ARG# macros allow to create a list up to 7 in theory but 5 in practice. The change to a guaranteed 64 bits type increase to up to 12. The

Re: [PATCH] CLEANUP: log

2016-02-29 Thread David CARLIER
Hi I hope this looks better this time. Kindest regards. On 29 February 2016 at 11:49, David CARLIER <devne...@gmail.com> wrote: > Sorry I did not see the whole email, just realized ok why not :-) > > On 29 February 2016 at 11:18, Willy Tarreau <w...@1wt.eu> wrote: >

Re: [PATCH] CLEANUP: log

2016-02-29 Thread David CARLIER
Sorry I did not see the whole email, just realized ok why not :-) On 29 February 2016 at 11:18, Willy Tarreau <w...@1wt.eu> wrote: > On Mon, Feb 29, 2016 at 10:37:33AM +0000, David CARLIER wrote: > > Hi no problems it is not a bugfix at all, usually just better to copy a > &g

Re: [PATCH] CLEANUP: log

2016-02-29 Thread David CARLIER
looked at it I started to scratch my > head wondering about the real purpose of the change and/or the reason for > the current code currently being that way. > > On Thu, Feb 18, 2016 at 09:58:49PM +, David CARLIER wrote: > > HI all, > > > > There is a tiny pat

[PATCH] CLEANUP: log

2016-02-18 Thread David CARLIER
HI all, There is a tiny patch proposal for the log component. Cheers. From f1924d813f37cd6444d9251605fdd823efb7fe20 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Thu, 18 Feb 2016 21:46:48 + Subject: [PATCH] CLEANUP: log The string to be escaped is not

Re: [PATCH 1/5]: CLEANUP

2016-02-16 Thread David CARLIER
not notice. So if you ignore this patchset, I wouldn't be affected :-) Kind regards. On 16 February 2016 at 16:33, Willy TARREAU <wtarr...@haproxy.com> wrote: > Hi David, > > On Wed, Jan 06, 2016 at 01:23:52PM +, David CARLIER wrote: > > Sure, it is mainly gcc 5.2/5.3

Re: [PATCH 1/5]: CLEANUP

2016-01-06 Thread David CARLIER
Sure, it is mainly gcc 5.2/5.3, sometimes clang 3.6 depending the machine I was working on. On 6 January 2016 at 13:15, Willy TARREAU <wtarr...@haproxy.com> wrote: > On Wed, Jan 06, 2016 at 01:11:46PM +0000, David CARLIER wrote: >> About ebtree, it is partly the c

Re: [PATCH 1/5]: CLEANUP

2016-01-06 Thread David CARLIER
wrote: > Hi David, > > On Tue, Dec 29, 2015 at 01:28:13PM +, David CARLIER wrote: >> Hi all, >> >> these are a set of independent patches which basically remove some >> void pointers arithmetics operations in various places. At least they >> can be appl

[PATCH 5/5]: CLEANUP

2015-12-29 Thread David CARLIER
From 49be1f078c467a54d9a61ceea37ab3c43c365975 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Tue, 29 Dec 2015 13:21:51 + Subject: [PATCH 5/5] CLEANUP: custom functions: void pointers arithmetic removal. fifth patch which applies to the custom memmem implemen

[PATCH 4/5] : CLEANUP

2015-12-29 Thread David CARLIER
fourth patch. From 7d6fdd29ae00b7817e01a5ba9770043d5e371ea8 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Tue, 29 Dec 2015 13:19:28 + Subject: [PATCH 4/5] CLEANUP: protocols: void pointers arithmetic removal. fourth patch which apply in one place only to the

[PATCH 2/5]: CLEANUP

2015-12-29 Thread David CARLIER
second patch. From 69c810f1e8d4f4a9aedcb18663bc6cdb66f69c2d Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Tue, 29 Dec 2015 13:15:47 + Subject: [PATCH 2/5] CLEANUP: list struct: void pointers arithmetic removal second path which applies to the LIST_ELEM macr

[PATCH 3/5} : CLEANUP

2015-12-29 Thread David CARLIER
third patch. From 9152cb5d982459ad0f67e848df884252cd309622 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Tue, 29 Dec 2015 13:17:38 + Subject: [PATCH 3/5] CLEANUP: stick tables: void pointers arithmetic removal. third patch which applies in a few place inside

  1   2   >