Re: [PATCH] BUG/MINOR: ssl: ssl_sock_parse_clienthello ignores session id

2018-11-29 Thread Willy Tarreau
On Thu, Nov 29, 2018 at 04:33:21PM +0100, Baptiste wrote: > (first, before I forget, the patch should be backported in 1.8) OK, I've added this in the commit message. > Test case was very fun: I have a HAProxy listening on 127.1:443 with my > cert. When I "curl" it, I could get the list of

Re: [PATCH] BUG/MINOR: ssl: ssl_sock_parse_clienthello ignores session id

2018-11-29 Thread Baptiste
the session ID length, but if you have a simple test case > it would be great. > > Also CCing Thierry who developed it in case he can test it. > > > From f2c79803c6bcb69866f54c8a5833bd0178bea64c Mon Sep 17 00:00:00 2001 > > From: Baptiste Assmann > > Date: Wed, 28 Nov 2018 1

Re: [PATCH] BUG/MINOR: ssl: ssl_sock_parse_clienthello ignores session id

2018-11-29 Thread Willy Tarreau
on ID length, but if you have a simple test case it would be great. Also CCing Thierry who developed it in case he can test it. > From f2c79803c6bcb69866f54c8a5833bd0178bea64c Mon Sep 17 00:00:00 2001 > From: Baptiste Assmann > Date: Wed, 28 Nov 2018 15:20:25 +0100

[PATCH] BUG/MINOR: ssl: ssl_sock_parse_clienthello ignores session id

2018-11-28 Thread Baptiste
this issue. Baptiste From f2c79803c6bcb69866f54c8a5833bd0178bea64c Mon Sep 17 00:00:00 2001 From: Baptiste Assmann Date: Wed, 28 Nov 2018 15:20:25 +0100 Subject: [PATCH] BUG/MINOR: ssl: ssl_sock_parse_clienthello ignores session id In ssl_sock_parse_clienthello(), the code considers that SSL