Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-10-10 Thread bjun...@gmail.com
Am Sa., 29. Sep. 2018 um 20:18 Uhr schrieb Willy Tarreau : > > Hi Adis, > > On Thu, Sep 27, 2018 at 05:32:22PM +0200, Adis Nezirovic wrote: > > On Thu, Sep 27, 2018 at 04:52:29PM +0200, Thierry Fournier wrote: > > > I Adis, > > > > > > Sorry for the delay, I processed a quick review, and all seems

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-09-29 Thread Willy Tarreau
Hi Adis, On Thu, Sep 27, 2018 at 05:32:22PM +0200, Adis Nezirovic wrote: > On Thu, Sep 27, 2018 at 04:52:29PM +0200, Thierry Fournier wrote: > > I Adis, > > > > Sorry for the delay, I processed a quick review, and all seems to be ok for > > me! > > > > BR, > > Thierry > > Great, happy to hear

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-09-27 Thread Adis Nezirovic
On Thu, Sep 27, 2018 at 04:52:29PM +0200, Thierry Fournier wrote: > I Adis, > > Sorry for the delay, I processed a quick review, and all seems to be ok for > me! > > BR, > Thierry Great, happy to hear that, I hope guys will merge it soon. Best regards, Adis

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-09-27 Thread Thierry Fournier
I Adis, Sorry for the delay, I processed a quick review, and all seems to be ok for me! BR, Thierry > On 27 Sep 2018, at 14:02, Adis Nezirovic wrote: > > On Mon, Sep 03, 2018 at 12:09:47PM +0200, Adis Nezirovic wrote: >> Hi Thierry, >> >> Have you had the time to review my patches? > >

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-09-27 Thread Adis Nezirovic
On Mon, Sep 03, 2018 at 12:09:47PM +0200, Adis Nezirovic wrote: > Hi Thierry, > > Have you had the time to review my patches? Thierry, Reviving this thread, do you have any objections about latest version of the patch (Lua stick table patch) Best regards, Adis

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-09-03 Thread Adis Nezirovic
On Fri, Aug 24, 2018 at 11:40:51PM +0200, Adis Nezirovic wrote: > Thierry, > > Something for Monday :-) > > Latest version of the patch in attachment: > > - Filter table format is flattened/simplified > - I've tried to address filter table format error messages > (what is the error, and which

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-24 Thread Adis Nezirovic
t;From 6b702ff6f12f919ba4d2f42a7962fa2345272382 Mon Sep 17 00:00:00 2001 From: Adis Nezirovic Date: Fri, 13 Jul 2018 12:18:33 +0200 Subject: [PATCH] MEDIUM: lua: Add stick table support for Lua. This ads support for accessing stick tables from Lua. The supported operations are reading general table info, lookup by string/

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-23 Thread Adis Nezirovic
On Thu, Aug 23, 2018 at 03:43:59PM +0200, Willy Tarreau wrote: > Does this mean I should merge Adis' patch or do you want to verify > other things ? Just let me know. Willy, I'll submit new patch later today with simplified filter definitions and then we can ask Thierry for final ack for the

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-23 Thread Willy Tarreau
Hi Thierry, On Thu, Aug 23, 2018 at 10:53:15AM +0200, Thierry Fournier wrote: (...) > Ok, it sounds good. I think this kind of syntax is easily understandable > and it allow a good way for filtering values. Does this mean I should merge Adis' patch or do you want to verify other things ? Just

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-23 Thread Thierry Fournier
Hi [...] >> I miss also the relation between oprators and between the content >> of operators. I mean AND or OR. How I understand your example: >> >> +local filter = { >> + lt={{"gpc0", 1}, {"gpc1", 2}}, >> + gt={{"conn_rate", 3}}, >> + eq={{"conn_cur", 4}} >> +} >> >>

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-21 Thread Adis Nezirovic
ive to the current > "n", can disappear and the ebmb_next() can return wrong memory. I was under impression that we only have to acquire lock and increment ref_cnt (so we can be sure our current node n is not deleted) ebmb_next() is called only when we're holding lock, first and every other

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-21 Thread Thierry Fournier
Hi Adis, Thanks for this patch, it is a very useful class. Some remark about the documentation and the formats: js:function:: StickTable.info() js:function:: StickTable.lookup(key) Maybe the specification and an example of the returnes

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-21 Thread Thierry Fournier
> On 20 Aug 2018, at 15:15, Adis Nezirovic wrote: > > On Mon, Aug 20, 2018 at 02:11:13PM +0200, Adis Nezirovic wrote: >> Hi guys, >> >> I've attached a patch to add stick table support to Lua. Operations are >> mostly similar to "show table" functionality from admin socket, namely: >> >> -

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-20 Thread Adis Nezirovic
7 00:00:00 2001 From: Adis Nezirovic Date: Fri, 13 Jul 2018 12:18:33 +0200 Subject: [PATCH] MEDIUM: lua: Add stick table support for Lua (read-only ops). --- doc/lua-api/index.rst | 46 + include/types/hlua.h | 1 + src/hlua_fcn.c| 401 +

[PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-20 Thread Adis Nezirovic
on Sep 17 00:00:00 2001 From: Adis Nezirovic Date: Fri, 13 Jul 2018 12:18:33 +0200 Subject: [PATCH] MEDIUM: lua: Add stick table support for Lua (read-only ops). --- doc/lua-api/index.rst | 46 + include/types/hlua.h | 1 + src/hlua_fcn.c| 401