Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-20 Thread PiBa-NL
Hi Willy, Op 16-11-2015 om 19:57 schreef Willy Tarreau: I agree with you since we don't know the timeout value nor what it applies to (connection or anything). Thus I think that we should first find and change that value, and maybe after that take your patch to permit real retries in case of

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-20 Thread Simon Horman
On Fri, Nov 20, 2015 at 11:58:19PM +0100, PiBa-NL wrote: > Hi Willy, > > Op 16-11-2015 om 19:57 schreef Willy Tarreau: > >I agree with you since we don't know the timeout value nor what it applies > >to (connection or anything). Thus I think that we should first find and > >change that value, and

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-20 Thread PiBa-NL
Hi Simon, Ok, ill try and see if i can add a config setting for it. And move the whitespace changes to a separate patch. Will take me some time.. Thanks for your feedback, PiBa-NL Op 21-11-2015 om 0:30 schreef Simon Horman: On Fri, Nov 20, 2015 at 11:58:19PM +0100, PiBa-NL wrote: Hi Willy,

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-20 Thread Willy Tarreau
On Sat, Nov 21, 2015 at 01:21:16AM +0100, PiBa-NL wrote: > Hi Simon, > > Ok, ill try and see if i can add a config setting for it. And move the > whitespace changes to a separate patch. > Will take me some time.. And for what it's worth, I was about to make the same comments as Simon. Please

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-16 Thread Willy Tarreau
Hi Pieter, On Mon, Nov 16, 2015 at 07:14:33PM +0100, PiBa-NL wrote: > >>But i think thats not so much a problem, it does still make > >>me wonder a little what happens if a packet is lost in the middle of a > >>tcp connection, will it resend like a normal tcp connection? Its > >>difficult to test

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-16 Thread PiBa-NL
Hi Willy, Op 16-11-2015 om 7:20 schreef Willy Tarreau: Hi Pieter, On Mon, Nov 16, 2015 at 12:13:50AM +0100, PiBa-NL wrote: -but check->conn->flags & 0xFF is a bit of s guess from observing the flags when it could connect but the server did not respond properly.. is there a other better way?

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-15 Thread PiBa-NL
Hi Willy, Op 15-11-2015 om 8:48 schreef Willy Tarreau: Pieter, I'm just seeing this part in your description while merging the patch : On Sun, Nov 08, 2015 at 07:19:21PM +0100, PiBa-NL wrote: HOWEVER. -i have not checked for memoryleaks, sockets not being closed properly (i dont know how

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-15 Thread Willy Tarreau
Hi Pieter, On Mon, Nov 16, 2015 at 12:13:50AM +0100, PiBa-NL wrote: > >-but check->conn->flags & 0xFF is a bit of s guess from observing the > >flags when it could connect but the server did not respond > >properly.. is there a other better way? > >This one is ugly. First, you should

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-14 Thread Willy Tarreau
Pieter, I'm just seeing this part in your description while merging the patch : On Sun, Nov 08, 2015 at 07:19:21PM +0100, PiBa-NL wrote: > >>>HOWEVER. > >>>-i have not checked for memoryleaks, sockets not being closed properly > >>>(i dont know how to..) I'm not worried for this one, at first

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-09 Thread Willy Tarreau
On Tue, Nov 10, 2015 at 09:52:21AM +0900, Simon Horman wrote: > I would slightly prefer if there was a more substantial comment in > process_email_alert() noting that retry occurs 3 times. Good point, I'll add this when merging. > But regardless: > Acked-by: Simon Horman

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-09 Thread Simon Horman
On Mon, Nov 09, 2015 at 11:11:53AM +0100, Willy Tarreau wrote: > Hi Pieter, > > > Hi Ben, Willy, Simon, > > > > Ben, thanks for the review. > > Hoping 'release pressure' has cleared for Willy i'm resending the > > patch now, with with your comments incorporated. > > > > CC, to Simon as

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-09 Thread Willy Tarreau
Hi Pieter, > Hi Ben, Willy, Simon, > > Ben, thanks for the review. > Hoping 'release pressure' has cleared for Willy i'm resending the > patch now, with with your comments incorporated. > > CC, to Simon as maintainer of mailers part so he can give approval (or > not). > > The original

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-08 Thread PiBa-NL
Forgot to include list, sorry. Op 8-11-2015 om 17:33 schreef PiBa-NL: Hi Ben, Willy, Simon, Ben, thanks for the review. Hoping 'release pressure' has cleared for Willy i'm resending the patch now, with with your comments incorporated. CC, to Simon as maintainer of mailers part so he can

Re: [PATCH] MEDIUM: mailer: try sending a mail up to 3 times

2015-11-08 Thread PiBa-NL
Forgot to include list, sorry. And then the attachment dropped of.. Resending. Op 8-11-2015 om 17:33 schreef PiBa-NL: Hi Ben, Willy, Simon, Ben, thanks for the review. Hoping 'release pressure' has cleared for Willy i'm resending the patch now, with with your comments incorporated. CC, to