Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-28 Thread Willy Tarreau
Hi Tim, On Tue, Aug 28, 2018 at 10:27:34PM +0200, Tim Düsterhus wrote: > Willy, > > Am 25.08.2018 um 08:13 schrieb Willy Tarreau: > > Done,thanks. > > > > I just noticed that the reg-test still carried the old name (h*), > instead of the new one (b*), because Frederic renamed them in the mean

Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-28 Thread Tim Düsterhus
Willy, Am 25.08.2018 um 08:13 schrieb Willy Tarreau: > Done,thanks. > I just noticed that the reg-test still carried the old name (h*), instead of the new one (b*), because Frederic renamed them in the mean time, while this patch still was pending. You should rename lua/h1.* to

Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-25 Thread Willy Tarreau
On Fri, Aug 24, 2018 at 05:53:03PM +0200, Tim Düsterhus wrote: > Willy, > > Am 24.08.2018 um 04:19 schrieb Willy Tarreau: > > Oh with H2 it's even simpler, streams are distinct from each other > > so we don't reuse them and the issue doesn't exist :-) > > > > Does this mean I should take

Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-24 Thread Willy Tarreau
On Fri, Aug 24, 2018 at 11:19:26PM +0200, Thierry Fournier wrote: > Technically, the patch works, but the reset of the Lua session was done > in the stream. This reset is done in the proto_http.c, so I'm not sure > that's the correct place for this reset. > > If the proto_http is the only one

Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-24 Thread Thierry Fournier
> On 24 Aug 2018, at 04:19, Willy Tarreau wrote: > > Hi Thierry, > > On Thu, Aug 23, 2018 at 09:37:43AM +0200, Thierry Fournier wrote: >> Hi, >> >> Your patch make sense, that's the right appoach, but I have a doubt about >> the place to use for doing the reinitialization. >> >> I add

Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-24 Thread Tim Düsterhus
Willy, Am 24.08.2018 um 04:19 schrieb Willy Tarreau: > Oh with H2 it's even simpler, streams are distinct from each other > so we don't reuse them and the issue doesn't exist :-) > > Does this mean I should take Patrick's patch ? > If you do so: Don't forget to squash in my reg-test (with the

Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-23 Thread Willy Tarreau
Hi Thierry, On Thu, Aug 23, 2018 at 09:37:43AM +0200, Thierry Fournier wrote: > Hi, > > Your patch make sense, that's the right appoach, but I have a doubt about > the place to use for doing the reinitialization. > > I add Willy in this thread in order to have http2 advisor. > > Before the

Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-23 Thread Thierry Fournier
Hi, Your patch make sense, that’s the right appoach, but I have a doubt about the place to use for doing the reinitialization. I add Willy in this thread in order to have http2 advisor. Before the 1.8 the Lua context was reinitialized with the stream because the stream was reinitialized

[PATCH] MEDIUM: reset lua transaction between http requests

2018-08-22 Thread Patrick Hemmer
Not sure if this is the right approach, but this addresses the issue for me. This should be backported to 1.8. -Patrick From 9087400de99a3925380cac4128a431cd48a09145 Mon Sep 17 00:00:00 2001 From: Patrick Hemmer Date: Wed, 22 Aug 2018 10:02:00 -0400 Subject: [PATCH] MEDIUM: reset lua transaction