Re: [PATCH] MINOR: Add server name & puid to LUA Server class.

2018-05-06 Thread Thierry Fournier
> On 3 May 2018, at 18:49, Willy Tarreau wrote: > > On Thu, May 03, 2018 at 03:35:41PM +0200, Thierry Fournier wrote: >> Ok, I understand ... I hesitate. I think that is better to keep >> the original type, but the consistency is a good reason to convert >> to string. >> >> I

Re: [PATCH] MINOR: Add server name & puid to LUA Server class.

2018-05-03 Thread Willy Tarreau
On Thu, May 03, 2018 at 03:35:41PM +0200, Thierry Fournier wrote: > Ok, I understand ... I hesitate. I think that is better to keep > the original type, but the consistency is a good reason to convert > to string. > > I doubt that integer operations (add, sub, ...) will be performed on > this id.

Re: [PATCH] MINOR: Add server name & puid to LUA Server class.

2018-05-03 Thread Tim Düsterhus
Thierry, Am 03.05.2018 um 15:35 schrieb Thierry Fournier: > Ok, I understand ... I hesitate. I think that is better to keep > the original type, but the consistency is a good reason to convert > to string. > > I doubt that integer operations (add, sub, ...) will be performed on > this id. So

Re: [PATCH] MINOR: Add server name & puid to LUA Server class.

2018-05-03 Thread Thierry Fournier
> On 3 May 2018, at 14:27, Patrick Hemmer wrote: > > > > On 2018/5/3 02:52, Thierry Fournier wrote: >>> On 2 May 2018, at 16:49, Willy Tarreau >>> wrote: >>> >>> Hi Thierry, >>> >>> when you have a moment, could you please give a quick look at these

Re: [PATCH] MINOR: Add server name & puid to LUA Server class.

2018-05-03 Thread Patrick Hemmer
On 2018/5/3 02:52, Thierry Fournier wrote: >> On 2 May 2018, at 16:49, Willy Tarreau wrote: >> >> Hi Thierry, >> >> when you have a moment, could you please give a quick look at these >> patches from Patrick so that I know if I can merge them or not ? There >> are 2 other ones on

Re: [PATCH] MINOR: Add server name & puid to LUA Server class.

2018-05-03 Thread Thierry Fournier
> On 2 May 2018, at 16:49, Willy Tarreau wrote: > > Hi Thierry, > > when you have a moment, could you please give a quick look at these > patches from Patrick so that I know if I can merge them or not ? There > are 2 other ones on the list. Hi Willy and Patrick, I check it. I

Fwd: [PATCH] MINOR: Add server name & puid to LUA Server class.

2018-05-02 Thread Willy Tarreau
Hi Thierry, when you have a moment, could you please give a quick look at these patches from Patrick so that I know if I can merge them or not ? There are 2 other ones on the list. Thanks, Willy On Sun, Apr 29, 2018 at 02:23:48PM -0400, Patrick Hemmer wrote: > --- > doc/lua-api/index.rst | 8

[PATCH] MINOR: Add server name & puid to LUA Server class.

2018-04-29 Thread Patrick Hemmer
--- doc/lua-api/index.rst | 8 src/hlua_fcn.c| 14 ++ 2 files changed, 22 insertions(+) diff --git a/doc/lua-api/index.rst b/doc/lua-api/index.rst index 7a77e46ee..cdb285957 100644 --- a/doc/lua-api/index.rst +++ b/doc/lua-api/index.rst @@ -925,6 +925,14 @@ Server