Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-30 Thread Frederic Lecaille
On 11/29/18 10:04 PM, Frederic Lecaille wrote: On 11/29/18 5:36 AM, Willy Tarreau wrote: Hi guys, On Wed, Nov 28, 2018 at 11:17:22AM +0100, Frederic Lecaille wrote: Perhaps we should "chmod +x" this script. Good point, done here. However I'm now seeing this when starting it :

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-29 Thread Willy Tarreau
On Thu, Nov 29, 2018 at 10:04:29PM +0100, Frederic Lecaille wrote: > Here is a patch for haproxy (named 0001-REGTEST*) to fix these issues. Works like a charm, thank you Fred! Now applied. Willy

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-29 Thread Frederic Lecaille
On 11/29/18 5:36 AM, Willy Tarreau wrote: Hi guys, On Wed, Nov 28, 2018 at 11:17:22AM +0100, Frederic Lecaille wrote: Perhaps we should "chmod +x" this script. Good point, done here. However I'm now seeing this when starting it : ## Starting varnishtest

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-29 Thread PiBa-NL
Hi Frederic, Op 29-11-2018 om 19:18 schreef Frederic Lecaille: On 11/29/18 8:47 AM, Willy Tarreau wrote: On Thu, Nov 29, 2018 at 05:36:35AM +0100, Willy Tarreau wrote: However I'm well aware that it's easier to work on improvements once the script is merged, so what I've done now is to merge

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-29 Thread Frederic Lecaille
On 11/29/18 8:47 AM, Willy Tarreau wrote: On Thu, Nov 29, 2018 at 05:36:35AM +0100, Willy Tarreau wrote: However I'm well aware that it's easier to work on improvements once the script is merged, so what I've done now is to merge it and create a temporary "reg-tests2" target in the makefile to

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-28 Thread Willy Tarreau
On Thu, Nov 29, 2018 at 05:36:35AM +0100, Willy Tarreau wrote: > However I'm well aware that it's easier to work on improvements once the > script is merged, so what I've done now is to merge it and create a > temporary "reg-tests2" target in the makefile to use it without losing > the existing

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-28 Thread Willy Tarreau
Hi guys, On Wed, Nov 28, 2018 at 11:17:22AM +0100, Frederic Lecaille wrote: > Perhaps we should "chmod +x" this script. Good point, done here. However I'm now seeing this when starting it : ## Starting varnishtest ## Testing with haproxy version:

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-28 Thread Frederic Lecaille
On 11/27/18 11:17 PM, PiBa-NL wrote: Hi Frederic, Willy, Op 27-11-2018 om 15:00 schreef Frederic Lecaille: On 11/27/18 10:44 AM, Frederic Lecaille wrote: On 11/27/18 9:52 AM, Willy Tarreau wrote: Hi guys, On Tue, Nov 27, 2018 at 09:45:25AM +0100, Frederic Lecaille wrote: I put the script

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-27 Thread Willy Tarreau
Hi Pieter, On Tue, Nov 27, 2018 at 11:17:42PM +0100, PiBa-NL wrote: > I've changed the the script to include the LEVEL parameter almost the way > the Makefile used it, changed behavior though so without the parameter it it > runs all tests. (...) > New path attached, which includes a LEVEL check.

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-27 Thread PiBa-NL
akefile to call the ./scripts/run-regtests.sh Please can someone check it again before merging.?. Thanks guys :). Regards, PiBa-NL (Pieter) From 989bf7ccbfd849deed450291121cdcc68796ba64 Mon Sep 17 00:00:00 2001 From: PiBa-NL Date: Tue, 27 Nov 2018 22:26:38 +0100 Subject: [PATCH] REGTEST/MINOR: scri

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-27 Thread Frederic Lecaille
ioned above. Seems to work ;) Willy, Here is a better patch which takes into an account the modification above and yours (the script is added in "tests" directory). You can merge it as-is. Regards, Fred >From 4432c10a0a822619c152aa187f18b2f6478ac565 Mon Sep 17 00:00:00 2001 From: PiBa-NL D

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-27 Thread Frederic Lecaille
822619c152aa187f18b2f6478ac565 Mon Sep 17 00:00:00 2001 From: PiBa-NL Date: Sun, 25 Nov 2018 16:46:44 +0100 Subject: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script Some tests require a minimal haproxy version or compilation options to be able to run successfully. This script allows t

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-27 Thread Willy Tarreau
Hi guys, On Tue, Nov 27, 2018 at 09:45:25AM +0100, Frederic Lecaille wrote: > > I put the script in the /reg-tests/ folder. Maybe it should have been > > besides the Makefile in the / root ? > > Yes I think it should be placed at the same level as the Makefile. Well, we already have a "scripts"

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-27 Thread Frederic Lecaille
On 11/25/18 4:59 PM, PiBa-NL wrote: Hi Frederic, Willy, Hi Pieter, Added the varnishtest script we have been discussing as a .patch this time. I put the script in the /reg-tests/ folder. Maybe it should have been besides the Makefile in the / root ? Yes I think it should be placed at the

[PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-25 Thread PiBa-NL
2001 From: PiBa-NL Date: Sun, 25 Nov 2018 16:46:44 +0100 Subject: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script Some tests require a minimal haproxy version or compilation options to be able to run successfully. This script allows to add 'requirements' to tests to check so