Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-27 Thread William Lallemand
On Wed, Jun 27, 2018 at 06:38:18AM +0200, Willy Tarreau wrote: > Tim, > > I've just added the following patch after finding another affected place > in smp_fetch_sc_trackers(). Fortunately this one couldn't happen, but the > checks on the code path definitely are wrong for the same reaons as in

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Willy Tarreau
Tim, I've just added the following patch after finding another affected place in smp_fetch_sc_trackers(). Fortunately this one couldn't happen, but the checks on the code path definitely are wrong for the same reaons as in the two other ones. Thus I prefer to make stktable_release() safe against

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Willy Tarreau
On Tue, Jun 26, 2018 at 04:30:38PM +0200, Tim Düsterhus wrote: > Willy, > > Am 26.06.2018 um 16:24 schrieb Willy Tarreau: > > I *think* your patch is OK. I just hate having multiple exit points when > > refcounts are involved, we're pretty sure that in a future version we'll > > As we sent

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Tim Düsterhus
Willy, Am 26.06.2018 um 16:24 schrieb Willy Tarreau: > I *think* your patch is OK. I just hate having multiple exit points when > refcounts are involved, we're pretty sure that in a future version we'll As we sent almost at the same time: I intentionally wrote it with the new return, instead of

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Tim Düsterhus
Willy, Am 26.06.2018 um 16:17 schrieb Willy Tarreau: > On Tue, Jun 26, 2018 at 03:57:29PM +0200, Tim Duesterhus wrote: >> diff --git a/src/stick_table.c b/src/stick_table.c >> index 42946545..8e16830d 100644 >> --- a/src/stick_table.c >> +++ b/src/stick_table.c >> @@ -1596,8 +1596,10 @@ static

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Willy Tarreau
On Tue, Jun 26, 2018 at 04:17:37PM +0200, Willy Tarreau wrote: > Hi Tim, > > On Tue, Jun 26, 2018 at 03:57:29PM +0200, Tim Duesterhus wrote: > > diff --git a/src/stick_table.c b/src/stick_table.c > > index 42946545..8e16830d 100644 > > --- a/src/stick_table.c > > +++ b/src/stick_table.c > > @@

Re: [PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Willy Tarreau
Hi Tim, On Tue, Jun 26, 2018 at 03:57:29PM +0200, Tim Duesterhus wrote: > diff --git a/src/stick_table.c b/src/stick_table.c > index 42946545..8e16830d 100644 > --- a/src/stick_table.c > +++ b/src/stick_table.c > @@ -1596,8 +1596,10 @@ static int sample_conv_table_trackers(const struct arg >

[PATCH 1/1] BUG/MAJOR: stick_table: Complete incomplete SEGV fix

2018-06-26 Thread Tim Duesterhus
This commit completes the incomplete segmentation fault fix in commit ac1f3ed64b58bd178865c6f2cc8f6f306d9e1e15. Likewise it must be backported to haproxy 1.8. --- reg-tests/stick-table/h0.vtc | 30 ++ src/stick_table.c| 6 -- 2 files changed,