Re: [PATCH 1/2] MINOR: add be_conn_free sample fetch

2018-08-25 Thread Patrick Hemmer
On 2018/8/25 01:30, Willy Tarreau wrote: > On Fri, Aug 24, 2018 at 06:18:23PM -0400, Patrick Hemmer wrote: >>> I disagree with making a special case above for maxconn 0. In fact for me >>> it just means that such a server cannot accept connections, so it simply >>> doesn't count in the sum, just

Re: [PATCH 1/2] MINOR: add be_conn_free sample fetch

2018-08-24 Thread Willy Tarreau
On Fri, Aug 24, 2018 at 06:18:23PM -0400, Patrick Hemmer wrote: > > I disagree with making a special case above for maxconn 0. In fact for me > > it just means that such a server cannot accept connections, so it simply > > doesn't count in the sum, just as if it were not present. > On a server,

Re: [PATCH 1/2] MINOR: add be_conn_free sample fetch

2018-08-24 Thread Patrick Hemmer
Also made 2 additional changes. One is to handle dynamic maxconn. The other is to handle the case where the maxconn is adjusted (via stats socket) to be less than the number of currently active connections, which would result in the value wrapping. Will update the srv_conn_free fetch with sim

Re: [PATCH 1/2] MINOR: add be_conn_free sample fetch

2018-08-22 Thread Willy Tarreau
Hi Patrick, On Thu, Aug 09, 2018 at 06:46:28PM -0400, Patrick Hemmer wrote: > > This adds the sample fetch 'be_conn_free([])'. This sample fetch > provides the total number of unused connections across available servers > in the specified backend. Thanks for writing this one, I recently figured

[PATCH 1/2] MINOR: add be_conn_free sample fetch

2018-08-09 Thread Patrick Hemmer
This adds the sample fetch 'be_conn_free([])'. This sample fetch provides the total number of unused connections across available servers in the specified backend. --- doc/configuration.txt | 15 ++- src/backend.c | 38 ++ 2 files changed,