Re: [PATCH v2] MINOR: http: Log warning if (add|set)-header fails

2018-05-28 Thread Willy Tarreau
On Mon, May 28, 2018 at 09:19:11PM +0200, Tim Düsterhus wrote: > Willy, > > Am 28.05.2018 um 14:59 schrieb Willy Tarreau: > > OK this was fine. I noticed that you also emitted the value for the servers > > but that this one was not filled in the code, and that there was almost > > nothing to do

Re: [PATCH v2] MINOR: http: Log warning if (add|set)-header fails

2018-05-28 Thread Tim Düsterhus
Willy, Am 28.05.2018 um 14:59 schrieb Willy Tarreau: > OK this was fine. I noticed that you also emitted the value for the servers > but that this one was not filled in the code, and that there was almost > nothing to do to get it, for the response case, which is useful because if > you see that

Re: [PATCH v2] MINOR: http: Log warning if (add|set)-header fails

2018-05-28 Thread Willy Tarreau
Hi again Tim, On Mon, May 28, 2018 at 10:57:59AM +0200, Willy Tarreau wrote: > > I added a counter and verified that it works using the stats socket. I > > copied > > it from elsewhere in proto_http. Please check whether I did correctly (not > > overcounting and such things). Also check whether