Re: [RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-03-04 Thread Willy Tarreau
On Mon, Mar 04, 2019 at 02:44:38PM +0100, Tim Düsterhus wrote: > One could limit the overall brotli resource usage by returning NULLs in > the custom allocator when the *total* (versus the per-stream) brotli > memory consumption exceeds a certain level. The handling of OOMs in the > remaining code

Re: [RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-03-04 Thread Tim Düsterhus
Willy, Am 04.03.19 um 14:36 schrieb Willy Tarreau: >>> can document such limits and let users decide on their own. We'll >>> need the equivalent of maxzlibmem though (or better, we can reuse it >>> to keep a single tunable and indicate it serves for any compression >>> algo so that there isn't

Re: [RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-03-04 Thread Willy Tarreau
Hi Tim, On Wed, Feb 27, 2019 at 01:23:28PM +0100, Tim Düsterhus wrote: > As mentioned in my reply to Aleks I don't have any numbers, because I > don't know to get them. My knowledge of both HAProxy's internals and C > is not strong enough to get those. > > The manpage documents this: > > >

Re: [RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-02-27 Thread Tim Düsterhus
Willy, Am 27.02.19 um 05:12 schrieb Willy Tarreau: > Hi Tim, > > On Tue, Feb 26, 2019 at 06:16:12PM +0100, Tim Düsterhus wrote: >> Willy, >> >> Am 13.02.19 um 17:57 schrieb Tim Duesterhus: >>> *snip* >> >> Are you able to give some (first, basic) feedback on this patch already? > > Not yet. In

Re: [RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-02-26 Thread Willy Tarreau
Hi Tim, On Tue, Feb 26, 2019 at 06:16:12PM +0100, Tim Düsterhus wrote: > Willy, > > Am 13.02.19 um 17:57 schrieb Tim Duesterhus: > > *snip* > > Are you able to give some (first, basic) feedback on this patch already? Not yet. In fact I don't know much what to think about it. The patch itself

Re: [RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-02-26 Thread Tim Düsterhus
Willy, Am 13.02.19 um 17:57 schrieb Tim Duesterhus: > *snip* Are you able to give some (first, basic) feedback on this patch already? Best regards Tim Düsterhus

Re: [RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-02-14 Thread Tim Düsterhus
Aleks, Am 14.02.19 um 12:00 schrieb Aleksandar Lazic: >> I am successfully able access brotli compressed URLs with Google Chrome, >> this requires me to disable `gzip` though (because haproxy prefers to >> select gzip, I suspect because `br` is last in Chrome's `Accept-Encoding` >> header). > >

Re: [RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-02-14 Thread Aleksandar Lazic
Hi Tim. Am 13.02.2019 um 17:57 schrieb Tim Duesterhus: > Willy, > Aleks, > List, > > this (absolutely non-ready-to-merge) patch adds support for brotli > compression as suggested in issue #21: > https://github.com/haproxy/haproxy/issues/21 Cool ;-) > It is tested on Ubuntu Xenial with

[RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-02-13 Thread Tim Duesterhus
Willy, Aleks, List, this (absolutely non-ready-to-merge) patch adds support for brotli compression as suggested in issue #21: https://github.com/haproxy/haproxy/issues/21 It is tested on Ubuntu Xenial with libbrotli 1.0.3: [timwolla@~]apt-cache policy libbrotli-dev