Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-17 Thread Willy Tarreau
On Tue, Apr 17, 2018 at 11:47:18PM +0200, PiBa-NL wrote: > Op 17-4-2018 om 17:46 schreef Willy Tarreau: > > On Tue, Apr 17, 2018 at 04:33:07PM +0200, Olivier Houchard wrote: > > > After talking with Willy, here is an updated patch that does that. > > > That way, the day we'll want to use

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-17 Thread PiBa-NL
Op 17-4-2018 om 17:46 schreef Willy Tarreau: On Tue, Apr 17, 2018 at 04:33:07PM +0200, Olivier Houchard wrote: After talking with Willy, here is an updated patch that does that. That way, the day we'll want to use EV_ONESHOT, we'll be ready, and won't miss any event. Now merged, thanks guys!

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-17 Thread Willy Tarreau
On Tue, Apr 17, 2018 at 04:33:07PM +0200, Olivier Houchard wrote: > After talking with Willy, here is an updated patch that does that. > That way, the day we'll want to use EV_ONESHOT, we'll be ready, and won't > miss any event. Now merged, thanks guys! Willy

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-17 Thread Olivier Houchard
Hi again, On Tue, Apr 17, 2018 at 01:07:49PM +0200, Olivier Houchard wrote: [...] > We only need one to prevent kevent() from trying to scanning the kqueue, so > only setting kev[0] should be enough. It's inside an #ifdef because > EV_RECEIPT was only implemented recently in OpenBSD, so all users

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-17 Thread Olivier Houchard
Hi Pieter, On Mon, Apr 16, 2018 at 10:41:48PM +0200, PiBa-NL wrote: > Hi Olivier, > > Op 16-4-2018 om 17:09 schreef Olivier Houchard: > > After some discussion with Willy, we came with a solution that may fix your > > problem with kqueue. > > Can you test the attached patch and let me know if it

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-16 Thread PiBa-NL
Hi Olivier, Op 16-4-2018 om 17:09 schreef Olivier Houchard: After some discussion with Willy, we came with a solution that may fix your problem with kqueue. Can you test the attached patch and let me know if it fixes it for you ? Minor variation of the patch, that uses EV_RECEIPT if available,

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-16 Thread Olivier Houchard
Hi, On Mon, Apr 16, 2018 at 03:37:34PM +0200, Olivier Houchard wrote: > Hi Pieter, > > On Fri, Apr 13, 2018 at 06:50:50AM +, Pi Ba wrote: > > Using poll (startup with -dk) the request works properly. > > After some discussion with Willy, we came with a solution that may fix your > problem

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-16 Thread Olivier Houchard
Hi Pieter, On Fri, Apr 13, 2018 at 06:50:50AM +, Pi Ba wrote: > Using poll (startup with -dk) the request works properly. After some discussion with Willy, we came with a solution that may fix your problem with kqueue. Can you test the attached patch and let me know if it fixes it for you ?

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-13 Thread Willy Tarreau
On Fri, Apr 13, 2018 at 06:50:50AM +, Pi Ba wrote: > Using poll (startup with -dk) the request works properly. Thank you Pieter! Willy

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-13 Thread Pi Ba
Using poll (startup with -dk) the request works properly. Op vr 13 apr. 2018 08:29 schreef Willy Tarreau : > Hi Pieter, > > On Fri, Apr 13, 2018 at 01:12:41AM +0200, PiBa-NL wrote: > > To clarify the issue is not that haproxy uses cpu by looping, the issue > is > > that haproxy

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-13 Thread Willy Tarreau
Hi Pieter, On Fri, Apr 13, 2018 at 01:12:41AM +0200, PiBa-NL wrote: > To clarify the issue is not that haproxy uses cpu by looping, the issue is > that haproxy prevents the page from loading in the browser. The 'fix' on the > old version after the commit introducing the issue was to call the

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-12 Thread PiBa-NL
Hi Willy, And a second mail as i just thought of one extra thing you wrote that maybe i misunderstand or perhaps confused you with a small remark about cpu usage in my earlier mail (that was a side effect of my other earlier but totally wrong code change..). I'm suspecting we could have

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-12 Thread PiBa-NL
Hi Willy, Op 13-4-2018 om 0:22 schreef Willy Tarreau: By the way you must really not try to debug an old version but stick to the latest fixes. Okay testing from now on with current master, just thought it would be easier to backtrack if i knew what particular new/missing event would possibly

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-12 Thread Willy Tarreau
Hi Pieter, On Fri, Apr 13, 2018 at 12:05:26AM +0200, PiBa-NL wrote: > Hi Willy, > > Okay did some more digging.. > > before and after the 'offending' commit the EV_SET calls are as follows in > attached screenshot, these seem to be the main cause of some things going > wrong. > (I think also

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-12 Thread PiBa-NL
Hi Willy, Op 12-4-2018 om 1:19 schreef Willy Tarreau: Thank you very much for pointing the exact line that causes you trouble. Well exact line.. probably not the right one. And yes just removing that line indeed breaks something else. (as expected..) Would you have the ability to try the

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-11 Thread Willy Tarreau
Hi Pieter, On Thu, Apr 12, 2018 at 12:16:21AM +0200, PiBa-NL wrote: > Hi List / Willy, > > Removing the line below 'fixes' my issue with kqueue poller and NTLM > authentication with option http-tunnel.. > Though i'm sure something is then broken then horribly also (CPU go's > 100%..). And i'm

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-11 Thread PiBa-NL
Hi List / Willy, Removing the line below 'fixes' my issue with kqueue poller and NTLM authentication with option http-tunnel.. Though i'm sure something is then broken then horribly also (CPU go's 100%..). And i'm not sure what the proper fix would be. (ive got to little knowledge of what the

1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-10 Thread PiBa-NL
Hi Haproxy List, I upgraded to 1.8.7 (coming from 1.8.3) and found i could no-longer use one of our IIS websites. The login procedure thats using windows authentication / ntlm seems to fail.. Removing option http-tunnel seems to fix this though. Afaik http-tunnel 'should' switch to tunnelmode