Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-24 Thread Willy Tarreau
On Fri, Aug 24, 2018 at 04:25:02PM +0200, Frederic Lecaille wrote: > Here is a reg testing file for this bug. Thanks, applied. Willy

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-24 Thread Frederic Lecaille
On 08/22/2018 04:32 AM, Willy Tarreau wrote: On Wed, Aug 22, 2018 at 12:46:47AM +0200, Cyril Bonté wrote: Le 22/08/2018 à 00:40, Cyril Bonté a écrit : Hi again Willy, Le 21/08/2018 à 22:55, Cyril Bonté a écrit : Thanks for the diag. I don't remember changing anything around the proxy

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-22 Thread Cyril Bonté
Hi Willy, Le 22/08/2018 à 05:42, Willy Tarreau a écrit : On Wed, Aug 22, 2018 at 04:32:49AM +0200, Willy Tarreau wrote: Excellent, I think I found it : trash.data = recv(conn->handle.fd, trash.area, trash.size, MSG_PEEK); if

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
On Wed, Aug 22, 2018 at 04:32:49AM +0200, Willy Tarreau wrote: > Excellent, I think I found it : > > trash.data = recv(conn->handle.fd, trash.area, trash.size, > MSG_PEEK); > if (trash.data < 0) { > if (errno

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
On Wed, Aug 22, 2018 at 12:46:47AM +0200, Cyril Bonté wrote: > Le 22/08/2018 à 00:40, Cyril Bonté a écrit : > > Hi again Willy, > > > > Le 21/08/2018 à 22:55, Cyril Bonté a écrit : > > > > Thanks for the diag. I don't remember changing anything around the proxy > > > > protocol, but it's possible

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
On Tue, Aug 21, 2018 at 10:55:40PM +0200, Cyril Bonté wrote: > > > OK, that one is my fault, I used a "listen" section for use_backend (maybe > > > we'll have to secure such configuration error to prevent segfaults). > > > > I don't see how it could be an issue, that's a completely supported > >

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Le 22/08/2018 à 00:40, Cyril Bonté a écrit : Hi again Willy, Le 21/08/2018 à 22:55, Cyril Bonté a écrit : Thanks for the diag. I don't remember changing anything around the proxy protocol, but it's possible that something subtle changed. Also it's not on the regular send/receive path so maybe

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Hi again Willy, Le 21/08/2018 à 22:55, Cyril Bonté a écrit : Thanks for the diag. I don't remember changing anything around the proxy protocol, but it's possible that something subtle changed. Also it's not on the regular send/receive path so maybe I overlooked certain parts and broke it by

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Le 21/08/2018 à 21:56, Willy Tarreau a écrit : On Tue, Aug 21, 2018 at 07:00:39PM +0200, Cyril Bonté wrote: Le 21/08/2018 à 18:36, Willy Tarreau a écrit : Cyril, if you want to test, please be sure to update to at least 1b13bfd as we've just added another fix on top of this series. OK, I

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
On Tue, Aug 21, 2018 at 07:00:39PM +0200, Cyril Bonté wrote: > Le 21/08/2018 à 18:36, Willy Tarreau a écrit : > > Cyril, > > > > if you want to test, please be sure to update to at least 1b13bfd as > > we've just added another fix on top of this series. > > OK, I was performing some tests, I've

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Le 21/08/2018 à 19:00, Cyril Bonté a écrit : Le 21/08/2018 à 18:36, Willy Tarreau a écrit : Cyril, if you want to test, please be sure to update to at least 1b13bfd as we've just added another fix on top of this series. OK, I was performing some tests, I've now updated with this patch. It

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Le 21/08/2018 à 18:36, Willy Tarreau a écrit : Cyril, if you want to test, please be sure to update to at least 1b13bfd as we've just added another fix on top of this series. OK, I was performing some tests, I've now updated with this patch. It looks better as now I don't see anymore hangs,

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
Cyril, if you want to test, please be sure to update to at least 1b13bfd as we've just added another fix on top of this series. Cheers, Willy

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
On Tue, Aug 21, 2018 at 06:01:59PM +0200, Olivier Houchard wrote: > Hi Cyril, > > On Tue, Aug 21, 2018 at 12:51:13PM +0200, Cyril Bonté wrote: > > Hi Willy, > > > > I'm afraid there's still some issues with HTTP/2 in the current dev branch > > :-( > > > > This morning, I've upgraded a test

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Olivier Houchard
Hi Cyril, On Tue, Aug 21, 2018 at 12:51:13PM +0200, Cyril Bonté wrote: > Hi Willy, > > I'm afraid there's still some issues with HTTP/2 in the current dev branch :-( > > This morning, I've upgraded a test server and discovered that some HTTPS > sites did not work anymore (content hangs and is

HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Hi Willy, I'm afraid there's still some issues with HTTP/2 in the current dev branch :-( This morning, I've upgraded a test server and discovered that some HTTPS sites did not work anymore (content hangs and is not sent to the client), I've also noticed some segfaults in haproxy. As this is a