Re: patch: fix build when USE_THREAD is not defined

2018-03-26 Thread Willy Tarreau
On Sat, Mar 24, 2018 at 07:02:32PM +0100, Christopher Faulet wrote: > Le 24/03/2018 à 13:19, ??? a écrit : > > please review attached patch > > Good catch. But instead of using #ifdef in queue.c, there are macros in > hathreads.h. Here is the updated patch. Now applied, thanks! Willy

Re: patch: fix build when USE_THREAD is not defined

2018-03-26 Thread Илья Шипицин
ok, let's use your approach 2018-03-25 16:52 GMT+05:00 Tim Düsterhus : > Илья, > > Am 24.03.2018 um 19:42 schrieb Илья Шипицин: > > in your patch comparision + empty loop will be executed even if > USE_THREADS > > is not defined. > > not very big performance overhead actually.

Re: patch: fix build when USE_THREAD is not defined

2018-03-25 Thread Tim Düsterhus
Илья, Am 24.03.2018 um 19:42 schrieb Илья Шипицин: > in your patch comparision + empty loop will be executed even if USE_THREADS > is not defined. > not very big performance overhead actually. > I'm sure that any compiler able to compile haproxy properly is able to remove the loop as part of

Re: patch: fix build when USE_THREAD is not defined

2018-03-24 Thread Илья Шипицин
in your patch comparision + empty loop will be executed even if USE_THREADS is not defined. not very big performance overhead actually. 2018-03-24 23:02 GMT+05:00 Christopher Faulet : > Le 24/03/2018 à 13:19, Илья Шипицин a écrit : > >> please review attached patch >> > >

Re: patch: fix build when USE_THREAD is not defined

2018-03-24 Thread Christopher Faulet
001 From: Ilya Shipitsin <chipits...@gmail.com> Date: Sat, 24 Mar 2018 17:17:32 +0500 Subject: [PATCH] MINOR: fix build when USE_THREAD is not defined src/queue.o: In function `pendconn_redistribute': /home/ilia/haproxy/src/queue.c:272: undefined reference to `thread_want_sync' src/queue.o: In

patch: fix build when USE_THREAD is not defined

2018-03-24 Thread Илья Шипицин
please review attached patch From ec9cdfa848d438378919d4f8f2b1cba2a16f3eaa Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin <chipits...@gmail.com> Date: Sat, 24 Mar 2018 17:17:32 +0500 Subject: [PATCH] MINOR: fix build when USE_THREAD is not defined src/queue.o: In function `pendconn_redist