Re: TLV problem after updating to 2.1.14

2020-04-04 Thread Hativ
Hello Willy, > Hativ, if I send you a patch to test next week, is it possible to > give > it a try on your side ? I'm interested in knowing if a clean "LOCAL" > connection works fine with Dovecot. If so then in parallel we can > file > a report on Dovecot to make their parser more robust but at

Re: TLV problem after updating to 2.1.14

2020-04-04 Thread Willy Tarreau
On Sat, Apr 04, 2020 at 01:49:06PM +0200, Tim Düsterhus wrote: > > Do you think we ought to refrain from sending any address at all ? > > I preferred to avoid possibly visible changes and apparently it didn't > > go that well :-/ > > > > Based on a strict reading of the proxy protocol definition

Re: TLV problem after updating to 2.1.14

2020-04-04 Thread Tim Düsterhus
Willy, Am 04.04.20 um 13:29 schrieb Willy Tarreau: >> Am 04.04.20 um 12:41 schrieb Tim Düsterhus: >>> The Dovecot source code is here: >>> https://github.com/dovecot/core/blob/de9968d623e331a18b43dfe8a00421f72f7f7962/src/lib-master/master-service-haproxy.c#L354 >>> >>> A quick glance at the

Re: TLV problem after updating to 2.1.14

2020-04-04 Thread Willy Tarreau
On Sat, Apr 04, 2020 at 12:52:07PM +0200, Tim Düsterhus wrote: > Hativ, > Willy, > > Am 04.04.20 um 12:41 schrieb Tim Düsterhus: > > The Dovecot source code is here: > > https://github.com/dovecot/core/blob/de9968d623e331a18b43dfe8a00421f72f7f7962/src/lib-master/master-service-haproxy.c#L354 > >

Re: TLV problem after updating to 2.1.14

2020-04-04 Thread Tim Düsterhus
Hativ, Willy, Am 04.04.20 um 12:41 schrieb Tim Düsterhus: > The Dovecot source code is here: > https://github.com/dovecot/core/blob/de9968d623e331a18b43dfe8a00421f72f7f7962/src/lib-master/master-service-haproxy.c#L354 > > A quick glance at the Dovecot code looks like Dovecot parses the proxy >

Re: TLV problem after updating to 2.1.14

2020-04-04 Thread Tim Düsterhus
Hativ, Am 04.04.20 um 08:22 schrieb Hativ: > what I've found in the meantime: Dovecot's error messages even appear > permanently, regardless of the TCP check. > > Reverting that commit (7f26391bc51ad56c31480d03f56e1db604f1c617) back solves > the issue. No more error message in Dovecot and the

[PATCH] fix function comment

2020-04-04 Thread Илья Шипицин
Hello, small fix attached. Ilya Shipitcin From 2cf4b1a3baab84e420dcbbdf084c8138b2f8bd25 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 4 Apr 2020 12:59:53 +0500 Subject: [PATCH] CLEANUP: src/log.c: fix comment "fmt" is passed to parse_logformat_string, adjust comment accordingly ---

Re: TLV problem after updating to 2.1.14

2020-04-04 Thread Hativ
Hello Tim, what I've found in the meantime: Dovecot's error messages even appear permanently, regardless of the TCP check. Reverting that commit (7f26391bc51ad56c31480d03f56e1db604f1c617) back solves the issue. No more error message in Dovecot and the Layer 7 check works again. What's the