Re: Speeding up opentracing build in CI ?

2021-06-09 Thread Willy Tarreau
On Thu, Jun 10, 2021 at 07:19:37AM +0200, Willy Tarreau wrote: > On Thu, Jun 10, 2021 at 10:15:46AM +0500, ??? wrote: > > OT takes about 30 sec (it is built with almost everything disabled). the > > biggest time eater is openssl-3.0.0 > > Maybe that one could be sped up too, I haven't

Re: Speeding up opentracing build in CI ?

2021-06-09 Thread Willy Tarreau
On Thu, Jun 10, 2021 at 10:15:46AM +0500, ??? wrote: > OT takes about 30 sec (it is built with almost everything disabled). the > biggest time eater is openssl-3.0.0 Maybe that one could be sped up too, I haven't checked if it uses parallel builds. > hopefully, OT will speed up to 10

Re: Speeding up opentracing build in CI ?

2021-06-09 Thread Илья Шипицин
OT takes about 30 sec (it is built with almost everything disabled). the biggest time eater is openssl-3.0.0 hopefully, OT will speed up to 10 sec by using parallel builds чт, 10 июн. 2021 г. в 10:05, Willy Tarreau : > On Thu, Jun 10, 2021 at 07:55:17AM +0300, ??? wrote: > > First one

Re: Speeding up opentracing build in CI ?

2021-06-09 Thread Willy Tarreau
On Thu, Jun 10, 2021 at 07:55:17AM +0300, ??? wrote: > First one is supposed to be cached one day together with "opt" folder. > > However, we can indeed use parallel builds until cache is enabled for > github actions OK. The other use case I saw was that it's more convenient for

Re: Speeding up opentracing build in CI ?

2021-06-09 Thread Илья Шипицин
First one is supposed to be cached one day together with "opt" folder. However, we can indeed use parallel builds until cache is enabled for github actions On Thu, Jun 10, 2021, 7:49 AM Willy Tarreau wrote: > Tim, Ilya, > > while testing Miroslav's fix, I found the opentracing build to be

Speeding up opentracing build in CI ?

2021-06-09 Thread Willy Tarreau
Tim, Ilya, while testing Miroslav's fix, I found the opentracing build to be quite slow and figured it doesn't use parallel builds. Do you have any objection against patching the script like this ? diff --git a/scripts/build-ot.sh b/scripts/build-ot.sh index 59d6af587..1c296b64b 100755 ---

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Willy Tarreau
On Thu, Jun 10, 2021 at 04:40:47AM +0200, Miroslav Zagorac wrote: > On 06/10/2021 04:20 AM, Willy Tarreau wrote: > > Thank you Miroslav. Just to be sure, is this in anyway related to the > > fix or not ? We need to make sure that we maintain a smooth upgrade > > path for those who provide

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Miroslav Zagorac
On 06/10/2021 04:20 AM, Willy Tarreau wrote: Thank you Miroslav. Just to be sure, is this in anyway related to the fix or not ? We need to make sure that we maintain a smooth upgrade path for those who provide packages. I'll retag your patch as BUG/MEDIUM as it really addresses an

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Willy Tarreau
On Thu, Jun 10, 2021 at 02:56:46AM +0200, Miroslav Zagorac wrote: > I forgot to mention that one should take the latest version of the > opentracing c wrapper (it is now 1.1.0). > > https://github.com/haproxytech/opentracing-c-wrapper Thank you Miroslav. Just to be sure, is this in anyway

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Miroslav Zagorac
I forgot to mention that one should take the latest version of the opentracing c wrapper (it is now 1.1.0). https://github.com/haproxytech/opentracing-c-wrapper -- Zaga What can change the nature of a man?

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Miroslav Zagorac
On 06/09/2021 11:46 AM, Miroslav Zagorac wrote: On 06/09/2021 09:10 AM, Willy Tarreau wrote: Hi Miroslav, On Mon, Jun 07, 2021 at 04:55:21PM +0200, Miroslav Zagorac wrote: ... In fact, the only access to these files is achieved only once at the beginning of the HAProxy process, in the

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Miroslav Zagorac
On 06/09/2021 09:10 AM, Willy Tarreau wrote: Hi Miroslav, On Mon, Jun 07, 2021 at 04:55:21PM +0200, Miroslav Zagorac wrote: ... In fact, the only access to these files is achieved only once at the beginning of the HAProxy process, in the initialization of threads. After this initialization, no

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Willy Tarreau
Hi Miroslav, On Mon, Jun 07, 2021 at 04:55:21PM +0200, Miroslav Zagorac wrote: > From 4bbbe5fd3e66a37ec9703723ba22b742e7926a07 Mon Sep 17 00:00:00 2001 > From: Miroslav Zagorac > Date: Mon, 7 Jun 2021 16:21:31 +0200 > Subject: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot