Re: SSL Labs says my server isn't doing ssl session resumption

2021-06-20 Thread Shawn Heisey
On 6/20/2021 3:16 PM, Lukas Tribus wrote: It's a haproxy bug, affecting 2.4 releases, I've filed an issue in our tracker: https://github.com/haproxy/haproxy/issues/1297 Almost always when I report a problem I'm having with a mature piece of software, I expect the issue to be PEBCAK, not an ac

Re: SSL Labs says my server isn't doing ssl session resumption

2021-06-20 Thread Willy Tarreau
On Sun, Jun 20, 2021 at 11:31:10PM +0200, Willy Tarreau wrote: > On Sun, Jun 20, 2021 at 11:16:15PM +0200, Lukas Tribus wrote: > > Hello Shawn, > > > > On Sun, 20 Jun 2021 at 14:03, Shawn Heisey wrote: > > > > > > On 6/20/2021 1:52 AM, Lukas Tribus wrote: > > > > Can you try disabling threading,

Re: SSL Labs says my server isn't doing ssl session resumption

2021-06-20 Thread Willy Tarreau
On Sun, Jun 20, 2021 at 11:16:15PM +0200, Lukas Tribus wrote: > Hello Shawn, > > On Sun, 20 Jun 2021 at 14:03, Shawn Heisey wrote: > > > > On 6/20/2021 1:52 AM, Lukas Tribus wrote: > > > Can you try disabling threading, by putting nbthread 1 in your config? > > > > That didn't help. From testssl

Re: SSL Labs says my server isn't doing ssl session resumption

2021-06-20 Thread Lukas Tribus
Hello Shawn, On Sun, 20 Jun 2021 at 14:03, Shawn Heisey wrote: > > On 6/20/2021 1:52 AM, Lukas Tribus wrote: > > Can you try disabling threading, by putting nbthread 1 in your config? > > That didn't help. From testssl.sh: > > SSL Session ID support yes > Session Resumption T

Re: SSL Labs says my server isn't doing ssl session resumption

2021-06-20 Thread Shawn Heisey
On 6/20/2021 1:52 AM, Lukas Tribus wrote: Can you try disabling threading, by putting nbthread 1 in your config? That didn't help. From testssl.sh: SSL Session ID support yes Session Resumption Tickets: yes, ID: no An upgrade to 2.4.1 would also be advisable, it actually f

Re: [PATCH] CLEANUP: Prevent channel-t.h from being detected as C++ by GitHub

2021-06-20 Thread Tim Düsterhus
Willy, On 6/20/21 11:49 AM, Willy Tarreau wrote: Well, I would say that this heuristic is totally broken because it should at least ensure there's no more word before a brace on the line. However I agree that usually we prefer to respect the comment format starting with an asterisk at the beginn

Re: [PATCH] CLEANUP: Prevent channel-t.h from being detected as C++ by GitHub

2021-06-20 Thread Willy Tarreau
Hi Tim, On Sat, Jun 19, 2021 at 04:56:30PM +0200, Tim Duesterhus wrote: > GitHub uses github/linguist to determine the programming language used for > each > source file to show statistics and to power the search. In cases of unique > file > extensions this is easy, but for `.h` files the situat

Re: SSL Labs says my server isn't doing ssl session resumption

2021-06-20 Thread Lukas Tribus
Hello Shawn, On Sun, 20 Jun 2021 at 08:39, Shawn Heisey wrote: > This is what SSL Labs now says for the thing that started this thread: > > Session resumption (caching)No (IDs assigned but not accepted) > Session resumption (tickets)Yes > > I'd like to get the caching item fixed, but I h

Re: SSL Labs says my server isn't doing ssl session resumption

2021-06-20 Thread Илья Шипицин
вс, 20 июн. 2021 г. в 11:43, Shawn Heisey : > On 6/17/2021 1:01 AM, Willy Tarreau wrote: > > I don't know if the config is responsible for this but I've just tested > > on haproxy.org and it does work there: > > > >Session resumption (caching) Yes > >Session resumption (tickets)