[PR] Some grammar in peers.txt

2021-10-29 Thread PR Bot
Dear list! Author: John Roesler Number of patches: 1 This is an automated relay of the Github pull request: Some grammar in peers.txt Patch title(s): Some grammar Link: https://github.com/haproxy/haproxy/pull/1436 Edit locally: wget

[PATCH 1/2] MINOR: jwt: Make invalid static JWT algorithms an error in `jwt_verify` converter

2021-10-29 Thread Tim Duesterhus
It is not useful to start a configuration where an invalid static string is provided as the JWT algorithm. Better make the administrator aware of the suspected typo by failing to start. --- src/sample.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/sample.c

[PATCH 2/2] BUG/MINOR: jwt: Fix jwt_parse_alg incorrectly returning JWS_ALG_NONE

2021-10-29 Thread Tim Duesterhus
Hi Remi, Willy, Is the length check at the start of `jwt_parse_alg()` actually useful? I would expect that the vast majority of strings passed are valid algorithms that are *not* `none`. Thus I expect this `if()` to almost never be `true`. Should the `if()` be removed and a new `case 'n'` be

Re: [EXTERNAL] Re: [PATCH] CLEANUP: http_fetch: Use ist helpers in smp_fetch_http_auth_bearer()

2021-10-29 Thread Willy Tarreau
On Fri, Oct 29, 2021 at 05:20:23PM +0200, Remi Tricot-Le Breton wrote: > > > Rémi, am I missing something or is it just that this code snippet indeed > > > has a bug that was not spotted by the regtests (which I'm fine with, > > > they're regression tests, not unit tests seeking 100% coverage) ? >

Re: [EXTERNAL] Re: [PATCH] CLEANUP: http_fetch: Use ist helpers in smp_fetch_http_auth_bearer()

2021-10-29 Thread Remi Tricot-Le Breton
Hello Tim, On 29/10/2021 16:57, Tim Düsterhus wrote: Willy, On 10/29/21 8:50 AM, Willy Tarreau wrote: I don't see how this can ever match:    - we search for a space in the first characters starting at    - if we find one such space, we check if these characters are exactly equal to

Re: [PATCH] CLEANUP: http_fetch: Use ist helpers in smp_fetch_http_auth_bearer()

2021-10-29 Thread Tim Düsterhus
Willy, On 10/29/21 8:50 AM, Willy Tarreau wrote: I don't see how this can ever match: - we search for a space in the first characters starting at - if we find one such space, we check if these characters are exactly equal to the string "Bearer" (modulo the case), and if so we take

Re: Does haproxy utlize openssl with AES-NI if present?

2021-10-29 Thread Shawn Heisey
On 10/29/21 3:58 AM, Emerson Gomes wrote: If you want "definitive proof" that you're not using AES-NI instructions during your benchmark, you could simply compile OpenSSL (and then HAproxy, linking it to this OpenSSL version) passing "-noaes" flag to GCC in the process. I know from other

Re: Does haproxy utlize openssl with AES-NI if present?

2021-10-29 Thread Emerson Gomes
Hello, If you want "definitive proof" that you're not using AES-NI instructions during your benchmark, you could simply compile OpenSSL (and then HAproxy, linking it to this OpenSSL version) passing "-noaes" flag to GCC in the process. Then, to make sure your compilation succeeded, check both

Re: HashiCorp

2021-10-29 Thread Kara Louis
Good Day, Just curious to know whether if you were able to review the email that I sent you before. Let me know if you have any questions. Best Regards, Kara Louis From: Kara Louis Sent: Wednesday, October 27, 2021 5:47 AM To: haproxy@formilux.org Subject:

Re: Is it possible to capture the body of http responses?

2021-10-29 Thread Willy Tarreau
On Thu, Oct 28, 2021 at 09:54:55AM -0700, Ryan Burn wrote: > On the size limit, ideally we'd like to capture up to the first 128k of the > body. But after doing some tests, it looks like we can only get up the first > 15k, even if we specify "http-response wait-for-body time 10s at-least > 128k".

Re: Does haproxy utlize openssl with AES-NI if present?

2021-10-29 Thread Willy Tarreau
On Thu, Oct 28, 2021 at 04:06:42PM -0600, Shawn Heisey wrote: > The file I transferred is 4GB in size, copied from /dev/urandom with dd.  > Did the pull from another machine on the same gigabit LAN.  I picked the > cipher by watching for TLS 1.2 ciphers shown by testssl.sh and choosing one > that

Re: [PATCH] CLEANUP: http_fetch: Use ist helpers in smp_fetch_http_auth_bearer()

2021-10-29 Thread Willy Tarreau
On Thu, Oct 14, 2021 at 07:48:08PM +0200, Tim Duesterhus wrote: > Remi, > > please find a suggested cleanup for your JWT patch series. I think that > using the ist functions results in easier to understand code, because you > don't need to manually calculate lengths and offsets. > > Apply with

Re: [PR] Typos fixed "it" should be "is"

2021-10-29 Thread Willy Tarreau
On Thu, Oct 28, 2021 at 09:09:13AM +0200, Tim Düsterhus wrote: > Willy, > > On 10/14/21 7:23 PM, PR Bot wrote: > > This is an automated relay of the Github pull request: > > Typos fixed "it" should be "is" > > > > Patch title(s): > > Typos fixed "it" should be "is" > > > > Link: > >