Re: [PATCH] Add the possibility to compress requests

2023-04-06 Thread Willy Tarreau
On Fri, Apr 07, 2023 at 12:56:54AM +0200, Olivier Houchard wrote: (...) > > OK otherwise it looks good to me. I suggest you adjust these cosmetic > > details and directly push it. > > Done, thanks! Thanks! > > I'm having one question by the way: how did you manage to test this ? > > Did you fin

Re: [PATCH] Add the possibility to compress requests

2023-04-06 Thread Olivier Houchard
On Thu, Apr 06, 2023 at 09:17:34PM +0200, Willy Tarreau wrote: > > > > +/* limit compression rate */ > > > > + if (global.comp_rate_lim > 0) > > > > + if (read_freq_ctr(&global.comp_bps_in) > > > > > global.comp_rate_lim) > > > > + goto fail; > > > > > >

Re: [PATCH] Add the possibility to compress requests

2023-04-06 Thread Willy Tarreau
On Thu, Apr 06, 2023 at 01:12:09AM +0200, Olivier Houchard wrote: > > Also I don't understand how you can have different algos for each direction > > since the config language allows you to define "compression algo" and > > "compression tocompress" so you cannot (apparently) have a situation where