Re: [PATCH 2/4] MEDIUM: connection: Send out generically allocated proxy-v2-options

2023-11-03 Thread Willy Tarreau
Alexander, I now merged your patch with the SMP_VAL_ change, after verifying that the reg-test is still OK. Thus 2.9-dev9 will contain it. Thanks! Willy

Re: [PATCH 2/4] MEDIUM: connection: Send out generically allocated proxy-v2-options

2023-11-03 Thread Willy Tarreau
On Fri, Nov 03, 2023 at 08:35:08PM +, Stephan, Alexander wrote: > Hi Willy, > > Thanks for the review. No problem for calling me Stephan, I am totally used > to that, my teachers did that for years. Oh I was sure you were used to but anyway I don't like calling people incorrectly. > > Yeah

RE: [PATCH 2/4] MEDIUM: connection: Send out generically allocated proxy-v2-options

2023-11-03 Thread Stephan, Alexander
Hi Willy, Thanks for the review. No problem for calling me Stephan, I am totally used to that, my teachers did that for years. > At first glance the patches look nice. Great!  > Yeah I agree, that part is not pretty. And as often in such code, not > handling errors makes them even more

Re: [PATCH 2/4] MEDIUM: connection: Send out generically allocated proxy-v2-options

2023-11-03 Thread Willy Tarreau
Hi Alexander, (and BTW sorry for having called you Stephan twice in the last thread, each time I have to make a mental effort due to how your first and last names are presented in your e-mail address). On Sat, Oct 28, 2023 at 07:32:20PM +, Stephan, Alexander wrote: > I've just finished the

Re: [PATCH 2/4] MEDIUM: connection: Send out generically allocated proxy-v2-options

2023-11-03 Thread Willy Tarreau
On Fri, Nov 03, 2023 at 05:15:03PM +, Stephan, Alexander wrote: > Hi Willy, > > Sorry, my email client probably did something weird... > I attached them now, should hopefully prevent any reformatting. Thanks for the fast response. I'll check them keeping in mind your last comments in your

RE: [PATCH 2/4] MEDIUM: connection: Send out generically allocated proxy-v2-options

2023-11-03 Thread Stephan, Alexander
Hi Willy, Sorry, my email client probably did something weird... I attached them now, should hopefully prevent any reformatting. Best, Alexander -Original Message- From: Willy Tarreau Sent: Friday, November 3, 2023 5:52 PM To: Stephan, Alexander Cc: haproxy@formilux.org Subject: Re:

Re: [PATCH 2/4] MEDIUM: connection: Send out generically allocated proxy-v2-options

2023-11-03 Thread Willy Tarreau
On Fri, Nov 03, 2023 at 05:14:33PM +0100, Willy Tarreau wrote: > Hi Stephan, > > On Fri, Nov 03, 2023 at 01:54:26PM +, Stephan, Alexander wrote: > > Hi Willy, > > > > Did you receive the other two mails with the updated patches? I couldn't > > find > > it the reply to first page in the

Re: [PATCH 2/4] MEDIUM: connection: Send out generically allocated proxy-v2-options

2023-11-03 Thread Willy Tarreau
Hi Stephan, On Fri, Nov 03, 2023 at 01:54:26PM +, Stephan, Alexander wrote: > Hi Willy, > > Did you receive the other two mails with the updated patches? I couldn't find > it the reply to first page in the archive although I CCed the list. That's > why I wanted to double-check, not to run in

RE: [PATCH 2/4] MEDIUM: connection: Send out generically allocated proxy-v2-options

2023-11-03 Thread Stephan, Alexander
Hi Willy, Did you receive the other two mails with the updated patches? I couldn't find it the reply to first page in the archive although I CCed the list. That's why I wanted to double-check, not to run in the previous situation. Best, Alexander -Original Message- From: Willy Tarreau

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-11-03 Thread Willy Tarreau
On Fri, Nov 03, 2023 at 08:55:54AM +, Ruei-Bang Chen wrote: > Hi Willy, > > The simplification makes sense! I don't mind you changing it at all. I really > appreciate the feedback from you. Perfect, that's merged now :-) Thank you for doing this work! Willy

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-11-03 Thread Ruei-Bang Chen
Hi Willy, The simplification makes sense! I don't mind you changing it at all. I really appreciate the feedback from you. Ruei-Bang From: Willy Tarreau Sent: Friday, November 3, 2023 1:50 AM To: Ruei-Bang Chen Cc: haproxy@formilux.org Subject: Re: [PATCH]

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-11-03 Thread Willy Tarreau
Hi Ruei-Bang, On Fri, Nov 03, 2023 at 04:58:36AM +, Ruei-Bang Chen wrote: > Hi Willy and the team, > > I just want to send a friendly reminder that I am still looking for feedback > for this patch. Thanks! > I totally understand that there might be other priorities coming up. When you >

Re: No Private Key found in '/etc/letsencrypt/live/www.mydomain.org/fullchain.pem.key

2023-11-03 Thread Christoph Kukulies
Thanks, Shawn, I always have my problems with the open form of the configuration file syntax (lua ?). The docs say it is a keyword under "crt" which in turn belongs to the "bind" options. Would it be correct to place it that way?: frontend http-in bind *:80 bind *:443 ssl crt