Re: [PATCH] BUG/MEDIUM: init: Initialize idle_orphan_conns for first server in server-template

2019-01-09 Thread Willy Tarreau
On Wed, Jan 09, 2019 at 08:20:47AM -0500, Daniel Corbett wrote: > Sure -- attached you will find the new patch with the updated details. Now merged, thank you! Willy

Re: [PATCH] BUG/MEDIUM: init: Initialize idle_orphan_conns for first server in server-template

2019-01-09 Thread Daniel Corbett
BUG/MEDIUM: init: Initialize idle_orphan_conns for first server in server-template When initializing server-template all of the servers after the first have srv->idle_orphan_conns initialized within server_template_init() The first server does not have this initialized and when http-reuse is

Re: [PATCH] BUG/MEDIUM: init: Initialize idle_orphan_conns for first server in server-template

2019-01-09 Thread Willy Tarreau
On Wed, Jan 09, 2019 at 11:54:36AM +0100, Olivier Houchard wrote: > Oops, that seems right, and the patch looks fine, Willy can you push it ? Sure. Daniel, may I put your real name or do you want to resubmit the patch ? We usually don't take patches using aliases only for the author. Thanks!

Re: [PATCH] BUG/MEDIUM: init: Initialize idle_orphan_conns for first server in server-template

2019-01-09 Thread Olivier Houchard
Hi, On Wed, Jan 09, 2019 at 01:44:08AM -0500, cripy wrote: > Hi, > > I found a segfault when using server-template within 1.9.x and 2.0-dev. > This seems to be related to "http-reuse" as when I set to "never" it does > not crash anymore. > > It appears that idle_orphan_conns is not being

[PATCH] BUG/MEDIUM: init: Initialize idle_orphan_conns for first server in server-template

2019-01-08 Thread cripy
Hi, I found a segfault when using server-template within 1.9.x and 2.0-dev. This seems to be related to "http-reuse" as when I set to "never" it does not crash anymore. It appears that idle_orphan_conns is not being properly initialized for the first server within the server-template. I was