Re: [PATCH] BUG/MINOR: Check if master-worker pipe getenv succeeded, also allow pipe fd 0 as valid.

2017-12-02 Thread Willy Tarreau
On Sat, Dec 02, 2017 at 12:31:54PM +0100, William Lallemand wrote: > Hi Pieter, > > Sorry for the late reply, the patch is good, however the commit message can be > cleaned up! :-) > > Can you please format it following the 11th rule of this documentation: >

Re: [PATCH] BUG/MINOR: Check if master-worker pipe getenv succeeded, also allow pipe fd 0 as valid.

2017-12-02 Thread William Lallemand
Hi Pieter, Sorry for the late reply, the patch is good, however the commit message can be cleaned up! :-) Can you please format it following the 11th rule of this documentation: http://git.haproxy.org/?p=haproxy-1.8.git;a=blob;f=CONTRIBUTING;hb=HEAD Thanks On Wed, Nov 29, 2017 at 08:59:11PM

Re: [PATCH] BUG/MINOR: Check if master-worker pipe getenv succeeded, also allow pipe fd 0 as valid.

2017-11-28 Thread William Lallemand
now. > > Regards, > > PiBa-NL / Pieter > > > From 486d7c759af03f9193ae3e38005d8325ab069b37 Mon Sep 17 00:00:00 2001 > From: PiBa-NL <pba_...@yahoo.com> > Date: Tue, 28 Nov 2017 23:22:14 +0100 > Subject: [PATCH] [PATCH] BUG/MINOR: Check if master-worker pipe getenv > succeeded, al

[PATCH] BUG/MINOR: Check if master-worker pipe getenv succeeded, also allow pipe fd 0 as valid.

2017-11-28 Thread PiBa-NL
Sep 17 00:00:00 2001 From: PiBa-NL <pba_...@yahoo.com> Date: Tue, 28 Nov 2017 23:22:14 +0100 Subject: [PATCH] [PATCH] BUG/MINOR: Check if master-worker pipe getenv succeeded, also allow pipe fd 0 as valid. On FreeBSD in quiet mode the stdin/stdout/stderr are closed which lets the mworke