Re: [PATCH] MINOR: ssl: deduplicate ca-file

On Thu, Nov 28, 2019 at 11:13:18AM +0100, William Lallemand wrote: > On Wed, Nov 27, 2019 at 05:10:10PM +0100, Emmanuel Hocdet wrote: > > > > Patches update, should address William’s comments. > > > > Thanks, merged! > It seems to have break the build on centos 6, could you take a look at

Re: [PATCH] MINOR: ssl: deduplicate ca-file

On Wed, Nov 27, 2019 at 05:10:10PM +0100, Emmanuel Hocdet wrote: > > Patches update, should address William’s comments. > Thanks, merged! -- William Lallemand

Re: [PATCH] MINOR: ssl: deduplicate ca-file

Hi William, > Le 22 nov. 2019 à 17:34, William Lallemand a écrit : > > Hi Manu, > > I have a few questions/remarks below: > >> Subject: [PATCH 1/3] MINOR: ssl: deduplicate ca-file >> [...] >> >> +static int ssl_store_load_locations_file(X509_STORE **store_ptr, char *path) >> +{ >> +

Re: [PATCH] MINOR: ssl: deduplicate ca-file

Hi Manu, I have a few questions/remarks below: > Subject: [PATCH 1/3] MINOR: ssl: deduplicate ca-file > [...] > > +static int ssl_store_load_locations_file(X509_STORE **store_ptr, char *path) > +{ > + struct ebmb_node *eb; > + struct cafile_entry *ca_e; > + > + eb =

Re: [PATCH] MINOR: ssl: deduplicate ca-file

Fix bad merge from my branch, > Le 22 nov. 2019 à 11:35, Emmanuel Hocdet a écrit : > > > Patches update with compat lib-ssl and crl-file. > Deduplicate Verify-stuff in memory will prevent file access when updating a > certificate with CLI. 0001-MINOR-ssl-deduplicate-ca-file.patch

Re: [PATCH] MINOR: ssl: deduplicate ca-file

Hi, > Le 29 oct. 2019 à 07:59, Willy Tarreau a écrit : > > Please, let's revisit this after the release. The only people able to > have a look at this and to have an opinion on it are all busy finishing > this release. > Patches update with compat lib-ssl and crl-file. Deduplicate

Re: [PATCH] MINOR: ssl: deduplicate ca-file

Hi Manu, On Fri, Oct 25, 2019 at 05:51:31PM +0200, Emmanuel Hocdet wrote: > Hi, > > add a second patch to address ca-list case. Please, let's revisit this after the release. The only people able to have a look at this and to have an opinion on it are all busy finishing this release. Thanks,

Re: [PATCH] MINOR: ssl: deduplicate ca-file

Hi, add a second patch to address ca-list case. ++ Manu > Le 24 oct. 2019 à 12:14, Emmanuel Hocdet a écrit : > > Hi, > > Little patch with big win when ca-file is used in server line. > > ++ > Manu > > <0001-MINOR-ssl-deduplicate-ca-file.patch> > 0001-MINOR-ssl-deduplicate-ca-file.patch

[PATCH] MINOR: ssl: deduplicate ca-file

Hi, Little patch with big win when ca-file is used in server line. ++ Manu 0001-MINOR-ssl-deduplicate-ca-file.patch Description: Binary data