Re: [PATCH] Support statistics in multi-process mode

2015-09-14 Thread Philipp Kolmann
Hi Willi, On 09/14/15 12:17, Willy Tarreau wrote: OK I now found a moment to spare some time on your patch. During my first lecture I didn't understand that it relied on SIGUSR2 to aggregate counters. I'm seeing several issues with that approach : I never had the intent to look like I did the

Re: [PATCH] Support statistics in multi-process mode

2015-09-14 Thread Aleksandar Lazic
Hi. Am 14-09-2015 12:17, schrieb Willy Tarreau: Hi Philipp, [snipped] What I'd like to have instead would be a per-proxy shared memory segment for stats in addition to the per-process one, that is updated using atomic operations each time other stats are updated. The max are a bit tricky

Re: [PATCH] Support statistics in multi-process mode

2015-09-14 Thread Willy Tarreau
On Mon, Sep 14, 2015 at 01:07:45PM +0200, Philipp Kolmann wrote: > Hi Willi, > > On 09/14/15 12:17, Willy Tarreau wrote: > >OK I now found a moment to spare some time on your patch. During my > >first lecture I didn't understand that it relied on SIGUSR2 to > >aggregate counters. I'm seeing

Re: [PATCH] Support statistics in multi-process mode

2015-09-14 Thread Willy Tarreau
Hi Philipp, OK I now found a moment to spare some time on your patch. During my first lecture I didn't understand that it relied on SIGUSR2 to aggregate counters. I'm seeing several issues with that approach : - the time to scan all the proxies can be huge. Some people on this list run

Re: [PATCH] Support statistics in multi-process mode

2015-09-07 Thread Willy Tarreau
Hi Philipp, On Wed, Sep 02, 2015 at 06:23:16PM +0200, Philipp Kolmann wrote: > Hi Willy, > > I saw once a message that you forgot about this patch, but never saw any > comment on this ever again: I remember I took a glance at it and there was something bothering me but I didn't have the time

Re: [PATCH] Support statistics in multi-process mode

2015-09-02 Thread Philipp Kolmann
Hi Willy, I saw once a message that you forgot about this patch, but never saw any comment on this ever again: On 04/24/15 12:34, root wrote: From: HiepNV Signed-off-by: root --- Makefile | 4 +- include/proto/shm_proxy.h | 28

[PATCH] Support statistics in multi-process mode

2015-04-24 Thread root
From: HiepNV hie...@vccloud.vn Signed-off-by: root hie...@vccloud.vn --- Makefile | 4 +- include/proto/shm_proxy.h | 28 +++ src/dumpstats.c | 59 ++- src/haproxy.c | 48 - src/shm_proxy.c | 439