Re: [PATCH] improve ssl guarding by switching to macro SSL_CLIENT_HELLO_CB instead of openssl version

On Sat, Jan 23, 2021 at 12:23:01AM +0500, Илья Шипицин wrote: > updated patch attached > Thanks, merged. -- William Lallemand

Re: [PATCH] improve ssl guarding by switching to macro SSL_CLIENT_HELLO_CB instead of openssl version

updated patch attached пт, 22 янв. 2021 г. в 19:16, William Lallemand : > You could define a HAVE_SSL_* macro like it's done elsewhere in the > code, for example "HAVE_SSL_CLIENT_HELLO_CB". > > > On Fri, Jan 22, 2021 at 06:59:58PM +0500, Илья Шипицин wrote: > > ping > > > > вт, 19 янв. 2021 г. в

Re: [PATCH] improve ssl guarding by switching to macro SSL_CLIENT_HELLO_CB instead of openssl version

You could define a HAVE_SSL_* macro like it's done elsewhere in the code, for example "HAVE_SSL_CLIENT_HELLO_CB". On Fri, Jan 22, 2021 at 06:59:58PM +0500, Илья Шипицин wrote: > ping > > вт, 19 янв. 2021 г. в 23:24, Илья Шипицин : > > > Any update on this? > > > > On Mon, Jan 18, 2021, 3:56 PM

Re: [PATCH] improve ssl guarding by switching to macro SSL_CLIENT_HELLO_CB instead of openssl version

ping вт, 19 янв. 2021 г. в 23:24, Илья Шипицин : > Any update on this? > > On Mon, Jan 18, 2021, 3:56 PM Илья Шипицин wrote: > >> we can do nasty thing. >> SSL_CLIENT_HELLO_CB is not defined for BoringSSL, we can (in >> openssl-compat.h) check whether BoringSSL is used and define that macro. >>

Re: [PATCH] improve ssl guarding by switching to macro SSL_CLIENT_HELLO_CB instead of openssl version

Any update on this? On Mon, Jan 18, 2021, 3:56 PM Илья Шипицин wrote: > we can do nasty thing. > SSL_CLIENT_HELLO_CB is not defined for BoringSSL, we can (in > openssl-compat.h) check whether BoringSSL is used and define that macro. > > I'm not sure it is good thing. > > if you thing it is,

Re: [PATCH] improve ssl guarding by switching to macro SSL_CLIENT_HELLO_CB instead of openssl version

we can do nasty thing. SSL_CLIENT_HELLO_CB is not defined for BoringSSL, we can (in openssl-compat.h) check whether BoringSSL is used and define that macro. I'm not sure it is good thing. if you thing it is, please modify patch when applying. I'm ok with such change. пн, 18 янв. 2021 г. в

Re: [PATCH] improve ssl guarding by switching to macro SSL_CLIENT_HELLO_CB instead of openssl version

пн, 18 янв. 2021 г. в 15:09, William Lallemand : > Hello, > > On Sat, Jan 16, 2021 at 11:25:05PM +0500, Илья Шипицин wrote: > > Hello, > > > > next openssl guarding patch > > > > Ilya > > > From b5ff0a9f1e0d2edc84981b39050e7f21d2b08ba8 Mon Sep 17 00:00:00 2001 > > From: Ilya Shipitsin > > Date:

Re: [PATCH] improve ssl guarding by switching to macro SSL_CLIENT_HELLO_CB instead of openssl version

Hello, On Sat, Jan 16, 2021 at 11:25:05PM +0500, Илья Шипицин wrote: > Hello, > > next openssl guarding patch > > Ilya > From b5ff0a9f1e0d2edc84981b39050e7f21d2b08ba8 Mon Sep 17 00:00:00 2001 > From: Ilya Shipitsin > Date: Sat, 16 Jan 2021 23:15:12 +0500 > Subject: [PATCH] BUILD: ssl: guard

[PATCH] improve ssl guarding by switching to macro SSL_CLIENT_HELLO_CB instead of openssl version

Hello, next openssl guarding patch Ilya From b5ff0a9f1e0d2edc84981b39050e7f21d2b08ba8 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 16 Jan 2021 23:15:12 +0500 Subject: [PATCH] BUILD: ssl: guard Client Hello callbacks with SSL_CLIENT_HELLO_CB macro instead of openssl version ---