Re: [PATCH 1/2] BUG/MEDIUM: Do not set agent health to zero if server is disabled in config

2015-01-23 Thread Willy Tarreau
On Fri, Jan 23, 2015 at 02:31:50PM +0900, Simon Horman wrote: On Thu, Jan 22, 2015 at 08:24:57PM +0100, Willy Tarreau wrote: Hi Simon, On Tue, Jan 20, 2015 at 01:22:38PM +0900, Simon Horman wrote: (...) This seems to have slipped through the cracks. I'm wondering if we could

Re: [PATCH 1/2] BUG/MEDIUM: Do not set agent health to zero if server is disabled in config

2015-01-22 Thread Simon Horman
On Thu, Jan 22, 2015 at 08:24:57PM +0100, Willy Tarreau wrote: Hi Simon, On Tue, Jan 20, 2015 at 01:22:38PM +0900, Simon Horman wrote: (...) This seems to have slipped through the cracks. I'm wondering if we could revisit it and the other patch in this series. Hmmm sorry for that. You

Re: [PATCH 1/2] BUG/MEDIUM: Do not set agent health to zero if server is disabled in config

2015-01-22 Thread Willy Tarreau
Hi Simon, On Tue, Jan 20, 2015 at 01:22:38PM +0900, Simon Horman wrote: (...) This seems to have slipped through the cracks. I'm wondering if we could revisit it and the other patch in this series. Hmmm sorry for that. You previously said that both patches were right, do you simply want me to

Re: [PATCH 1/2] BUG/MEDIUM: Do not set agent health to zero if server is disabled in config

2015-01-19 Thread Simon Horman
Hi Willy, On Mon, Dec 01, 2014 at 09:18:05AM +0900, Simon Horman wrote: On Wed, Nov 12, 2014 at 05:11:27PM +0900, Simon Horman wrote: On Wed, Nov 12, 2014 at 08:22:05AM +0100, Willy Tarreau wrote: Hi Simon, On Wed, Nov 12, 2014 at 03:55:53PM +0900, Simon Horman wrote: disable

Re: [PATCH 1/2] BUG/MEDIUM: Do not set agent health to zero if server is disabled in config

2014-11-30 Thread Simon Horman
On Wed, Nov 12, 2014 at 05:11:27PM +0900, Simon Horman wrote: On Wed, Nov 12, 2014 at 08:22:05AM +0100, Willy Tarreau wrote: Hi Simon, On Wed, Nov 12, 2014 at 03:55:53PM +0900, Simon Horman wrote: disable starts a server in the disabled state, however setting the health of an agent

Re: [PATCH 1/2] BUG/MEDIUM: Do not set agent health to zero if server is disabled in config

2014-11-12 Thread Simon Horman
On Wed, Nov 12, 2014 at 08:22:05AM +0100, Willy Tarreau wrote: Hi Simon, On Wed, Nov 12, 2014 at 03:55:53PM +0900, Simon Horman wrote: disable starts a server in the disabled state, however setting the health of an agent implies that the agent is disabled as well as the server. This

Re: [PATCH 1/2] BUG/MEDIUM: Do not set agent health to zero if server is disabled in config

2014-11-12 Thread Willy Tarreau
Hi Simon! On Wed, Nov 12, 2014 at 05:11:27PM +0900, Simon Horman wrote: I was aware you had done some work in this area but I wasn't entirely sure what case you were trying to fix. Thanks for filling in that gap in my knowledge. Yep. The agent-check is a really nice feature. Initially we

[PATCH 1/2] BUG/MEDIUM: Do not set agent health to zero if server is disabled in config

2014-11-11 Thread Simon Horman
disable starts a server in the disabled state, however setting the health of an agent implies that the agent is disabled as well as the server. This is a problem because the state of the agent is not restored if the state of the server is subsequently updated leading to an unexpected state. For

Re: [PATCH 1/2] BUG/MEDIUM: Do not set agent health to zero if server is disabled in config

2014-11-11 Thread Willy Tarreau
Hi Simon, On Wed, Nov 12, 2014 at 03:55:53PM +0900, Simon Horman wrote: disable starts a server in the disabled state, however setting the health of an agent implies that the agent is disabled as well as the server. This is a problem because the state of the agent is not restored if the