Re: [PATCH 1/2] MEDIUM: Only report drain state in stats if server has SRV_ADMF_DRAIN set

2015-04-09 Thread Willy Tarreau
Hi Simon! On Thu, Apr 09, 2015 at 03:47:13PM +0900, Simon Horman wrote: There are some similarities between a weight of zero and the administratively set drain state: both allow existing connections to continue while not accepting any new ones. However, when reporting a server state

Re: [PATCH 1/2] MEDIUM: Only report drain state in stats if server has SRV_ADMF_DRAIN set

2015-04-09 Thread Malcolm Turnbull
Willy / Simon, I think I've got a bit confused myself - I've just installed the patches and tested and it fixes the issues we seeing with HAProxy getting stuck in DRAIN mode when the agent temporarily responds with 0% idle. i.e. when the load on the server decreases HAProxy should automatically

[PATCH 1/2] MEDIUM: Only report drain state in stats if server has SRV_ADMF_DRAIN set

2015-04-09 Thread Simon Horman
There are some similarities between a weight of zero and the administratively set drain state: both allow existing connections to continue while not accepting any new ones. However, when reporting a server state generally a distinction is made between state=UP,weight=0 and state=DRAIN,weight=*.

Re: [PATCH 1/2] MEDIUM: Only report drain state in stats if server has SRV_ADMF_DRAIN set

2015-04-09 Thread Willy Tarreau
Hi Malcolm, On Thu, Apr 09, 2015 at 02:31:16PM +0100, Malcolm Turnbull wrote: Willy / Simon, I think I've got a bit confused myself - I've just installed the patches and tested and it fixes the issues we seeing with HAProxy getting stuck in DRAIN mode when the agent temporarily responds