Re: [PATCH v2 1/1] BUG/MINOR: mworker: Fix memory leak of mworker_proc members

2019-05-22 Thread Илья Шипицин
more findings https://travis-ci.org/chipitsine/haproxy-1/jobs/535709949#L1938-L1948 ср, 22 мая 2019 г. в 15:12, Илья Шипицин : > here's build with patch applied > > https://travis-ci.org/chipitsine/haproxy-1/jobs/535709947#L604-L608 > > ср, 22 мая 2019 г. в 14:43, William Lallemand : > >> Hi

Re: [PATCH v2 1/1] BUG/MINOR: mworker: Fix memory leak of mworker_proc members

2019-05-22 Thread Илья Шипицин
here's build with patch applied https://travis-ci.org/chipitsine/haproxy-1/jobs/535709947#L604-L608 ср, 22 мая 2019 г. в 14:43, William Lallemand : > Hi Tim, > > Sorry for the delay. > > I added 2 new lines in your patch: > > On Thu, May 16, 2019 at 08:23:22PM +0200, Tim Duesterhus wrote: > >

Re: [PATCH v2 1/1] BUG/MINOR: mworker: Fix memory leak of mworker_proc members

2019-05-22 Thread William Lallemand
Hi Tim, Sorry for the delay. I added 2 new lines in your patch: On Thu, May 16, 2019 at 08:23:22PM +0200, Tim Duesterhus wrote: > +void mworker_free_child(struct mworker_proc *child) { > + if (child == NULL) return; > + Which became: > +void mworker_free_child(struct mworker_proc *child)

[PATCH v2 1/1] BUG/MINOR: mworker: Fix memory leak of mworker_proc members

2019-05-16 Thread Tim Duesterhus
The struct mworker_proc is not uniformly freed everywhere, sometimes leading to leaks of the `id` string (and possibly the other strings). Introduce a mworker_free_child function instead of duplicating the freeing logic everywhere to prevent this kind of issues. This leak was reported in issue