Re: [PATCHES] SRV record support

2017-08-09 Thread Baptiste
On Wed, Aug 9, 2017 at 4:40 PM, Willy Tarreau wrote: > On Wed, Aug 09, 2017 at 04:00:04PM +0200, Olivier Houchard wrote: > > > > Hi, > > > > After some review and tests by Baptiste, here comes an updated patchset, > > with a few bugfixes. > > This one is probably mergeable. > > Now merged, thanks

Re: [PATCHES] SRV record support

2017-08-09 Thread Willy Tarreau
On Wed, Aug 09, 2017 at 04:00:04PM +0200, Olivier Houchard wrote: > > Hi, > > After some review and tests by Baptiste, here comes an updated patchset, > with a few bugfixes. > This one is probably mergeable. Now merged, thanks for this! I'm sure some people will quickly have interesting ideas to

Re: [PATCHES] SRV record support

2017-08-09 Thread Olivier Houchard
Hi, After some review and tests by Baptiste, here comes an updated patchset, with a few bugfixes. This one is probably mergeable. Regards, Olivier >From 1b408464590fea38d8a45b2b7fed5c615465a858 Mon Sep 17 00:00:00 2001 From: Olivier Houchard Date: Thu, 6 Jul 2017 18:46:47 +0200 Subject: [PATCH

Re: [PATCHES] SRV record support

2017-08-07 Thread Willy Tarreau
Hi Olivier, On Mon, Aug 07, 2017 at 07:29:23PM +0200, Olivier Houchard wrote: > > What makes the distinction between an SRV record and a real hostname here ? > > Just the leading underscore, or the plain "_http." maybe ? I'm not expecting > > any problem with this given that the underscore is not

Re: [PATCHES] SRV record support

2017-08-07 Thread Olivier Houchard
Hi, On Fri, Aug 04, 2017 at 09:18:30PM +0200, Willy Tarreau wrote: > Just a few questions and minor comments below : > > On Fri, Aug 04, 2017 at 06:49:43PM +0200, Olivier Houchard wrote: > > This also adds support for SRV records. To use them, simply use a SRV label > > instead of a hostname on t

Re: [PATCHES] SRV record support

2017-08-04 Thread Willy Tarreau
Hi Jerry, On Fri, Aug 04, 2017 at 12:47:51PM -0700, Jerry Scharf wrote: > Willy, > > I can't answer for the code but I can talk about SRV records. I helped bury > some of the bodies in DNS. :) > > A SRV record in DNS is a different type of record, like MX, PTR, TXT,... > > You can think of SRV

Re: [PATCHES] SRV record support

2017-08-04 Thread Jerry Scharf
Willy, I can't answer for the code but I can talk about SRV records. I helped bury some of the bodies in DNS. :) A SRV record in DNS is a different type of record, like MX, PTR, TXT,... You can think of SRV as MX generalized for any listener. The naming form is _http._tcp to keep it from col

Re: [PATCHES] SRV record support

2017-08-04 Thread Willy Tarreau
Just a few questions and minor comments below : On Fri, Aug 04, 2017 at 06:49:43PM +0200, Olivier Houchard wrote: > This also adds support for SRV records. To use them, simply use a SRV label > instead of a hostname on the server line, ie : > server s1 _http._tcp.example.com resolvers dns check >

Re: [PATCHES] SRV record support

2017-08-04 Thread Willy Tarreau
Hi Olivier, On Fri, Aug 04, 2017 at 06:49:43PM +0200, Olivier Houchard wrote: > Hi guys, > > Following Baptiste's work on DNS, the attached patchset adds support for DNS > obsolescence, and SRV support. (...) Really cool, thank you. Let's wait for some feedback. Willy

[PATCHES] SRV record support

2017-08-04 Thread Olivier Houchard
Hi guys, Following Baptiste's work on DNS, the attached patchset adds support for DNS obsolescence, and SRV support. DNS obsolescence means we cache DNS answers, and only consider the entries are gone if we don't see for X seconds, X being defined in the config file with the "hold obsolete" entry