Re: [Patch] Re: Segfault with haproxy 1.8.10

2018-06-26 Thread Tim Düsterhus
Hi Am 26.06.2018 um 13:56 schrieb Willy Tarreau: > Your patch is obviously good, I've just merged it. > Should sample_conv_table_trackers also be updated? It also checks whether `ts` is valid, before accessing it, but unconditionally calls stktable_release later on. Best regards Tim Düsterhus

Re: [Patch] Re: Segfault with haproxy 1.8.10

2018-06-26 Thread William Lallemand
On Tue, Jun 26, 2018 at 02:04:21PM +0200, Thierry Fournier wrote: > >> William, The backport in 1.8 stable is trivial. > > > > William / Christopher, given that 1.8.10 is very recent and few people > > had the time to upgrade, I think it would make sense to issue 1.8.11 > > to limit the risks. I

Re: [Patch] Re: Segfault with haproxy 1.8.10

2018-06-26 Thread Thierry Fournier
> On 26 Jun 2018, at 13:56, Willy Tarreau wrote: > > Hi Thierry, > > On Tue, Jun 26, 2018 at 10:20:38AM +0200, thierry.fourn...@arpalert.org wrote: >> BR,Hi, >> >> I found the bug. The segfault is unavoidable, because is trigged if an >> entry doesn't exists in the stick-tables. At the

Re: [Patch] Re: Segfault with haproxy 1.8.10

2018-06-26 Thread Willy Tarreau
Hi Thierry, On Tue, Jun 26, 2018 at 10:20:38AM +0200, thierry.fourn...@arpalert.org wrote: > BR,Hi, > > I found the bug. The segfault is unavoidable, because is trigged if an > entry doesn't exists in the stick-tables. At the start, the stick table > is empty. > > It is a regression introduced

[Patch] Re: Segfault with haproxy 1.8.10

2018-06-26 Thread thierry . fournier
BR,Hi, I found the bug. The segfault is unavoidable, because is trigged if an entry doesn't exists in the stick-tables. At the start, the stick table is empty. It is a regression introduced in 1.8.10 by this patch: BUG/MEDIUM: stick-tables: Decrement ref_cnt in table_* converters commit