Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-11-03 Thread Willy Tarreau
On Fri, Nov 03, 2023 at 08:55:54AM +, Ruei-Bang Chen wrote: > Hi Willy, > > The simplification makes sense! I don't mind you changing it at all. I really > appreciate the feedback from you. Perfect, that's merged now :-) Thank you for doing this work! Willy

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-11-03 Thread Ruei-Bang Chen
] MINOR: sample: Add fetcher for getting all cookie names Hi Ruei-Bang, On Fri, Nov 03, 2023 at 04:58:36AM +, Ruei-Bang Chen wrote: > Hi Willy and the team, > > I just want to send a friendly reminder that I am still looking for feedback > for this patch. Thanks! > I tot

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-11-03 Thread Willy Tarreau
Hi Ruei-Bang, On Fri, Nov 03, 2023 at 04:58:36AM +, Ruei-Bang Chen wrote: > Hi Willy and the team, > > I just want to send a friendly reminder that I am still looking for feedback > for this patch. Thanks! > I totally understand that there might be other priorities coming up. When you >

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-11-02 Thread Ruei-Bang Chen
From: Ruei-Bang Chen Sent: Friday, October 27, 2023 2:16 PM To: Willy Tarreau Cc: haproxy@formilux.org Subject: Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names Hi Willy, Thanks for pointing that out. I have merged them into a single patch

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-10-27 Thread Ruei-Bang Chen
-Bang Chen Cc: haproxy@formilux.org Subject: Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names Hi Ruei-Bang, On Fri, Oct 27, 2023 at 01:44:30AM +, Ruei-Bang Chen wrote: > Hi Willy, > > Thanks for the feedback! > > I have attached the 2 patches (with one bei

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-10-26 Thread Willy Tarreau
Hi Ruei-Bang, On Fri, Oct 27, 2023 at 01:44:30AM +, Ruei-Bang Chen wrote: > Hi Willy, > > Thanks for the feedback! > > I have attached the 2 patches (with one being the same old patch and the > other having the diff since that older patch) to address the comments. > > Not sure if this is

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-10-26 Thread Ruei-Bang Chen
a single patch for everything. Thanks! Ruei-Bang From: Willy Tarreau Sent: Monday, October 23, 2023 2:57 AM To: Ruei-Bang Chen Cc: haproxy@formilux.org Subject: Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names Hi Ruei-Bang, On Sat, Oct 21, 2023

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-10-23 Thread Willy Tarreau
Hi Ruei-Bang, On Sat, Oct 21, 2023 at 12:46:18AM +, Ruei-Bang Chen wrote: > Hi team, > > As discussed in > https://www.mail-archive.com/haproxy@formilux.org/msg44161.html, I have > attached a patch for adding a new fetcher for getting all the cookie names > for request / response. > > I did

[PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-10-20 Thread Ruei-Bang Chen
Hi team, As discussed in https://www.mail-archive.com/haproxy@formilux.org/msg44161.html, I have attached a patch for adding a new fetcher for getting all the cookie names for request / response. I did check some relevant docs (like CONTRIBUTING, coding-style.txt etc.) for the guidelines