Re: I just broke opentracing :-(

2021-09-09 Thread Miroslav Zagorac
Hello Willy, On 09/09/2021 08:43 AM, Willy Tarreau wrote: Yes, that's where I found it but didn't know what its use was. A few points however: - sess.ot.uuid will be shared by all requests on the same session, which is probably not what you want (e.g. for requests coming in H2, the

Re: I just broke opentracing :-(

2021-09-09 Thread Willy Tarreau
Hi Miroslav, On Wed, Sep 08, 2021 at 08:02:35PM +0200, Miroslav Zagorac wrote: > On 09/08/2021 07:57 PM, Miroslav Zagorac wrote: > > On 09/08/2021 07:42 PM, Willy Tarreau wrote: > > > No rush on this one, I'll let you think about it, just let me know if we > > > need to temporarily disable it

Re: I just broke opentracing :-(

2021-09-08 Thread Miroslav Zagorac
On 09/08/2021 07:57 PM, Miroslav Zagorac wrote: On 09/08/2021 07:42 PM, Willy Tarreau wrote: No rush on this one, I'll let you think about it, just let me know if we need to temporarily disable it from the CI, or if you just want a day or two of checking before knowing if you can get a quick

Re: I just broke opentracing :-(

2021-09-08 Thread Miroslav Zagorac
On 09/08/2021 07:42 PM, Willy Tarreau wrote: No rush on this one, I'll let you think about it, just let me know if we need to temporarily disable it from the CI, or if you just want a day or two of checking before knowing if you can get a quick solution or if it will take more time. Thank you

Re: I just broke opentracing :-(

2021-09-08 Thread Willy Tarreau
On Wed, Sep 08, 2021 at 07:23:59PM +0200, Miroslav Zagorac wrote: > On 09/08/2021 06:46 PM, Willy Tarreau wrote: > > I have no doubt about this, what I mean is that once such needs are > > identified, as much as possible we should try to move these parts into > > the proper location (vars), or if

Re: I just broke opentracing :-(

2021-09-08 Thread Willy Tarreau
On Wed, Sep 08, 2021 at 06:30:15PM +0200, Miroslav Zagorac wrote: > there is a reason why i used some functions related to > reading/setting/searching variables. If I could use the original haproxy > functions, I wouldn't write these because duplicating the > code doesn't make sense. I have no

Re: I just broke opentracing :-(

2021-09-08 Thread Miroslav Zagorac
On 09/08/2021 04:41 PM, Willy Tarreau wrote: Hi Miroslav, I just discovered that the changes I've made to the totally broken variables API now broke opentracing because apparently it's using some of the variable code's internals for its own use:

I just broke opentracing :-(

2021-09-08 Thread Willy Tarreau
Hi Miroslav, I just discovered that the changes I've made to the totally broken variables API now broke opentracing because apparently it's using some of the variable code's internals for its own use: https://github.com/haproxy/haproxy/runs/3545475810 That's annoying because unbreaking the