Hi Alexander,
On Fri, Nov 10, 2023 at 08:44:31PM +, Stephan, Alexander wrote:
> > I don't see how this is possible:
> >
> >list_for_each_entry(srv_tlv, >pp_tlvs, list) {
> >if (srv_tlv == NULL)
> > break;
>
> > For srv_tlv to be NULL, it would
health checks,
right? If that's alright, I will send the corresponding patch.
Best,
Alexander
-----Original Message-
From: Willy Tarreau
Sent: Saturday, November 4, 2023 5:02 AM
To: Stephan, Alexander
Cc: haproxy@formilux.org
Subject: Re: [PATCH 2/4] MEDIUM: connection: Send out generically all
Alexander,
I now merged your patch with the SMP_VAL_ change, after verifying that
the reg-test is still OK. Thus 2.9-dev9 will contain it. Thanks!
Willy
On Fri, Nov 03, 2023 at 08:35:08PM +, Stephan, Alexander wrote:
> Hi Willy,
>
> Thanks for the review. No problem for calling me Stephan, I am totally used
> to that, my teachers did that for years.
Oh I was sure you were used to but anyway I don't like calling people
incorrectly.
> > Yeah
and it seems to work perfectly. The tests also still pass,
so looks good. I would like to provide a second patch for this next week, if
this okay.
Best,
Alexander
-----Original Message-----
From: Willy Tarreau
Sent: Friday, November 3, 2023 8:11 PM
To: Stephan, Alexander
Cc: haproxy@formilux
Hi Alexander,
(and BTW sorry for having called you Stephan twice in the last thread,
each time I have to make a mental effort due to how your first and last
names are presented in your e-mail address).
On Sat, Oct 28, 2023 at 07:32:20PM +, Stephan, Alexander wrote:
> I've just finished the
On Fri, Nov 03, 2023 at 05:15:03PM +, Stephan, Alexander wrote:
> Hi Willy,
>
> Sorry, my email client probably did something weird...
> I attached them now, should hopefully prevent any reformatting.
Thanks for the fast response. I'll check them keeping in mind your
last comments in your
: [PATCH 2/4] MEDIUM: connection: Send out generically allocated
proxy-v2-options
On Fri, Nov 03, 2023 at 05:14:33PM +0100, Willy Tarreau wrote:
> Hi Stephan,
>
> On Fri, Nov 03, 2023 at 01:54:26PM +, Stephan, Alexander wrote:
> > Hi Willy,
> >
> > Did you
On Fri, Nov 03, 2023 at 05:14:33PM +0100, Willy Tarreau wrote:
> Hi Stephan,
>
> On Fri, Nov 03, 2023 at 01:54:26PM +, Stephan, Alexander wrote:
> > Hi Willy,
> >
> > Did you receive the other two mails with the updated patches? I couldn't
> > find
> > it the reply to first page in the
Hi Stephan,
On Fri, Nov 03, 2023 at 01:54:26PM +, Stephan, Alexander wrote:
> Hi Willy,
>
> Did you receive the other two mails with the updated patches? I couldn't find
> it the reply to first page in the archive although I CCed the list. That's
> why I wanted to double-check, not to run in
Sent: Friday, October 27, 2023 4:22 PM
To: Stephan, Alexander
Cc: haproxy@formilux.org
Subject: Re: [PATCH 2/4] MEDIUM: connection: Send out generically allocated
proxy-v2-options
Hi Alexander,
On Fri, Oct 27, 2023 at 02:12:10PM +, Stephan, Alexander wrote:
> > BTW, please
reate empty TLV as no value was specified */
+ ret += make_tlv([ret], (buf_len - ret),
srv_tlv->type, 0, NULL);
+ }
+ }
+ }
+
+ /* Handle predefined TLVs as usual */
if (srv->pp_opts & SRV_PP_V2_CRC32C) {
Hi Alexander,
On Fri, Oct 27, 2023 at 02:12:10PM +, Stephan, Alexander wrote:
> > BTW, please check if this works in default-server directives.
>
> struct srv_pp_tlv_list {
> struct list list;
> struct list fmt;
> unsigned char type;
> };
>
> To allow for use with
ve?
Disabling the default-server support could be another solution. I am very
interested in your opinion on this.
Best,
Alexander
-Original Message-
From: Willy Tarreau
Sent: Monday, October 23, 2023 2:33 PM
To: Stephan, Alexander
Cc: haproxy@formilux.org
Subject: Re: [PATCH 2/4] MEDI
Hi Alexander,
On Mon, Oct 23, 2023 at 12:07:39PM +, Stephan, Alexander wrote:
> We can ignore the last two commits for now (LOW: connection: Add TLV update
> function and MEDIUM: tcp-act: Add new set-tlv TCP action for PPv2 TLVs).
> Based on the first two commits, I created a diff that would
t;slowstart", srv_parse_slowstart, 1, 1, 1 },
/* Set the warm-up timer for a previously failed server */
+ { "source", srv_parse_source, -1, 1, 1 },
/* Set the source address to be used to connect to the server */
+
Hi Alexander,
I'm starting from the doc as it eases the discussion.
On Thu, Oct 05, 2023 at 11:05:50AM +, Stephan, Alexander wrote:
> --- a/doc/configuration.txt
> +++ b/doc/configuration.txt
> @@ -16671,6 +16671,26 @@ proxy-v2-options [,]*
> generated unique ID is also used
From 84608ed754c1a92e85e03036e8b0cd0949721ffb Mon Sep 17 00:00:00 2001
From: Alexander Stephan
mailto:alexander.step...@sap.com>>
Date: Fri, 15 Sep 2023 12:42:36 +0200
Subject: [PATCH 2/4] MEDIUM: connection: Send out generically allocated
proxy-v2-options
This commit removes the previous
From 84608ed754c1a92e85e03036e8b0cd0949721ffb Mon Sep 17 00:00:00 2001
From: Alexander Stephan
Date: Fri, 15 Sep 2023 12:42:36 +0200
Subject: [PATCH 2/4] MEDIUM: connection: Send out generically allocated
proxy-v2-options
This commit removes the previous limitations on the existing, fixed PPv2
19 matches
Mail list logo
