Re: [PATCH] BUG/MINOR: Fix Lua's `get_stats` function

2023-06-02 Thread Willy Tarreau
On Fri, Jun 02, 2023 at 10:11:36AM +0200, Tim Düsterhus wrote: > Hi > > On 6/2/23 08:42, Willy Tarreau wrote: > > Thank you for this. I've added a comment in the file about it, and a > > regtest to detect when this happens, since (null) appears in the header > > line of the "show stat" output in

Re: [PATCH] BUG/MINOR: Fix Lua's `get_stats` function

2023-06-02 Thread Tim Düsterhus
Hi On 6/2/23 08:42, Willy Tarreau wrote: Thank you for this. I've added a comment in the file about it, and a regtest to detect when this happens, since (null) appears in the header line of the "show stat" output in this case. Nice, thank you. I thought about including a test for that, but

Re: [PATCH] BUG/MINOR: Fix Lua's `get_stats` function

2023-06-02 Thread Willy Tarreau
Hi Tim, On Thu, Jun 01, 2023 at 06:58:08PM +0200, Tim Duesterhus wrote: > Lua's `get_stats` function stopped working in > 4cfb0019e65bce79953164eddf54c1bbb61add62, due to the addition a new field > ST_F_PROTO without a corresponding entry in `stat_fields`. Thank you for this. I've added a