Re: [PATCH] MEDIUM: cli: Add multi-line mode support

On Thu, Apr 26, 2018 at 01:48:27PM +0200, Aurélien Nephtali wrote: > Willy, > > On Thu, Apr 26, 2018 at 12:32 PM, Willy Tarreau wrote: > > Thanks for this. All of this looks OK to me. Please just let me know if > > you want me to merge them now or if you expect other adjustments. >

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Willy, On Thu, Apr 26, 2018 at 12:32 PM, Willy Tarreau wrote: > Thanks for this. All of this looks OK to me. Please just let me know if > you want me to merge them now or if you expect other adjustments. I think it's OK for me. Thanks ! -- Aurélien Nephtali

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hi Aurélien, On Thu, Apr 26, 2018 at 09:52:59AM +0200, Aurélien Nephtali wrote: > Hello Willy, > > Sorry for the delay. no problem. > Here are the three amended patches. > > Changes: > - update the documentation > - add some comments regarding the detection of the payload pattern >

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hello Willy, Sorry for the delay. Here are the three amended patches. Changes: - update the documentation - add some comments regarding the detection of the payload pattern and the input that is zero terminated - use appctx->chunk to gather data without using the trash -

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hello Willy, On Fri, Apr 20, 2018 at 05:12:22PM +0200, Willy Tarreau wrote: > Hi Aurélien, > > It seems to me that some places in the parser look for "<<" anywhere on the > line (mainly the strstr() which even skips trailing spaces/tabs), and some > parts of the logic only expect it at the end. >

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hi Aurélien, On Thu, Apr 19, 2018 at 06:16:37PM +0200, Aurélien Nephtali wrote: > I guess I was sent off-track by the will to make something very flexible > (at least in my mind) despite your multiple good examples, sorry about > that. No problem. That's exactly what design discussions are made

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hello Willy, On Thu, Apr 19, 2018 at 8:51 AM, Willy Tarreau wrote: > Hoping this helps, Yes, I hope it does too. I guess I was sent off-track by the will to make something very flexible (at least in my mind) despite your multiple good examples, sorry about that. Anyway, here are

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hi Aurélien, On Wed, Apr 18, 2018 at 09:36:14AM +0200, Aurélien Nephtali wrote: > > My worries come from your example above which splits the "set server" > > command and some of you comments which seem to imply that the arguments > > are looked up in the payload part. > > Well, they are looked

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Willy, On Wed, Apr 18, 2018 at 08:36:05AM +0200, Willy Tarreau wrote: > > The problem is: the main parser (cli_parse_request()) does not have any > > idea of what is an argument and how many there should be so it can't > > tell if the command syntax is valid or not before passing it to the > >

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

On Wed, Apr 18, 2018 at 08:09:57AM +0200, Aurélien Nephtali wrote: > Hello Willy, > > On Wed, Apr 18, 2018 at 07:38:24AM +0200, Willy Tarreau wrote: > > Hi Aurélien, > > > > On Tue, Apr 17, 2018 at 09:06:35PM +0200, Aurélien Nephtali wrote: > > > Example: > > > If this command is entered: > > >

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hello Willy, On Wed, Apr 18, 2018 at 07:38:24AM +0200, Willy Tarreau wrote: > Hi Aurélien, > > On Tue, Apr 17, 2018 at 09:06:35PM +0200, Aurélien Nephtali wrote: > > Example: > > If this command is entered: > > set server bk/fe << > > state ready > > > > Three arguments and a payload

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hi Aurélien, On Tue, Apr 17, 2018 at 09:06:35PM +0200, Aurélien Nephtali wrote: > Example: > If this command is entered: > set server bk/fe << > state ready > > Three arguments and a payload will be tagged. This command requires (in > some cases) seven arguments (including the keywords)

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hello, Here is another attempt to add multi-lines support to the CLI. To enter a multi-lines command, a special pattern (<<) has to be used at the end of the first line. Once in this mode, everything else is gathered as it and the command is considered terminated on the reception of an empty

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

On Fri, Apr 06, 2018 at 03:59:59PM +0200, Aurélien Nephtali wrote: > I tried to be the less intrusive as > possible into the CLI parser so I tried to reuse what was already > done. > Maybe that's not the best approach but with all the legacy behind I > REALLY didn't want to break something, even

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hello Willy, On Fri, Apr 6, 2018 at 12:02 PM, Willy Tarreau wrote: > > Hi Aurélien, > > I finally found some time to review your patch, really sorry for the > long delay, but bug fixing passes first when they are sensitive :-/ No problem. Adding features over fixing bugs would be

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hi Aurélien, I finally found some time to review your patch, really sorry for the long delay, but bug fixing passes first when they are sensitive :-/ On Sat, Mar 24, 2018 at 11:16:03PM +0100, Aurélien Nephtali wrote: > From 53356f83dab6483512d2db1fae87abd24beca4c0 Mon Sep 17 00:00:00 2001 >

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

Hello, On Fri, Mar 23, 2018 at 09:43:50PM +0100, Aurélien Nephtali wrote: > Hello, > > This patch adds multi-line mode support to the CLI. [...] Please consider reviewing the attached patch instead as it fixes a compiler warning. -- Aurélien. >From 53356f83dab6483512d2db1fae87abd24beca4c0