Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-20 Thread Willy Tarreau
On Mon, Mar 20, 2017 at 11:55:46AM +0100, Emmanuel Hocdet wrote: > (...) > Indeed, new patchs: Both applied, many thanks Manu! Willy

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-20 Thread Emmanuel Hocdet
> Le 20 mars 2017 à 07:02, Willy Tarreau a écrit : > > Hi Manu, > > On Thu, Mar 16, 2017 at 03:35:42PM +0100, Emmanuel Hocdet wrote: >> Hi Piotr, >> >>> Le 16 mars 2017 à 09:48, Piotr Kubaj a écrit : >>> >>> Thanks for the patch! >>> >>> Looks good to me,

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-20 Thread Willy Tarreau
Hi Manu, On Thu, Mar 16, 2017 at 03:35:42PM +0100, Emmanuel Hocdet wrote: > Hi Piotr, > > > Le 16 mars 2017 à 09:48, Piotr Kubaj a écrit : > > > > Thanks for the patch! > > > > Looks good to me, works fine with Haproxy and LibreSSL 2.5.1. > > > great > > Willy, can you

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-16 Thread Emmanuel Hocdet
Hi Piotr,Le 16 mars 2017 à 09:48, Piotr Kubaj a écrit :Thanks for the patch!Looks good to me, works fine with Haproxy and LibreSSL 2.5.1.greatWilly, can you merge this two patchs? It fix boringssl and libressl build issues.Piotr, this patchs should be minimise your patch for

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-15 Thread Emmanuel Hocdet
> Le 14 mars 2017 à 16:28, Emmanuel Hocdet a écrit : > > Hi Piotr > >> Le 14 mars 2017 à 16:04, Piotr Kubaj a écrit : >> >> And it seems like the previously attached patches do compile, but the >> warning is there again so now I'm finally including

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-14 Thread Emmanuel Hocdet
Hi Piotr > Le 14 mars 2017 à 16:04, Piotr Kubaj a écrit : > > And it seems like the previously attached patches do compile, but the warning > is there again so now I'm finally including patches that make Haproxy both > compile and not throw additional warnings. > first

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-14 Thread Piotr Kubaj
And it seems like the previously attached patches do compile, but the warning is there again so now I'm finally including patches that make Haproxy both compile and not throw additional warnings. -- __ / What good is having someone who can \ | walk on

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-14 Thread Piotr Kubaj
There seems to be some error when doing a clean compilation, so I'm sending corrected patches. -- / Any stone in your boot always migrates \ | against the pressure gradient to | | exactly the point of most pressure.| |

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-14 Thread Piotr Kubaj
I have reworked the patches, so that they don't cause any warning to appear. -- _ / In real love you want the other \ | person's good. In romantic love you | | want the other person. | | | \ -- Margaret

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-08 Thread Willy Tarreau
Hi Piotr, On Wed, Mar 08, 2017 at 07:58:11PM +0100, Piotr Kubaj wrote: > Could you give your opinion on my patches and commit them if they're fine? Sorry for the delay but I'm really burried under e-mails and work-related stuff at the moment. And since your patches will require some manual

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-03-08 Thread Piotr Kubaj
Could you give your opinion on my patches and commit them if they're fine? On 17-02-15 15:46:23, Piotr Kubaj wrote: > Thanks for the feedback. Could you keep me in CC? I'm not subscribed to the > list. > > > I don't understand much, your e-mail talks about openssl and you're changing > > a line

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-02-15 Thread Piotr Kubaj
Thanks for the feedback. Could you keep me in CC? I'm not subscribed to the list. > I don't understand much, your e-mail talks about openssl and you're changing > a line afecting boringssl. You need to provide a bit of description about > what your patch does and tries to solve, that we'll use

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-02-12 Thread Willy Tarreau
On Fri, Feb 10, 2017 at 04:21:06PM +0100, Piotr Kubaj wrote: > Please try the corrected patches. Before Haproxy was kind of unstable. Now it > seems to work fine. I also changed tests for defined LIBRESSL_VERSION_NUMBER > to testing LibreSSL version to keep the older versions working. (...) > >

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-02-10 Thread Dave Cottlehuber
On Fri, 10 Feb 2017, at 16:21, Piotr Kubaj wrote: > Please try the corrected patches. Before Haproxy was kind of unstable. > Now it seems to work fine. I also changed tests for defined > LIBRESSL_VERSION_NUMBER to testing LibreSSL version to keep the older > versions working. > > On 17-02-10

Re: [PATCHES] Add support for LibreSSL 2.5.1

2017-02-10 Thread Piotr Kubaj
Please try the corrected patches. Before Haproxy was kind of unstable. Now it seems to work fine. I also changed tests for defined LIBRESSL_VERSION_NUMBER to testing LibreSSL version to keep the older versions working. On 17-02-10 13:48:20, Piotr Kubaj wrote: > I'm attaching two patches: > a)