Yep, your suggestion reads better to me.
------ Original Message ------
From: "Willy Tarreau" <w...@1wt.eu>
To: "Nick Ramirez" <nrami...@haproxy.com>
Cc: haproxy@formilux.org
Sent: 12/15/2018 10:30:58 AM
Subject: Re: agent-check requires newline in response?
Hi Nick,
On Fri, Dec 14, 2018 at 05:43:49PM +0000, Nick Ramirez wrote:
In the documentation for agent-check
(https://cbonte.github.io/haproxy-dconv/1.9/configuration.html#agent-check)
it says that the string returned by the agent may be optionally terminated
by '\r' or '\n'. However, in my tests, it was mandatory to end the response
with this. Should the word "optionally" be removed from the docs?
At least one of them is required. Since it's TCP we need to find the end
of the message and to know it was not truncated. I agree that the wording
is confusing, it says :
"The string is made of a series of words delimited by spaces, tabs or
commas in any order, optionally terminated by '\r' and/or '\n'"
Which was meant to say that one of them was optional. Maybe we should
say this instead :
"The string is made of a series of words delimited by spaces, tabs or
commas in any order, terminated by the first '\r' or '\n' met"
(this basically is what the comments in the code say BTW). What do you
think ?
Thanks,
Willy
