Re: [PATCH v2] BUG/MINOR: mworker: Do not attempt to close(2) fd -1

On Sun, Nov 25, 2018 at 08:03:39PM +0100, Tim Duesterhus wrote: > Valgrind reports: > > ==3389== Warning: invalid file descriptor -1 in syscall close() > > Check for >= 0 before closing. > > This bug was introduced in commit ce83b4a5dd48c000dec68f9d551945d21e9ac7ac > and is specific to 1.9. No

Re: [PATCH] BUILD/MINOR: ssl: fix build with non-alpn/non-npn libssl

On Sun, Nov 25, 2018 at 01:21:27PM +0100, Lukas Tribus wrote: > In commit c7566001 ("MINOR: server: Add "alpn" and "npn" keywords") and > commit 201b9f4e ("MAJOR: connections: Defer mux creation for outgoing > connection if alpn is set"), the build was broken on older OpenSSL > releases. > > Move

[PATCH] CLEANUP: Fix a typo in the listener subsystem

Fixes a typo in the code comment of the listener subsystem. --- include/types/listener.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/types/listener.h b/include/types/listener.h index eac2037f..18d5092a 100644 --- a/include/types/listener.h +++

[PATCH] CLEANUP: Fix typos in the file descriptor subsystem

Fixes 2 typos in the code comment of the file descriptor subsystem. --- include/types/fd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/types/fd.h b/include/types/fd.h index 5947bafc..3ff4f656 100644 --- a/include/types/fd.h +++ b/include/types/fd.h @@ -80,8

[PATCH] CLEANUP: Fix a typo in the checks header file

Fixes a typo in the code comments of the checks header file. --- include/types/checks.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/types/checks.h b/include/types/checks.h index e0a4bd64..364eee88 100644 --- a/include/types/checks.h +++ b/include/types/checks.h @@

[PATCH] CLEANUP: Fix a typo in the protocol header file

Fixes a typo in the code comments of the header file holding the general protocol primitives. --- include/proto/protocol.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/proto/protocol.h b/include/proto/protocol.h index 857f9e69..7bbebb8e 100644 ---

[PATCH] MINOR: Fix a typo when displaying the list of known protocols

Fixes a typo in the connection subsystem when displaying the list of known protocols. --- include/proto/connection.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/proto/connection.h b/include/proto/connection.h index 11d4aa47..68a40252 100644 ---

[PATCH] CLEANUP: Fix a typo in the connection subsystem

Fixes a typo in the code comments of the connection subsystem. --- include/types/connection.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/types/connection.h b/include/types/connection.h index dbf985be..ff155fde 100644 --- a/include/types/connection.h +++

[PATCH] CLEANUP: Fix a typo in the base64 subsystem

Fixes a typo in the code comments of the base64 subsystem. --- src/base64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/base64.c b/src/base64.c index 594ab456..f7961c53 100644 --- a/src/base64.c +++ b/src/base64.c @@ -99,7 +99,7 @@ int base64dec(const char *in, size_t

[PATCH] CLEANUP: Fix typo in the 51d subsystem

Fixes a typo in the code comments of the 51d subsystem. --- src/51d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/51d.c b/src/51d.c index e092c5ba..f224f1de 100644 --- a/src/51d.c +++ b/src/51d.c @@ -378,7 +378,7 @@ static int _51d_fetch(const struct arg *args, struct

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

Fixes typos in the code comments of the proto_tcp subsystem. --- src/proto_tcp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/proto_tcp.c b/src/proto_tcp.c index c7951c55..6f2683c5 100644 --- a/src/proto_tcp.c +++ b/src/proto_tcp.c @@ -1534,11 +1534,11 @@

[PATCH] CLEANUP: Fix typos in the cli subsystem

Fixes typos in the code comments of the cli subsystem. --- src/cli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cli.c b/src/cli.c index 3f438621..a22b5d5f 100644 --- a/src/cli.c +++ b/src/cli.c @@ -549,7 +549,7 @@ static void cli_io_handler(struct appctx *appctx)

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

On Sun, Nov 25, 2018 at 12:47 PM Valentin Vidic wrote: > Should this sentence read: > > Returns some tcp_info data if it's available. Indeed, good catch, thanks, I will update the patch. Thanks, Joseph

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

On Sun, Nov 25, 2018 at 11:30:06AM -0800, Joseph Herlant wrote: > -/* Returns some tcp_info data is its avalaible. "dir" must be set to 0 if > - * the client connection is require, otherwise it is set to 1. "val" > represents > +/* Returns some tcp_info data is its available. "dir" must be set to

[PATCH] CLEANUP: Fix typo in the fwrr subsystem

Fixes a typo in the code comment of the fwrr subsystem. --- src/lb_fwrr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lb_fwrr.c b/src/lb_fwrr.c index 73a140b8..35322799 100644 --- a/src/lb_fwrr.c +++ b/src/lb_fwrr.c @@ -586,7 +586,7 @@ struct server

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

Will do, thanks! On Sun, Nov 25, 2018 at 12:10 PM William Lallemand wrote: > > On Sun, Nov 25, 2018 at 11:30:06AM -0800, Joseph Herlant wrote: > > Sorry, I forgot the attachement on this one. > > Hi Joseph, > > I recommand you to use git send-email to avoid that, it can send a whole patch >

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

On Sun, Nov 25, 2018 at 11:30:06AM -0800, Joseph Herlant wrote: > Sorry, I forgot the attachement on this one. Hi Joseph, I recommand you to use git send-email to avoid that, it can send a whole patch series in a unique mail thread, and it's easier for us to apply a patch which is not an

[PATCH] CLEANUP: Fix typos in the map management functions

Hi, The attached patch fixes typos in the code comments of the MAP management functions. Thanks, Joseph From cc9890a5ae4201ececd8a6c5f4185e6f9e22340f Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 11:48:18 -0800 Subject: [PATCH] CLEANUP: Fix typos in the map management

[PATCH] CLEANUP: Fix typos in the socket pair protocol subsystem

Hi, The attached patch fixes typos in the code comments of the socket pair protocol subsystem. Thanks, Joseph From 0870a10c8fb766eb2b9c44a1435bdca68a029f6d Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 11:43:27 -0800 Subject: [PATCH] CLEANUP: Fix typos in the socket pair

[PATCH] CLEANUP: Fix typos in the shctx subsystem

Hi, Please find attach a patch that fixes typos in the code comments of the shctx subsystem. Thanks, Joseph From 29bccb569387a5e05cbb055dc9f66be331105d1f Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 11:31:31 -0800 Subject: [PATCH] CLEANUP: Fix typos in the shctx

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

Sorry, I forgot the attachement on this one. On Sun, Nov 25, 2018 at 11:08 AM Joseph Herlant wrote: > > Hi, > > The attached patch fixes typos in the code comments of the proto_tcp > subsystem. > > Thanks, > Joseph From 126a530e4105cc18d2f6b9a2a4b005e2ae835d6c Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] CLEANUP: Fix a typo in the queue subsystem

Sorry, the attachement was missing. On Sun, Nov 25, 2018 at 11:28 AM Joseph Herlant wrote: > > Hi, > > The attached patch fixes a typo in the code comments of the queue subsystem. > > Thanks, > Joseph From 0dbb27536b54dd5b8646c532dfebb85d88d62c5e Mon Sep 17 00:00:00 2001 From: Joseph Herlant

[PATCH] CLEANUP: Fix a typo in the queue subsystem

Hi, The attached patch fixes a typo in the code comments of the queue subsystem. Thanks, Joseph

[PATCH] CLEANUP: Fix a typo in the session subsystem

Hi, The attached patch fixes a typo in the code comments of the session subsystem. Thanks, Joseph From 84acadfc18b939778ea4aaebba699431fe2592ed Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 11:22:10 -0800 Subject: [PATCH] CLEANUP: Fix a typo in the session subsystem

[PATCH] CLEANUP: Fix a typo in the signal subsystem

Hi, This patch fixes a typo in the code comments of the signal subsystem. Thanks, Joseph From 6fd7551282b94273c14d7d4a4cff5df662800fd5 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 11:19:40 -0800 Subject: [PATCH] CLEANUP: Fix a typo in the signal subsystem Fixes a typo

[PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

Hi, The attached patch fixes typos in the code comments of the proto_tcp subsystem. Thanks, Joseph

Re: BUG: Warning: invalid file descriptor -1 in syscall close()

William, Am 25.11.18 um 19:33 schrieb William Lallemand: > We can safely add an if > -1 instead of an assert there. So you can edit your > patch if you want :-) There should be an updated patch in this thread now. > By the way, the right option is '-S' and not '-Sa', I know it's not yet on the

[PATCH v2] BUG/MINOR: mworker: Do not attempt to close(2) fd -1

Valgrind reports: ==3389== Warning: invalid file descriptor -1 in syscall close() Check for >= 0 before closing. This bug was introduced in commit ce83b4a5dd48c000dec68f9d551945d21e9ac7ac and is specific to 1.9. No backport needed. --- src/haproxy.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] CLEANUP: Fix a typo in the proto_htx subsystem

Hi, The attached patch fixes a typo in the code comments of the proto_htx subsystem. Thanks, Joseph From 7b57a0b375496c421c041cc48c6c35ef6117f57f Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 11:00:25 -0800 Subject: [PATCH] CLEANUP: Fix a typo in the proto_htx subsystem

[PATCH] CLEANUP: Fix a typo in the mini-clist header

Hi, The attached patch fixes a typo in the code comments of the mini-clist header. Thanks, Joseph From e291a41e4d50def29a452308afbebbec40941207 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 10:57:13 -0800 Subject: [PATCH] CLEANUP: Fix a typo in the mini-clist header

[PATCH] CLEANUP: Fix typos in the h2 subsystem

Hi, The attached patch fixes typos in the code comments of the h2 subsystem. Thanks, Joseph From 8a8d518185c4acade2274ece034ef89611c39ee2 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 10:54:45 -0800 Subject: [PATCH] CLEANUP: Fix typos in the h2 subsystem Fixes typos in

[PATCH] CLEANUP: Fix typos in the h1 subsystem

Hi, The attached patch fixes typos in the code comments of the h1 subsystem. Thanks, Joseph From b17a612d70b05d8f85e6f41259f4777d6ce9afae Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 10:52:20 -0800 Subject: [PATCH] CLEANUP: Fix typos in the h1 subsystem Fixes typos in

[PATCH] CLEANUP: Fix typo in the chunk headers file

Hi, The attached patch fixes a typo detected in the chunk.h header file's code comments. Thanks, Joseph From c52753e692a2e7b2d714244e58adac66d046804d Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 10:49:51 -0800 Subject: [PATCH] CLEANUP: Fix typo in the chunk headers file

[PATCH] CLEANUP: fix typos in the htx subsystem

Hi, Sorry I haven't been able to finish to send the patches, I've been sick lately. Hopefully I'll be able to finish to send those today and be done with the spam. The attached patch fixes typos in the code comments of the htx subsystem. Thanks, Joseph From

Re: BUG: Warning: invalid file descriptor -1 in syscall close()

On Sun, Nov 25, 2018 at 06:30:19PM +0100, Tim Duesterhus wrote: > Valgrind reports an invalid close of file descriptor -1. After this > patch haproxy that is started with: > > ./haproxy -d -Sa /scratch/haproxy/cli.sock -Ws -f ./haproxy.cfg > > aborts in the child process to outline the place

BUG: Warning: invalid file descriptor -1 in syscall close()

Valgrind reports an invalid close of file descriptor -1. After this patch haproxy that is started with: ./haproxy -d -Sa /scratch/haproxy/cli.sock -Ws -f ./haproxy.cfg aborts in the child process to outline the place where the bug needs to be fixed. Best regards --- src/haproxy.c | 2 ++ 1

[PATCH] REGTEST/MINOR: script: add run-regtests.sh script

Hi Frederic, Willy, Added the varnishtest script we have been discussing as a .patch this time. I put the script in the /reg-tests/ folder. Maybe it should have been besides the Makefile in the / root ? Also i put a bit of comments into the commit. I hope it is okay like this? If not, feel

[PATCH] BUILD/MINOR: ssl: fix build with non-alpn/non-npn libssl

In commit c7566001 ("MINOR: server: Add "alpn" and "npn" keywords") and commit 201b9f4e ("MAJOR: connections: Defer mux creation for outgoing connection if alpn is set"), the build was broken on older OpenSSL releases. Move the #ifdef's around so that we build again with older OpenSSL releases