Re: [PATCH] BUILD: makefile: Update feature flags for FreeBSD

2020-09-27 Thread Brad Smith 

Willy?

They've been shipping with these enabled with their 1.7 - 2.3 ports / 
packages.


MAKE_ARGS=    TARGET=freebsd DEFINE=-DFREEBSD_PORTS USE_GETADDRINFO=1 \
    USE_ZLIB=1 USE_CPU_AFFINITY=1 USE_ACCEPT4=1 \
    CC="${CC}" DEBUG_CFLAGS="" CPU_CFLAGS="${CFLAGS}"

On 9/15/2020 3:10 AM, Brad Smith wrote:

This updates the feature flags for FreeBSD.

FreeBSD 10 adds support for accept4().

Enable getaddrinfo().

 From the FreeBSD port / package.



diff --git a/Makefile b/Makefile
index 934ca1666..e69870595 100644
--- a/Makefile
+++ b/Makefile
@@ -363,11 +363,11 @@ ifeq ($(TARGET),solaris)
TARGET_LDFLAGS = -lnsl -lsocket
  endif
  
-# FreeBSD 5 and above

+# FreeBSD 10 and above
  ifeq ($(TARGET),freebsd)
set_target_defaults = $(call default_opts, \
  USE_POLL USE_TPROXY USE_LIBCRYPT USE_THREAD USE_CPU_AFFINITY USE_KQUEUE   
\
-USE_CLOSEFROM)
+USE_ACCEPT4 USE_CLOSEFROM USE_GETADDRINFO)
  endif
  
  # Mac OS/X

Re: [PATCH 1/2] DOC: agent-check: fix typo in "fail" word expected reply

2020-09-27 Thread Willy Tarreau 
On Sat, Sep 26, 2020 at 01:35:51PM +0200, William Dauchy wrote:
> `tcpcheck_agent_expect_reply` expects "fail" not "failed"
(...)

both patches applied, thank you William.

willy

Re: [PATCH] BUILD: makefile: Update feature flags for OpenBSD

2020-09-27 Thread Willy Tarreau 
On Sat, Sep 26, 2020 at 11:05:25PM -0400, Brad Smith wrote:
> Update the OpenBSD target features being enabled.
> 
> I updated the list of features after noticing
> "BUILD: makefile: disable threads by default on OpenBSD".
> 
> The Makefile utilizing gcc(1) by default resulted in utilizing
> our legacy and obsolete compiler (GCC 4.2.1) instead of the
> proper system compiler (Clang), which does support TLS. With
> "BUILD: makefile: change default value of CC from gcc to cc"
> that is resolved.

Oh, great! Now applied, thank you!
Willy