Re: Hello HAProxy Team! I have a question about one of your posts...

2021-09-12 Thread Vanessa Diwa
Hi HAProxy Team, I reached out a few days back regarding your remarkable post. Just checking in to see if you have received my previous email regarding your article https://www.haproxy.com/blog/power-your-consul-service-mesh-with-haproxy/ since I haven't received any feedback. I would love to

Re: [ANNOUNCE] haproxy-2.5-dev7

2021-09-12 Thread Willy Tarreau
Hi Dmitry, On Sun, Sep 12, 2021 at 05:54:33PM +0300, Dmitry Sivachenko wrote: > there is a new warning in -dev branch (on FreeBSD): > > admin/halog/fgets2.c:38:30: warning: '__GLIBC__' is not defined, evaluates to > 0 [-Wundef] > #if defined(__x86_64__) && (__GLIBC__ > 2 || (__GLIBC__ == 2 &&

Re: [ANNOUNCE] haproxy-2.5-dev7

2021-09-12 Thread Dmitry Sivachenko
> On 12 Sep 2021, at 13:06, Willy Tarreau wrote: > > Hi, > > HAProxy 2.5-dev7 was released on 2021/09/12. It added 39 new commits > after version 2.5-dev6. Hello, there is a new warning in -dev branch (on FreeBSD): admin/halog/fgets2.c:38:30: warning: '__GLIBC__' is not defined,

Re: [ANNOUNCE] haproxy-2.5-dev7

2021-09-12 Thread Tim Düsterhus
Willy, On 9/12/21 12:06 PM, Willy Tarreau wrote: Tim Duesterhus (3): CLEANUP: Add haproxy/xxhash.h to avoid modifying import/xxhash.h CLEANUP: Move XXH3 macro from haproxy/compat.h to haproxy/xxhash.h BUG/MEDIUM lua: Add missing call to RESET_SAFE_LJMP in hlua_filter_new()

[PATCH] Huge number of cleanup patches

2021-09-12 Thread Tim Düsterhus
Willy, please find 42 patches attached. Sending as attachments to not completely bomb the list. I'll leave it up to you whether you want to squash patches 0001 until 0041. 0042 is sufficiently different to warrant a dedicated commit. Best regards Tim Düsterhus >From

[ANNOUNCE] haproxy-2.5-dev7

2021-09-12 Thread Willy Tarreau
Hi, HAProxy 2.5-dev7 was released on 2021/09/12. It added 39 new commits after version 2.5-dev6. This version is essentially released to flush the pipe of pending fixes for 2.5-dev. It contains the fix for CVE-2021-40346, plus a few other ones related to option abortonclose. The infamous global

Re: [PATCH 2/4] BUG/MINOR: opentracing: enable the use of http headers without a set value

2021-09-12 Thread Miroslav Zagorac
Hello Willy, On 09/12/2021 08:19 AM, Willy Tarreau wrote: Bah, I discovered that one after merging the first series :-/ I've applied it on top as a cleanup with your description above as the commit message since it's really what it's about. It is no problem. I apologize for the slight

Re: [PATCH] BUILD: opentracing: excluded use of haproxy variables for, OpenTracing context

2021-09-12 Thread Miroslav Zagorac
Hello Willy, On 09/12/2021 08:11 AM, Willy Tarreau wrote: thanks for working on fixing this, it's now merged. I've added a tiny change to make sure that text_map is always initialized in flt_ot_scope_run() because that made clang rightfully upset, re-enabled OT in the CI since it's now OK.

Re: [PATCH] BUG/???: lua: Add missing call to RESET_SAFE_LJMP in hlua_filter_new()

2021-09-12 Thread Willy Tarreau
On Sat, Sep 11, 2021 at 11:17:25PM +0200, Tim Duesterhus wrote: > In one case before exiting leaving the function the panic handler was not > reset. > > Introduced in 69c581a09271e91d306e7b9080502a36abdc415e, which is 2.5+. > No backport required. Good catch, applied as medium since it seems

Re: [PATCH 2/4] BUG/MINOR: opentracing: enable the use of http headers without a set value

2021-09-12 Thread Willy Tarreau
On Sat, Sep 11, 2021 at 12:27:30AM +0200, Miroslav Zagorac wrote: > On 09/11/2021 12:05 AM, Miroslav Zagorac wrote: > > Hello all, > > > > the second patch from the last series of patches has been redesigned > > here, the ist() function is used to set an empty string instead of > > working

Re: [PATCH] BUILD: opentracing: excluded use of haproxy variables for, OpenTracing context

2021-09-12 Thread Willy Tarreau
Hi guys, thanks for working on fixing this, it's now merged. I've added a tiny change to make sure that text_map is always initialized in flt_ot_scope_run() because that made clang rightfully upset, re-enabled OT in the CI since it's now OK. Cheers, Willy