Re: admin socket 1.4.x crash report

2011-03-03 Thread Willy Tarreau
Hi Guys, On Thu, Mar 03, 2011 at 08:09:57PM +0100, Cyril Bonté wrote: > Hi Bryan, > > Le jeudi 3 mars 2011 19:05:38, Bryan Talbot a écrit : > > I found a way that causes the 1.4.10 (and probably 1.4.11) releases to > > crash with a segfault. The message in /var/log/messages is > > > > Mar 3 12

[BUG] stats: admin web interface must check the proxy state

2011-03-03 Thread Cyril Bonté
Similar to the stats socket bug, we must check that the proxy is not disabled before trying to enable/disable a server. Even if a disabled proxy is not displayed, someone can inject a faulty proxy name in the POST parameters. So, we must ensure that no disabled proxy can be used. --- src/proto_ht

[BUG] stats: admin commands must check the proxy state

2011-03-03 Thread Cyril Bonté
As reported by Bryan Talbot, enabling and disabling a server in a disabled proxy causes a segfault. Changing the weight can also cause a similar segfault. --- src/dumpstats.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/src/dumpstats.c b/src/dumpstats

Re: admin socket 1.4.x crash report

2011-03-03 Thread Cyril Bonté
Hi Bryan, Le jeudi 3 mars 2011 19:05:38, Bryan Talbot a écrit : > I found a way that causes the 1.4.10 (and probably 1.4.11) releases to > crash with a segfault. The message in /var/log/messages is > > Mar 3 12:44:34 host kernel: haproxy[16392]: segfault at > rip 00

admin socket 1.4.x crash report

2011-03-03 Thread Bryan Talbot
I found a way that causes the 1.4.10 (and probably 1.4.11) releases to crash with a segfault. The message in /var/log/messages is Mar 3 12:44:34 host kernel: haproxy[16392]: segfault at rip rsp 7fff7402a9d8 error 14 host:~$ /usr/sbin/haproxy -vv HA-Proxy