Re: haproxy issue tracker discussion

2019-01-11 Thread Willy Tarreau
Hi Lukas, On Sat, Jan 12, 2019 at 02:53:45AM +0100, Lukas Tribus wrote: > Hi Tim, Willy, > > apologies for not responding sooner, I always have to force myself to > policy/organizational discussions, when I can also read stack or > straces :) You really don't need to apologize :-) > > So in

Re: haproxy issue tracker discussion

2019-01-11 Thread Lukas Tribus
Hi Tim, Willy, apologies for not responding sooner, I always have to force myself to policy/organizational discussions, when I can also read stack or straces :) >> When should the binary "issue open" / "issue closed" property be >> toggled? When the issue is fixed in Dev? When the issue is

Re: Lots of mail from email alert on 1.9.x

2019-01-11 Thread PiBa-NL
Hi Olivier, Op 11-1-2019 om 19:17 schreef Olivier Houchard: Ok so erm, I'd be lying if I claimed I enjoy working on the check code, or that I understand it fully. However, after talking with Willy and Christopher, I think I may have comed with an acceptable solution, and the attached patch

Re: Lots of mail from email alert on 1.9.x

2019-01-11 Thread Olivier Houchard
On Fri, Jan 11, 2019 at 06:53:11PM +0100, Olivier Houchard wrote: > Hi, > > On Fri, Jan 11, 2019 at 10:36:04AM +0100, Johan Hendriks wrote: > > Thanks all. > > No rush on my side as it is a test machine, at least we do know when a > > backend server fails. > > With all this mail the mail server

Re: Lots of mail from email alert on 1.9.x

2019-01-11 Thread Olivier Houchard
Hi, On Fri, Jan 11, 2019 at 10:36:04AM +0100, Johan Hendriks wrote: > Thanks all. > No rush on my side as it is a test machine, at least we do know when a > backend server fails. > With all this mail the mail server are giving alarms too :D > > I disable the mail feature for now. > > Thanks

[PATCH 01/10] MINOR: cfgparse: Extract some code to be re-used.

2019-01-11 Thread flecaille
From: Frédéric Lécaille Create init_peers_frontend() function to allocate and initialize the frontend of "peers" sections (->peers_fe) so that to reuse it later. May be backported to 1.5 and newer. --- src/cfgparse.c | 34 ++ 1 file changed, 26 insertions(+), 8

[PATCH 06/10] MINOR: cfgparse: Simplication.

2019-01-11 Thread flecaille
From: Frédéric Lécaille Make init_peers_frontend() be callable without having to check if there is something to do or not. May be backported to 1.5 and newer. --- src/cfgparse.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/cfgparse.c b/src/cfgparse.c index

[PATCH 05/10] MINOR: cfgparse: Rework peers frontend init.

2019-01-11 Thread flecaille
From: Frédéric Lécaille Even if not already the case, we suppose that the frontend "peers" section may have been already initialized outside of "peer" line, we seperate their initializations from their binding initializations. May be backported to 1.5 and newer. --- src/cfgparse.c | 50

[PATCH 10/10] DOC: peers: SSL/TLS documentation for "peers"

2019-01-11 Thread flecaille
From: Frédéric Lécaille --- doc/configuration.txt | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/doc/configuration.txt b/doc/configuration.txt index 888515fb..d55e4bd3 100644 --- a/doc/configuration.txt +++ b/doc/configuration.txt @@ -1928,6 +1928,12

[PATCH 04/10] MINOR: cfgparse: Useless frontend initialization in "peers" sections.

2019-01-11 Thread flecaille
From: Frédéric Lécaille Use ->local "peers" struct member to flag a "peers" section frontend has being initialized. This is to be able to initialize the frontend of "peers" sections on lines different from "peer" lines. May be backported to 1.5 and newer. --- src/cfgparse.c | 17

[PATCH 07/10] MINOR: cfgparse: Make "peer" lines be parsed as "server" lines.

2019-01-11 Thread flecaille
From: Frédéric Lécaille With this patch "default-server" lines are supported in "peers" sections to setup the default settings of peers which are from now setup when parsing both "peer" and "server" lines. May be backported to 1.5 and newer. --- src/cfgparse.c | 88

[PATCH 03/10] CLEANUP: cfgparse: Code reindentation.

2019-01-11 Thread flecaille
From: Frédéric Lécaille May help the series of patches to be reviewed. May be backported to 1.5 and newer. --- src/cfgparse.c | 72 +- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/src/cfgparse.c b/src/cfgparse.c index

[PATCH 08/10] MINOR: peers: Make outgoing connection to SSL/TLS peers work.

2019-01-11 Thread flecaille
From: Frédéric Lécaille This patch adds pointer to a struct server to peer structure which is initialized after having parsed a remote "peer" line. After having parsed all peers section we run ->prepare_srv to initialize all SSL/TLS stuff of remote perr (or server). Remaining thing to do to

[PATCH 09/10] MINOR: cfgparse: SSL/TLS binding in "peers" sections.

2019-01-11 Thread flecaille
From: Frédéric Lécaille This patch makes "bind" work in "peers" sections. All "bind" settings are supported, excepted ip:port parameters which are provided on "peer" (or server) line matching the local peer. After having parsed the configuration files ->prepare_bind_conf is run to initialize all

[PATCH 02/10] CLEANUP: cfgparse: Return asap from cfg_parse_peers().

2019-01-11 Thread flecaille
From: Frédéric Lécaille Avoid useless code indentation. May be backported to 1.5 and newer. --- src/cfgparse.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/cfgparse.c b/src/cfgparse.c index 6fde7c9f..6670a861 100644 --- a/src/cfgparse.c +++ b/src/cfgparse.c @@

[PATCH 00/10] Peers SSL/TLS support

2019-01-11 Thread flecaille
From: Frédéric Lécaille Hi ML, With this series of patches we add the SSL/TLS support to haproxy peers. Regards, Fred. Frédéric Lécaille (10): MINOR: cfgparse: Extract some code to be re-used. CLEANUP: cfgparse: Return asap from cfg_parse_peers(). CLEANUP: cfgparse: Code reindentation.

Keep client side open on FIN till backend responds

2019-01-11 Thread Assen Totin
Hi, everybody! I'm facing an issue with a somewhat weird/broken client and I'm looking for some advise on it. The client opens a HTTPS session and sends its request (POST data in my case). The HTTPS part is fine. The POST data is small, so it fits into a single TCP packet, which arrives with

Re: Lots of mail from email alert on 1.9.x

2019-01-11 Thread Johan Hendriks
Thanks all. No rush on my side as it is a test machine, at least we do know when a backend server fails. With all this mail the mail server are giving alarms too :D I disable the mail feature for now. Thanks again Pieter, Willy and Oliver for all your work. Op 10-01-19 om 20:05 schreef

[PATCH 2/2] REGTEST: Adapt reg test doc files to vtest.

2019-01-11 Thread flecaille
From: Frédéric Lécaille This is a first patch to switch from varnishtest to new standalone varnish cache reg testing program: vtest. More information may be found here: https://github.com/vtest/VTest https://varnish-cache.org/docs/trunk/reference/varnishtest.html

[PATCH 0/2] Switch to vtest.

2019-01-11 Thread flecaille
From: Frédéric Lécaille Hi ML, With these patches, haproxy switches to the new varnish cache reg testing tool named vtest, formerly known as varnishtest. From the user point of view, there is no very much differences compared to the usage of varnishtest. Before we started the reg testing

[PATCH 1/2] REGTEST: Switch to vtest.

2019-01-11 Thread flecaille
From: Frédéric Lécaille This patch replace the usage of the formerly varnish cache reg testing program, name varnishtest by the new standalone one: vtest. --- Makefile| 10 +- scripts/run-regtests.sh | 28 ++-- 2 files changed, 19 insertions(+),

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-11 Thread Frederic Lecaille
On 1/11/19 12:35 AM, Cyril Bonté wrote: Hi all, Le 08/01/2019 à 10:06, Willy Tarreau a écrit : On Tue, Jan 08, 2019 at 09:31:22AM +0100, Frederic Lecaille wrote: Indeed this script could worked with a short mailer timeout before af4021e6 commit. Another git bisect shows that 53216e7d