Re: Enhancement plugin feature for haproxy

2020-01-20 Thread Christopher Faulet 

Le 18/01/2020 à 13:10, Aleksandar Lazic a écrit :

Hi.

The nuster proxy modifies haproxy.c and adds some structs and function calls
into the haproxy main code.

Examples:
https://github.com/jiangwenyuan/nuster/blob/master/src/haproxy.c#L182
https://github.com/jiangwenyuan/nuster/blob/master/src/haproxy.c#L2243
https://github.com/jiangwenyuan/nuster/blob/master/src/haproxy.c#L2744

When I look to the prometheus-exporter which also enhances the haproxy with a
service, what's the best way to migrate the nuster to none modifying enhancement
plugin?
http://git.haproxy.org/?p=haproxy.git;a=blob;f=contrib/prometheus-exporter/service-prometheus.c;h=0f178eb64e2a376d2b56ac7ce3a71d88438246e7;hb=HEAD

I would like to create a 'contrib/nuster' to be able to build nuster in a 
similar
way like the prometheus-exporter.

My steps in mind.

* download/git clone nuster
* download/git clone haproxy
* cd to haproxy
* make TARGET=linux-glibc EXTRA_OBJS="contrib/nuster/nuster.o" 
NUSTER_DIR="/path/to/nuster/root/dir"

Due to the fact that prom-extporter does not add statments to '.global' I'm
not sure if the enhancement is possible or make sense.

Opinions?


Hi Aleks,

First of all, I don't really know how nuster works. As far as I can see, some 
updates to nuster is required to do such plugin. First of all, it should not 
extend the global structure. Instead it should use its own global private 
structure. 51Degrees, Wurfl and DeviceAtlas already do it. In the same spirit, 
it should not add a rule list in the proxy structure. It may rely on the 
existing HTTP ruleset adding some keywords. Or it may use a list in the nuster 
filters configuration. Then, it should be HTX aware. Finally, a task must be 
created to manage the calls to the function nuster_housekeeping(). It is of 
course totally impossible to call it from the polling loop.


So to answer your question, with some changes in nuster, it is probably 
technically possible to create a service using nuster code. The main problem I 
see is the maintainability of this plugin. Nuster evolves in parallel of 
HAProxy. It is a fork of it, it is not a patchset on top of it. The nuster 
developer never tried to make its project compatible with HAProxy. Or at least, 
he never asked anything on the mailing list. So, of course, it is its own right. 
There is no problem with that. But it could be a good idea to have a better view 
on how the project will evolve to evaluate the pertinence of a nuster plugin. 
Honestly, if you ever do the effort to work on it, it could be better to rewrite 
all the project as a plugin of HAProxy and not a fork of it. If so, it is 
probably a better idea to keep it in a separate repository though. This will be 
easier to push new features, without the burden to submit the patches on the ML.


Of course, it could be good to have the opinion of the nuster's developer, to 
know if he is up for doing some changes this way.


--
Christopher Faulet

[PATCH] MINOR: ssl: accept 'verify' bind option with 'set ssl cert'

2020-01-20 Thread Emmanuel Hocdet 
Hi,

A last patch for today.

++
Manu



0001-MINOR-ssl-accept-verify-bind-option-with-set-ssl-cer.patch
Description: Binary data

[PATCH] BUG/MINOR: ssl: ssl_sock_load_pem_into_ckch is not consistent

2020-01-20 Thread Emmanuel Hocdet 

Hi,

Proposal to fix the issue.

++
Manu 



0001-BUG-MINOR-ssl-ssl_sock_load_pem_into_ckch-is-not-con.patch
Description: Binary data

[PATCH] BUG/MINOR: ssl: fix 3 memory leaks with set ssl cert

2020-01-20 Thread Emmanuel Hocdet 

Hi,

Fix memory leaks with « set ssl cert ».

++
Manu




0001-BUG-MINOR-ssl-ssl_sock_load_ocsp_response_from_file-.patch
Description: Binary data


0002-BUG-MINOR-ssl-ssl_sock_load_issuer_file_into_ckch-me.patch
Description: Binary data


0003-BUG-MINOR-ssl-ssl_sock_load_sctl_from_file-memory-le.patch
Description: Binary data

Re: 51d.c HTX patch

2020-01-20 Thread Christopher Faulet 

Le 20/01/2020 à 12:31, Ben Shillito a écrit :

Hi Willy,

I have attached a patch which fixes the bug raised in this GitHub issue: 
https://github.com/haproxy/haproxy/issues/450


The issue was reported in 2.0.12, so should be backported to 2.0 and 2.1 
branches.

If there is anything extra you need from me, do let me know as we’d like to get 
the fix out there as soon as we can.




Applied, thanks ! The fix was backported to 2.1, 2.0 and 1.9.

I amended your commit message to add backports info and the reference to the 
github issue. I also reformatted the message. Please, next time, be careful to 
follow CONTRIBUTING rules, especially the section 11 about commit messages format.


--
Christopher Faulet

Advertisement Request on your website.

2020-01-20 Thread Austin Dease 
Hi!
I am an outreach executive contacting you to publish my guest posts on your 
site. 
Please let me know how much do you charge per post. We can credit your fee via 
PayPal or Payoneer.
My requirements are:
•   A Do-Follow link.
•   No Sponsor Tags.
•   Keep the posts published for a year or more.

I ensure that content quality and niche will meet your blog’s requirements. 
Moreover, we do not promote porn, illegal, or malicious links. I wish to 
maintain a good professional relation with you for the long term.
Hope to hear from you soon.
Regards,

Re: [PATCH] introduce ARM64 travis-ci builds

2020-01-20 Thread Martin Grigorov 
Thank you, Илья!

On Sun, Jan 19, 2020 at 9:20 AM Илья Шипицин  wrote:

> hello,
>
> sometimes arm64 builds fails, I think it is good chance to introduce
> regular builds
> and fix them.
>
> also, few small improvements.
>
> cheers,
> Ilya Shipicin
>

51d.c HTX patch

2020-01-20 Thread Ben Shillito 
Hi Willy,

I have attached a patch which fixes the bug raised in this GitHub issue: 
https://github.com/haproxy/haproxy/issues/450

The issue was reported in 2.0.12, so should be backported to 2.0 and 2.1 
branches.

If there is anything extra you need from me, do let me know as we'd like to get 
the fix out there as soon as we can.

Thanks,

Ben Shillito
Developer
[51Degrees]
O: +44 1183 287152
E: b...@51degrees.com
[https://51degrees.com/portals/0/images/twitterbird.png] 
@51Degrees
[https://51degrees.com/portals/0/images/linkedinicon.png] 
51Degrees
[Find out More]

This email and any attachments are confidential and may also be privileged. If 
you are not the named recipient, please notify the sender immediately and do 
not disclose, use, store or copy the information contained herein. This is an 
email from 51Degrees.mobi Limited, 5 Charlotte Close, Reading. RG47BY. T: +44 
118 328 7152; E: i...@51degrees.com; 51Degrees.mobi Limited t/as 51Degrees.


0001-BUG-MINOR-Fixed-bug-in-51d.c-when-HTX-is-enabled.patch
Description:  0001-BUG-MINOR-Fixed-bug-in-51d.c-when-HTX-is-enabled.patch