Re: Too many response errors
I used "show errors -1 response" in haproxy socket to see these errors but nothing found! Is there any way I can see the errors? On Thu, Oct 15, 2020 at 9:48 PM Seena Fallah wrote: > Based on this comment is this related to the client and there is no > problem on the server side? > https://github.com/haproxy/haproxy/blob/master/include/haproxy/channel-t.h#L68 > > On Wed, Oct 14, 2020 at 3:29 PM Seena Fallah > wrote: > >> Hi. >> >> I'm facing many response errors from my backends and I have checked the >> logs but there were no 5xx errors for these response errors! It seems I'm >> in this section of code and because I use http-server-close it will count >> failed_resp! >> https://github.com/haproxy/haproxy/blob/master/src/http_ana.c#L1648-L1667 >> Can you please explain why keep-alive connections won't count this and >> what actually is this? >> >> Using haproxy 2.2.4 on docker >> >> Thanks. >> >
[PATCH] BUG/MINOR: listener: close before free in `listener_accept`
safer to close handle before the object is put back in the global pool.
this was introduced by commit 9378bbe0bef4005155d ("MEDIUM: listener:
use protocol->accept_conn() to accept a connection")
this should fix github issue #902
no backport needed.
Signed-off-by: William Dauchy
---
src/listener.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/listener.c b/src/listener.c
index 85191f50b..7061f9a9d 100644
--- a/src/listener.c
+++ b/src/listener.c
@@ -855,8 +855,8 @@ void listener_accept(struct listener *l)
send_log(p, LOG_EMERG,
"Proxy %s reached the configured maximum
connection limit. Please check the global 'maxconn' value.\n",
p->id);
- conn_free(cli_conn);
close(cli_conn->handle.fd);
+ conn_free(cli_conn);
expire = tick_add(now_ms, 1000); /* try again in 1
second */
goto limit_global;
}
--
2.28.0
Re: [ANNOUNCE] haproxy-2.3-dev7
Hi Tim, On Sun, Oct 18, 2020 at 04:29:51PM +0200, Tim Düsterhus wrote: > Willy, > > Am 17.10.20 um 11:22 schrieb Willy Tarreau: > > I'll try to stick to one version per week till the release in order to > > ease testing. And if you don't want to put it on test on your production > > (which I perfectly understand despite doing it myself), you can at least > > use it with "-c" on your existing configs to check that everything still > > looks good with no warning! > > > > I just upgraded the HAProxy on my personal box. If this email reaches > you then HAProxy is not completely broken. :-) > In all seriousness: No new warnings [1], it started up just fine. The > box pushes negligible traffic, though. Thanks for the feedback! Looks like it's working fine here as well for now: http://stats.haproxy.org/ > [1] I did not get around fixing the "hiding headers or body at the end > of the version string is deprecated" one yet. I guess this is the one about the health checks ? If so I'm assuming it's essentially because you're taking care of keeping the config backwards compatible in case of rollback ? Thanks, Willy
Re: [ANNOUNCE] haproxy-2.3-dev7
Willy, Am 17.10.20 um 11:22 schrieb Willy Tarreau: > I'll try to stick to one version per week till the release in order to > ease testing. And if you don't want to put it on test on your production > (which I perfectly understand despite doing it myself), you can at least > use it with "-c" on your existing configs to check that everything still > looks good with no warning! > I just upgraded the HAProxy on my personal box. If this email reaches you then HAProxy is not completely broken. In all seriousness: No new warnings [1], it started up just fine. The box pushes negligible traffic, though. Best regards Tim Düsterhus [1] I did not get around fixing the "hiding headers or body at the end of the version string is deprecated" one yet.
