Fixes #1037
---
src/haproxy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/haproxy.c b/src/haproxy.c
index a28b45fb9..1d16b507d 100644
--- a/src/haproxy.c
+++ b/src/haproxy.c
@@ -2649,6 +2649,7 @@ void deinit(void)
free(s->available_conns);
Here it is split up into multiple patches.
I also included a patch that adds a few words to the
ignore-words-list in the codespell workflow.
-- >8 --
>From 65d9fd1583841a92afdc276c8fca72ed7f49345b Mon Sep 17 00:00:00 2001
From: Thayne McCombs
Date: Thu, 7 Jan 2021 21:24:41 -0700
Subject:
During a configuration check valgrind reports:
==14425== 0 bytes in 106 blocks are definitely lost in loss record 1 of 107
==14425==at 0x4C2DB8F: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==14425==by 0x4C2FDEF: realloc (in
Thayne,
Am 07.01.21 um 16:55 schrieb Thayne McCombs:
>> `iff` means `if and only if`.
>
> I was aware of this abbreviation, but wasn't sure if that was the intended
> meaning or if it was a typo. Do you think it would be better to spell it
> out as "if and only if", or to add iff to the list of
Hi,
patch resolving #1030 attached.
Ilya
From eb849f02b0fef02a4d40f7566da3b54b2d0a8368 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Thu, 7 Jan 2021 22:45:13 +0500
Subject: [PATCH] CLEANUP: replace "realloc" with "my_realloc2" to fix to
memory leak
my_realloc2 frees variable in case of
it could be sometimes a bit confusing to have tests which are known to
be broken executed in the default `make reg-tests` command, especially
for not frequent contributors which are not necessarily aware of all our
quirks.
without this patch, this test is failing on my side:
#top TEST
okay, sounds good. I'll send up separated patches later today.
> `iff` means `if and only if`.
I was aware of this abbreviation, but wasn't sure if that was the intended
meaning or if it was a typo. Do you think it would be better to spell it
out as "if and only if", or to add iff to the list of
Thayne,
Am 07.01.21 um 10:09 schrieb Thayne McCombs:
> diff --git a/doc/internals/htx-api.txt b/doc/internals/htx-api.txt
> index e783e0ebf..07224821c 100644
> --- a/doc/internals/htx-api.txt
> +++ b/doc/internals/htx-api.txt
> @@ -113,7 +113,7 @@ payload.
>
> Because the payloads part may
Hi Thayne,
On Thu, Jan 07, 2021 at 02:09:10AM -0700, Thayne McCombs wrote:
> From the output of codespell.
Thanks for this, but I'll ask you a favor, which is to split this into
2 or 3 patches:
- one for the pure documentation, that will have to be backported
since the documentation is
On Thu, Jan 7, 2021 at 4:02 PM Willy Tarreau wrote:
> No, we'd rather indeed make the types exclude broken by default.
> Let's just preset "REGTESTS_TYPES=default,bug,devel,slow" in the makefile
> and that's done without changing anything for anyone who already forces
> them.
>
> Patches welcome,
On Thu, Jan 07, 2021 at 03:12:20PM +0100, William Dauchy wrote:
> On Thu, Jan 7, 2021 at 1:54 PM ??? wrote:
> > We can make regtest type mandatory
>
> honestly not a fan :) makes it more complicated for people trying to
> contribute simple things
No, we'd rather indeed make the types
On Thu, Jan 7, 2021 at 1:54 PM Илья Шипицин wrote:
> We can make regtest type mandatory
honestly not a fan :) makes it more complicated for people trying to
contribute simple things
--
William
On Thu, Jan 7, 2021, 5:19 PM William Dauchy wrote:
> On Thu, Jan 7, 2021 at 12:53 PM Илья Шипицин wrote:
> > They are excluded in ci builds
> > - env VTEST_PROGRAM=../vtest/vtest gmake reg-tests
> REGTESTS_TYPES=default,bug,devel || (for folder in /tmp/*regtest*/vtc.*; do
> cat $folder/INFO
On Thu, Jan 7, 2021 at 12:53 PM Илья Шипицин wrote:
> They are excluded in ci builds
> - env VTEST_PROGRAM=../vtest/vtest gmake reg-tests
> REGTESTS_TYPES=default,bug,devel || (for folder in /tmp/*regtest*/vtc.*; do
> cat $folder/INFO $folder/LOG; done && exit
yeah I understood, but I'm
On Thu, Jan 7, 2021, 4:45 PM William Dauchy wrote:
> On Thu, Jan 7, 2021 at 11:54 AM William Lallemand
> wrote:
> > These reg-tests are of types "slow" and "broken" not launched by the CI.
>
> thanks folks for your inputs. my vtest was indeed out of date.
> now I'm left with:
>
>
On Thu, Jan 7, 2021 at 11:54 AM William Lallemand
wrote:
> These reg-tests are of types "slow" and "broken" not launched by the CI.
thanks folks for your inputs. my vtest was indeed out of date.
now I'm left with:
## Starting vtest ##
Testing with
On 1/7/21 11:03 AM, William Dauchy wrote:
unclear whether this is on my side only because I did not investigate
but I have two tests failing for a while now:
## Starting vtest ##
Testing with haproxy version: 2.4-dev5-761d64-4
#top TEST
On Thu, Jan 07, 2021 at 11:21:07AM +0100, Willy Tarreau wrote:
> On Thu, Jan 07, 2021 at 11:03:14AM +0100, William Dauchy wrote:
> > On Wed, Jan 6, 2021 at 5:45 PM Willy Tarreau wrote:
> > > HAProxy 2.4-dev5 was released on 2021/01/06. It added 91 new commits
> > > after version 2.4-dev4.
> >
>
On Thu, Jan 07, 2021 at 11:03:14AM +0100, William Dauchy wrote:
> On Wed, Jan 6, 2021 at 5:45 PM Willy Tarreau wrote:
> > HAProxy 2.4-dev5 was released on 2021/01/06. It added 91 new commits
> > after version 2.4-dev4.
>
> unclear whether this is on my side only because I did not investigate
>
чт, 7 янв. 2021 г. в 15:06, William Dauchy :
> On Wed, Jan 6, 2021 at 5:45 PM Willy Tarreau wrote:
> > HAProxy 2.4-dev5 was released on 2021/01/06. It added 91 new commits
> > after version 2.4-dev4.
>
> unclear whether this is on my side only because I did not investigate
> but I have two tests
On Wed, Jan 6, 2021 at 5:45 PM Willy Tarreau wrote:
> HAProxy 2.4-dev5 was released on 2021/01/06. It added 91 new commits
> after version 2.4-dev4.
unclear whether this is on my side only because I did not investigate
but I have two tests failing for a while now:
##
On Thu, Jan 07, 2021 at 12:28:02PM +0500, Илья Шипицин wrote:
> Hi,
>
> another series of removing HA_OPENSSL_VERSION
>
> Ilya
Thanks, merged.
--
William Lallemand
From the output of codespell.
---
BRANCHES | 2 +-
CONTRIBUTING | 2 +-
INSTALL| 2 +-
Makefile | 4 ++--
doc/configuration.txt | 10 +-
doc/internals/acl.txt | 6 +++---
23 matches
Mail list logo
