Fix small bug in srv_parse_agent_check

Hi all, I was building HAProxy using scan-build to see if there were any issues and it called out an unused variable write. I think this was due to a bug that the err_code was not used in srv_parse_agent_check. I’ve attached a patch to fix this issue. Cheers, Dirkjan Bussink 0001-BUG-MINO

Re: Bad backend selected

On Fri, Jun 18, 2021 at 05:08:56PM +0200, Tim Düsterhus wrote: > > So I had some thoughts about that discussion that started off-list. And > > now I think that the right thing to do is to always drop the port part > > of the authority when we have a scheme for which it's the default. I.e. > > if th

Re: Bad backend selected

Willy, On 6/8/21 8:37 AM, Willy Tarreau wrote: However the only difference is the 443 port explicitly specified in the later request. I am not sure it's something specific to 2.4.0, but I've never seen it before. Is it an expected behaviour ? If so, how can I change my acls to correct it ? I e

Re: [PATCH] BUG/MINOR: cache: Correctly handle existing-but-empty, 'accept-encoding' header

On Fri, Jun 18, 2021 at 04:07:10PM +0200, Tim Düsterhus, WoltLab GmbH wrote: > Remi, > > On 6/18/21 3:46 PM, Remi Tricot-Le Breton wrote: > > > please find a small fix for the 'Vary' support of the cache to > > > correctly handle the difference between a missing 'accept-encoding' > > > and an empt

Re: [PATCH] BUG/MINOR: cache: Correctly handle existing-but-empty, 'accept-encoding' header

Remi, On 6/18/21 3:46 PM, Remi Tricot-Le Breton wrote: please find a small fix for the 'Vary' support of the cache to correctly handle the difference between a missing 'accept-encoding' and an empty 'accept-encoding'. Nice catch, I completely forgot about this case. Frankly it's a bit dum

Re: [PATCH] BUG/MINOR: cache: Correctly handle existing-but-empty, 'accept-encoding' header

On Fri, Jun 18, 2021 at 03:46:26PM +0200, Remi Tricot-Le Breton wrote: > Hello Tim, > > On 18/06/2021 15:26, Tim Düsterhus, WoltLab GmbH wrote: > > Remi, > > > > please find a small fix for the 'Vary' support of the cache to correctly > > handle the difference between a missing 'accept-encoding'

Re: [PATCH] BUG/MINOR: cache: Correctly handle existing-but-empty, 'accept-encoding' header

Hello Tim, On 18/06/2021 15:26, Tim Düsterhus, WoltLab GmbH wrote: Remi, please find a small fix for the 'Vary' support of the cache to correctly handle the difference between a missing 'accept-encoding' and an empty 'accept-encoding'. Best regards Tim Düsterhus Developer WoltLab GmbH Nic

[PATCH] BUG/MINOR: cache: Correctly handle existing-but-empty, 'accept-encoding' header

Remi, please find a small fix for the 'Vary' support of the cache to correctly handle the difference between a missing 'accept-encoding' and an empty 'accept-encoding'. Best regards Tim Düsterhus Developer WoltLab GmbH -- WoltLab GmbH Nedlitzer Str. 27B 14469 Potsdam Tel.: +49 331 96784338