Re: [PATCH] BUG/???: threads: Use get_(local|gm)time instead of (local|gm)time

2021-08-29 Thread Willy Tarreau
On Sat, Aug 28, 2021 at 11:57:01PM +0200, Tim Duesterhus wrote:
> Willy,
> 
> please fill in the severity yourself.

Good catch, I didn't notice we still had those. Applied as minor as
I don't think anyone really noticed it (it would require different
arguments in different converters to be used in parallel in different
threads for the problem to be noticeable).

Thanks,
Willy



Re: [PATCH] BUG/MINOR: tools: Fix loop condition in dump_text()

2021-08-29 Thread Willy Tarreau
On Sun, Aug 29, 2021 at 12:58:22AM +0200, Tim Duesterhus wrote:
> The condition should first check whether `bsize` is reached, before
> dereferencing the offset. Even if this always works fine, due to the
> string being null-terminated, this certainly looks odd.

Applied as well, thank you!
Willy



Server current weight

2021-08-29 Thread Prytoegrian
Hi to all,

first of all, thanks for the software, I adore it.

I think I found a bug in Haproxy but I first want to be sure it's a real one. 
It might just be a semantic misunderstanding of mine.

I described a backend with two servers, one of them with "slowstart" option. 
When I set it in maintenance then ready again, CLI `get weight` doesn't show 
current weight, like the stat page could displays, but the user defined one.

The documentation in the associated function states
```c
// cli_parse_get_weight
/* return server's effective weight at the moment */
```
effective weight having a precise meaning in haproxy.

Did I understand the expected behavior right ?

If the bug is proved, I would be glad to report it as such in github and 
propose a fix, eventually with some help.

Please CC me, I didn't subscribe to ML.

Prytoegrian

Sent with ProtonMail Secure Email.

publickey - prytoegrian@protonmail.com - 0xD78075EC.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature