Re: [PATCH] CLEANUP: http_ana: Make use of the return value of stream_generate_unique_id()
On Wed, May 18, 2022 at 12:22:15AM +0200, Tim Duesterhus wrote: > Even if `unique_id` and `s->unique_id` are identical it is a bit odd to > `isttest()` `unique_id` and then use `s->unique_id` in the call to > `http_add_header()`. Agreed, better be consistent. Now applied, thank you Tim! Willy
[PATCH] CLEANUP: http_ana: Make use of the return value of stream_generate_unique_id()
Even if `unique_id` and `s->unique_id` are identical it is a bit odd to `isttest()` `unique_id` and then use `s->unique_id` in the call to `http_add_header()`. This "issue" was introduced in a17e66289c08a5bfadc1bb5b5f2c618c9299fe1b, because before that commit the function returned the length of the ID, as it was not an ist. --- src/http_ana.c | 2 +- src/stream.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/http_ana.c b/src/http_ana.c index 4b3113e2d..69340656a 100644 --- a/src/http_ana.c +++ b/src/http_ana.c @@ -646,7 +646,7 @@ int http_process_request(struct stream *s, struct channel *req, int an_bit) /* send unique ID if a "unique-id-header" is defined */ if (isttest(sess->fe->header_unique_id) && - unlikely(!http_add_header(htx, sess->fe->header_unique_id, s->unique_id))) + unlikely(!http_add_header(htx, sess->fe->header_unique_id, unique_id))) goto return_int_err; } diff --git a/src/stream.c b/src/stream.c index c7002366f..a02ea9871 100644 --- a/src/stream.c +++ b/src/stream.c @@ -2861,7 +2861,7 @@ INITCALL0(STG_INIT, init_stream); /* Generates a unique ID based on the given , stores it in the given and * returns the unique ID. - + * * If this function fails to allocate memory IST_NULL is returned. * * If an ID is already stored within the stream nothing happens existing unique ID is -- 2.36.1
RE: Utility Software Users
v
RE: Utility Software Users
Hi, Is there any update to my previous email Please let me know your thoughts, so that i can get back to you with complete details Waiting for your earliest response, Regards, Jessica Morgan
Re: Peers using heavily single cpu core
Le 4/20/22 à 14:51, Maciej Zdeb a écrit : Hi Willy, I saw Christopher changes are now merged. I was wondering how to proceed with my issue. Right now in stream_new() I'm able to get cs_endpoint and appctx (if endpoint is applet), so I can get thread_mask of appctx to create a stream task on the same thread. Is this approach correct? Hi Maciej, I've finally finish my applet refactoring. Now it is possible to choose where to start an applet. I've also merged your patches. Peer applets must now be balanced across threads. So, you may give it a try to be sure it solves your issue and also validate everything works fine. -- Christopher Faulet
For the attention of HAPROXY TECHNOLOGIES
To: Director / CEO HAPROXY TECHNOLOGIES France We now offer international project funding and other financial facilities for companies and individuals who intend to expand. We will be pleased to give you more information as you get back to us. Best Regards, Matthew Hernandez Solicitor / Financial Broker. Tel: +44 7828 517587 Copyright© 2022 Alltium Brokers
Re: Observing low test-suite coverage
k, can we review this sometimes ? )) I'd like to set automatic coverage after that. ср, 23 февр. 2022 г. в 15:44, Tim Düsterhus : > Willy, > > On 2/23/22 11:43, Илья Шипицин wrote: > > Willy, can you please apply patch from Tim (below) ? > > No, please don't. This patch is hugely unsafe. Someone will need to > create a proper patch that wasn't hacked together in 2 minutes. > > Best regards > Tim Düsterhus >
Re: [PATCH 1/1]: BUILD/MINOR: solaris based oses build fix/get_exe_path implementation.
Both patches merged, thanks David! Willy
Re: [PATCH v2 2/3] CLEANUP: Add missing header to hlua_fcn.c
On Sat, May 14, 2022 at 10:17:25PM +0200, Tim Duesterhus wrote: > Found with -Wmissing-prototypes: (...) All the series merged (with v2), thank you Tim! Willy
Re: Fwd: Set environment variables
Il giorno ven 13 mag 2022 alle ore 16:10 Willy Tarreau ha scritto: > Hi Valerio, > > On Mon, May 09, 2022 at 10:14:09AM +0200, Valerio Pachera wrote: > > Unfortunately I'm not a developer so it will take too much time form me > to > > contribute to the code. > > I've just implemented it in 2.6-dev as this commit: > > https://github.com/haproxy/haproxy/commit/973cf90714 > > Once 2.6 is released we may backport it to 2.5 as it's expected to be > trivial and with no side effect. > Thank you very much!
