[PATCH] CLEANUP: use "offsetof" macro where appropriate

2023-04-15 Thread Илья Шипицин
Hello, small cleanup patch attached. Ilya From 77babd04c417709bb41c951701d62dec0574eb35 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 15 Apr 2023 23:39:43 +0200 Subject: [PATCH] CLEANUP: use "offsetof" where appropriate let's use the C library macro "offsetof" --- src/cache.c|

Re: Problems using custom error files with HTTP/2

2023-04-15 Thread Willy Tarreau
On Sat, Apr 15, 2023 at 10:59:42PM +0200, Willy Tarreau wrote: > Hi Nick, > > On Sat, Apr 15, 2023 at 09:44:32PM +0100, Nick Wood wrote: > > And here is my configuration - I've slimmed it down to the absolute minimum > > to reproduce the problem: > > > > If the back end is down, the custom

Re: Problems using custom error files with HTTP/2

2023-04-15 Thread Willy Tarreau
Hi Nick, On Sat, Apr 15, 2023 at 09:44:32PM +0100, Nick Wood wrote: > And here is my configuration - I've slimmed it down to the absolute minimum > to reproduce the problem: > > If the back end is down, the custom 503.http page should be served. > > This works on HTTP/1.1 but not over HTTP/2:

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Willy Tarreau
Ai Aleks, On Sat, Apr 15, 2023 at 10:12:00PM +0200, Aleksandar Lazic wrote: > Hi. > > On 15.04.23 11:32, Willy Tarreau wrote: > > Hi everyone, > > > > I was discussing with Tristan a few hours ago about the widespread > > deployment of H2 and H3, with Cloudflare showing that H1 only accounts >

Re: Problems using custom error files with HTTP/2

2023-04-15 Thread Nick Wood
Hi Alex, On 15/04/2023 20:32, Aleksandar Lazic wrote: Please can you share the haproxy version `haproxy -vv`. What is your configuration? Include as much configuration as possible, including global and default sections. Replace confidential data like domain names and IP addresses.

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Willy Tarreau
Hi Daniel, On Sat, Apr 15, 2023 at 02:37:06PM -0400, Daniel Corbett wrote: > Hi Willy, > > On Sat, Apr 15, 2023, at 8:02 AM, Willy Tarreau wrote: > > Hi Ionel, > > > > On Sat, Apr 15, 2023 at 01:52:27PM +0200, Ionel GARDAIS wrote: > > > Hi Willy, > > > > > > Agree with that. > > > However,

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Aleksandar Lazic
Hi. On 15.04.23 11:32, Willy Tarreau wrote: Hi everyone, I was discussing with Tristan a few hours ago about the widespread deployment of H2 and H3, with Cloudflare showing that H1 only accounts for less than 7% of their traffic and H3 getting close to 30% [1], and the fact that on the

Re: Problems using custom error files with HTTP/2

2023-04-15 Thread Aleksandar Lazic
Hi Nic, On 15.04.23 19:35, Nick Wood wrote: Hello all, I have recently enabled HTTP/2 on our HAProxy server by adding the following to the bind line: alpn h2,http/1.1 Everything appears to be working fine, apart from our custom error pages. Rather than serving the custom page as

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Daniel Corbett
Hi Willy, On Sat, Apr 15, 2023, at 8:02 AM, Willy Tarreau wrote: > Hi Ionel, > > On Sat, Apr 15, 2023 at 01:52:27PM +0200, Ionel GARDAIS wrote: > > Hi Willy, > > > > Agree with that. > > However, maybe a "common H2 troubleshooting guide" should be provided so > > options like

Problems using custom error files with HTTP/2

2023-04-15 Thread Nick Wood
Hello all, I have recently enabled HTTP/2 on our HAProxy server by adding the following to the bind line: alpn h2,http/1.1 Everything appears to be working fine, apart from our custom error pages. Rather than serving the custom page as before, browsers just report an error. In Chrome

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Willy Tarreau
On Sat, Apr 15, 2023 at 05:50:53PM +0200, Pavlos Parissis wrote: > On Saturday, April 15, 2023 11:32:49 AM CEST Willy Tarreau wrote: > > Hi everyone, > > [...snip...] > > Even if I wouldn't share my feelings, some would consider that I'm > > trying to influence their opinion, so I'll share them

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Pavlos Parissis
On Saturday, April 15, 2023 11:32:49 AM CEST Willy Tarreau wrote: > Hi everyone, [...snip...] > Even if I wouldn't share my feelings, some would consider that I'm > trying to influence their opinion, so I'll share them anyway :-) I > think that with the status change from

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Willy Tarreau
Hi John, On Sat, Apr 15, 2023 at 10:20:22AM -0400, John Lauro wrote: > I agree defaulting to alpn h2,http/1.1 sooner (don't wait for 2.9), > and even 2.6 would be fine IMO. Wouldn't be a new feature for 2.6, > only a non breaking (AFAIK) default change... We won't change 2.6 now since it's

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread John Lauro
I agree defaulting to alpn h2,http/1.1 sooner (don't wait for 2.9), and even 2.6 would be fine IMO. Wouldn't be a new feature for 2.6, only a non breaking (AFAIK) default change... I would have concerns making QUIC default for 443 ssl (especially prior to 2.8), but you are not suggesting that

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Willy Tarreau
Hi Lukas, On Sat, Apr 15, 2023 at 02:08:03PM +0200, Lukas Tribus wrote: > Hi, > > On Sat, 15 Apr 2023 at 11:32, Willy Tarreau wrote: > > Thus you're seeing me coming with my question: does anyone have any > > objection against turning "alpn h2,http/1.1" on by default for HTTP > > frontends, and

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Lukas Tribus
Hi, On Sat, 15 Apr 2023 at 11:32, Willy Tarreau wrote: > Thus you're seeing me coming with my question: does anyone have any > objection against turning "alpn h2,http/1.1" on by default for HTTP > frontends, and "alpn h3" by default for QUIC frontends, and have a new > "no-alpn" option to

Re: Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Willy Tarreau
Hi Ionel, On Sat, Apr 15, 2023 at 01:52:27PM +0200, Ionel GARDAIS wrote: > Hi Willy, > > Agree with that. > However, maybe a "common H2 troubleshooting guide" should be provided so > options like h2-workaround-bogus-websocket-clients will be highlighted if any > trouble arise. Good point, I

Re: [*EXT*] Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Ionel GARDAIS
Hi Willy, Agree with that. However, maybe a "common H2 troubleshooting guide" should be provided so options like h2-workaround-bogus-websocket-clients will be highlighted if any trouble arise. -- Ionel GARDAIS Tech'Advantage CIO - IT Team manager - Mail original - De: "Willy

Opinions desired on HTTP/2 config simplification

2023-04-15 Thread Willy Tarreau
Hi everyone, I was discussing with Tristan a few hours ago about the widespread deployment of H2 and H3, with Cloudflare showing that H1 only accounts for less than 7% of their traffic and H3 getting close to 30% [1], and the fact that on the opposite yesterday I heard someone say "we still have