vtest update

2019-03-06 Thread Frederic Lecaille
Hello ML, We have recently modified some reg tests which require an update for vtest, especially these ones: reg-tests/peers/s_basic_sync.vtc (added) reg-tests/peers/s_tls_basic_sync.vtc (added) reg-tests/http-messaging/h0.vtc(modified) So, if some reg tests fail

Re: Compilation fails on OS-X

2019-02-14 Thread Frederic Lecaille
On 2/14/19 3:12 PM, Patrick Hemmer wrote: On 2019/2/14 08:20, Frederic Lecaille wrote: On 2/14/19 1:32 PM, Frederic Lecaille wrote: On 2/13/19 7:30 PM, Patrick Hemmer wrote: On 2019/2/13 10:29, Olivier Houchard wrote: Hi Patrick, On Wed, Feb 13, 2019 at 10:01:01AM -0500, Patrick Hemmer

Re: Compilation fails on OS-X

2019-02-14 Thread Frederic Lecaille
On 2/14/19 1:32 PM, Frederic Lecaille wrote: On 2/13/19 7:30 PM, Patrick Hemmer wrote: On 2019/2/13 10:29, Olivier Houchard wrote: Hi Patrick, On Wed, Feb 13, 2019 at 10:01:01AM -0500, Patrick Hemmer wrote: On 2019/2/13 09:40, Aleksandar Lazic wrote: Am 13.02.2019 um 14:45 schrieb Patrick

Re: Compilation fails on OS-X

2019-02-14 Thread Frederic Lecaille
On 2/13/19 7:30 PM, Patrick Hemmer wrote: On 2019/2/13 10:29, Olivier Houchard wrote: Hi Patrick, On Wed, Feb 13, 2019 at 10:01:01AM -0500, Patrick Hemmer wrote: On 2019/2/13 09:40, Aleksandar Lazic wrote: Am 13.02.2019 um 14:45 schrieb Patrick Hemmer: Trying to compile haproxy on my

Re: reg-tests situation in haproxy 1.8

2019-01-21 Thread Frederic Lecaille
On 1/19/19 8:53 AM, Willy Tarreau wrote: Hi Lukas, On Fri, Jan 18, 2019 at 12:43:34PM +0100, Lukas Tribus wrote: Hello, currently we have 4 reg-tests in haproxy-1.8, backported due to the actual bugfix commit, which included a test. We also have a broken symbolic link in

Re: reg-tests situation in haproxy 1.8

2019-01-21 Thread Frederic Lecaille
On 1/19/19 8:53 AM, Willy Tarreau wrote: Hi Lukas, On Fri, Jan 18, 2019 at 12:43:34PM +0100, Lukas Tribus wrote: Hello, currently we have 4 reg-tests in haproxy-1.8, backported due to the actual bugfix commit, which included a test. We also have a broken symbolic link in

Re: [PATCH 10/10] DOC: peers: SSL/TLS documentation for "peers"

2019-01-14 Thread Frederic Lecaille
On 1/14/19 2:56 PM, Willy Tarreau wrote: Hi Fred, first, thanks for reviving this! On Fri, Jan 11, 2019 at 02:52:24PM +0100, flecai...@haproxy.com wrote: +bind [param*] + Defines the binding parameters of the local peer of this "peers" section. + To avoid some redundancy, and as the and

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-11 Thread Frederic Lecaille
On 1/11/19 12:35 AM, Cyril Bonté wrote: Hi all, Le 08/01/2019 à 10:06, Willy Tarreau a écrit : On Tue, Jan 08, 2019 at 09:31:22AM +0100, Frederic Lecaille wrote: Indeed this script could worked with a short mailer timeout before af4021e6 commit. Another git bisect shows that 53216e7d

Re: [PATCH 1/1] REGTEST: "capture (request|response)" regtest.

2019-01-09 Thread Frederic Lecaille
On 1/9/19 10:12 AM, Willy Tarreau wrote: On Tue, Jan 08, 2019 at 10:24:16AM +0100, flecai...@haproxy.com wrote: reg-tests/http-capture/h0.vtc | 92 +++ Nice one, thanks Fred, now merged! I'd be careful regarding expectations on log lines about stuff

Re: [RFC PATCH] couple of reg-tests

2019-01-09 Thread Frederic Lecaille
On 1/9/19 3:22 PM, Jarno Huuskonen wrote: Hello Frederic, On Mon, Jan 07, Frederic Lecaille wrote: reg-tests/http-rules/h3.vtc fails on my side due to a typo in the regex with this error: h10.0 CLI regexp error: 'missing opening brace after \o' (@48) (^0x[a-f0-9]+ example\.org

Re: [PATCH] REGTEST: filters: add compression test

2019-01-09 Thread Frederic Lecaille
On 1/9/19 10:43 AM, Frederic Lecaille wrote: On 1/8/19 11:25 PM, PiBa-NL wrote: Hi Frederic, Hi Pieter, Op 7-1-2019 om 10:13 schreef Frederic Lecaille: On 12/23/18 11:38 PM, PiBa-NL wrote: As requested hereby the regtest send for inclusion into the git repository. It is OK like

Re: [PATCH] REGTEST: filters: add compression test

2019-01-09 Thread Frederic Lecaille
On 1/8/19 11:25 PM, PiBa-NL wrote: Hi Frederic, Hi Pieter, Op 7-1-2019 om 10:13 schreef Frederic Lecaille: On 12/23/18 11:38 PM, PiBa-NL wrote: As requested hereby the regtest send for inclusion into the git repository. It is OK like that. Note that you patch do not add reg-test/filters

Re: regtests - with option http-use-htx

2019-01-08 Thread Frederic Lecaille
On 1/8/19 9:05 PM, PiBa-NL wrote: Hi Frederic, Op 8-1-2019 om 16:27 schreef Frederic Lecaille: On 12/15/18 4:52 PM, PiBa-NL wrote: Hi List, Willy, Trying to run some existing regtests with added option: option http-use-htx Using: HA-Proxy version 1.9-dev10-c11ec4a 2018/12/15 I get

Re: regtests - with option http-use-htx

2019-01-08 Thread Frederic Lecaille
On 12/15/18 4:52 PM, PiBa-NL wrote: Hi List, Willy, Trying to run some existing regtests with added option: option http-use-htx Using: HA-Proxy version 1.9-dev10-c11ec4a 2018/12/15 I get the below issues sofar: based on /reg-tests/connection/b0.vtc Takes 8 seconds to pass, in a

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-08 Thread Frederic Lecaille
On 1/7/19 9:24 PM, PiBa-NL wrote: Hi Willy, Op 7-1-2019 om 15:25 schreef Willy Tarreau: Hi Pieter, On Sun, Jan 06, 2019 at 04:38:21PM +0100, PiBa-NL wrote: The 23654 mails received for a failed server is a bit much.. I agree. I really don't know much how the mails work to be honest, as I

Re: [RFC PATCH] couple of reg-tests

2019-01-07 Thread Frederic Lecaille
On 1/2/19 2:17 PM, Jarno Huuskonen wrote: Hello, Hello Jarno, Sorry for this late reply. I started playing with reg-tests and came up with couple of regtests. Is there a better subdirectory for these than http-rules ? Maybe map/b0.vtc and converter/h* ? No, at this time it is ok.

Re: [PATCH] REGTEST: filters: add compression test

2019-01-07 Thread Frederic Lecaille
On 12/23/18 11:38 PM, PiBa-NL wrote: Added LUA requirement into the test.. Op 23-12-2018 om 23:05 schreef PiBa-NL: Hi Frederic, Hi Pieter, Sorry for this late reply. As requested hereby the regtest send for inclusion into the git repository. Without randomization and with your .diff

Re: corruption of data with compression in 1.9-dev10

2018-12-18 Thread Frederic Lecaille
On 12/12/18 2:08 AM, PiBa-NL wrote: Hi List, Didn't have time yet to bisect when it went wrong. But attached testfile produces the following output after 3 curl requests at different speeds, this seems to trigger a problem as the hash of the downloaded content is nolonger the same as it

[PATCH] REGTEST: level 1 health-check test 2.

2018-12-12 Thread Frederic Lecaille
Here is a new reg test for the health-check. Sounds similar to h1.vtc but is more intensive with client connections to verify there is no connection consumption by the health checks. Also checks that only servers with "check" option are "health-check'ed". Fred. From

Re: [PATCH] REGTEST: Add a first test for health-checks.

2018-12-11 Thread Frederic Lecaille
On 12/11/18 7:18 PM, Frederic Lecaille wrote: On 12/11/18 7:11 PM, Frederic Lecaille wrote: On 12/11/18 11:46 AM, Frederic Lecaille wrote: On 12/11/18 11:29 AM, Frederic Lecaille wrote: On 12/11/18 11:13 AM, Frederic Lecaille wrote: Hi ML, Here is a first reg test for the health-checks. I

Re: [PATCH] REGTEST: Add a first test for health-checks.

2018-12-11 Thread Frederic Lecaille
On 12/11/18 7:11 PM, Frederic Lecaille wrote: On 12/11/18 11:46 AM, Frederic Lecaille wrote: On 12/11/18 11:29 AM, Frederic Lecaille wrote: On 12/11/18 11:13 AM, Frederic Lecaille wrote: Hi ML, Here is a first reg test for the health-checks. I hope it is as most deterministic as possible

Re: [PATCH] REGTEST: Add a first test for health-checks.

2018-12-11 Thread Frederic Lecaille
On 12/11/18 11:46 AM, Frederic Lecaille wrote: On 12/11/18 11:29 AM, Frederic Lecaille wrote: On 12/11/18 11:13 AM, Frederic Lecaille wrote: Hi ML, Here is a first reg test for the health-checks. I hope it is as most deterministic as possible. At this time, I did not manage to make it fail

[PATCH] REGTEST: Reg test for "check" health-check option

2018-12-11 Thread Frederic Lecaille
Here is a new patch for a new reg test (health-check). Fred. From 6d1d882d19c25482d4c2ece7a9baad9452d19c3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Tue, 11 Dec 2018 16:19:34 +0100 Subject: [PATCH] REGTEST: Reg test for "check" health-check option. ---

Re: [PATCH] REGTEST: Add a first test for health-checks.

2018-12-11 Thread Frederic Lecaille
On 12/11/18 11:29 AM, Frederic Lecaille wrote: On 12/11/18 11:13 AM, Frederic Lecaille wrote: Hi ML, Here is a first reg test for the health-checks. I hope it is as most deterministic as possible. At this time, I did not manage to make it fail (takes ~130ms on my PC). Fred. Well, I have

Re: [PATCH] REGTEST: Add a first test for health-checks.

2018-12-11 Thread Frederic Lecaille
On 12/11/18 11:13 AM, Frederic Lecaille wrote: Hi ML, Here is a first reg test for the health-checks. I hope it is as most deterministic as possible. At this time, I did not manage to make it fail (takes ~130ms on my PC). Fred. Well, I have not checked the haproxy version required

[PATCH] REGTEST: Add a first test for health-checks.

2018-12-11 Thread Frederic Lecaille
Hi ML, Here is a first reg test for the health-checks. I hope it is as most deterministic as possible. At this time, I did not manage to make it fail (takes ~130ms on my PC). Fred. varnishtest "Health-check test" feature ignore_unknown_macro # This script test health-checks for four backends

[PATCH] REGTEST: Move LUA reg level 4 test 4 to level 1

2018-12-07 Thread Frederic Lecaille
Hi all, I think that Pieter level 4 LUA 4 script should be moved to level 1 (as a feature test). Fred. >From ac0188df083da4e240f87c34557cbf0ab9fd589d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Fri, 7 Dec 2018 11:16:35 +0100 Subject: [PATCH] REGTEST:

Re: BUG: Lua tasks can't use client sockets after bf89ff3d

2018-11-30 Thread Frederic Lecaille
On 11/30/18 2:42 AM, PiBa-NL wrote: Hi Frederic, Adis, Hi Pieter, Op 29-11-2018 om 14:53 schreef Frederic Lecaille: Hi Adis, On 11/29/18 10:03 AM, Adis Nezirovic wrote: On Thu, Nov 29, 2018 at 09:03:34AM +0100, Willy Tarreau wrote: OK thanks, I'll take a look at it once I've flushed my

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-30 Thread Frederic Lecaille
On 11/29/18 10:04 PM, Frederic Lecaille wrote: On 11/29/18 5:36 AM, Willy Tarreau wrote: Hi guys, On Wed, Nov 28, 2018 at 11:17:22AM +0100, Frederic Lecaille wrote: Perhaps we should "chmod +x" this script. Good point, done here. However I'm now seeing this whe

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-29 Thread Frederic Lecaille
On 11/29/18 5:36 AM, Willy Tarreau wrote: Hi guys, On Wed, Nov 28, 2018 at 11:17:22AM +0100, Frederic Lecaille wrote: Perhaps we should "chmod +x" this script. Good point, done here. However I'm now seeing this when starting it : ## Starting v

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-29 Thread Frederic Lecaille
On 11/29/18 8:47 AM, Willy Tarreau wrote: On Thu, Nov 29, 2018 at 05:36:35AM +0100, Willy Tarreau wrote: However I'm well aware that it's easier to work on improvements once the script is merged, so what I've done now is to merge it and create a temporary "reg-tests2" target in the makefile to

Re: BUG: Lua tasks can't use client sockets after bf89ff3d

2018-11-29 Thread Frederic Lecaille
Hi Adis, On 11/29/18 10:03 AM, Adis Nezirovic wrote: On Thu, Nov 29, 2018 at 09:03:34AM +0100, Willy Tarreau wrote: OK thanks, I'll take a look at it once I've flushed my pending stuff on H2+HTX :-( Great, I had my morning coffee and visited my optometrist, so here is a fixed test script

[PATCH] REGTEST: Fix LEVEL 4 script 0 of "connection" module.

2018-11-29 Thread Frederic Lecaille
Here is a little reg test fix. Fred. >From 61fd6486eee833b42a342993706b656537079242 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Thu, 29 Nov 2018 14:23:32 +0100 Subject: [PATCH] REGTEST: Fix LEVEL 4 script 0 of "connection" module. Prevent this script

[PATCH] REGTEST: Add a basic test for the cache.

2018-11-28 Thread Frederic Lecaille
Here is a little patch for a basic test for the cache. Fred. >From aa301c6eef5c6797283d56b9f23266345808cd1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Wed, 28 Nov 2018 11:36:48 +0100 Subject: [PATCH] REGTEST: Add a basic test for the cache. The client

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-28 Thread Frederic Lecaille
On 11/27/18 11:17 PM, PiBa-NL wrote: Hi Frederic, Willy, Op 27-11-2018 om 15:00 schreef Frederic Lecaille: On 11/27/18 10:44 AM, Frederic Lecaille wrote: On 11/27/18 9:52 AM, Willy Tarreau wrote: Hi guys, On Tue, Nov 27, 2018 at 09:45:25AM +0100, Frederic Lecaille wrote: I put the script

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-27 Thread Frederic Lecaille
On 11/27/18 10:44 AM, Frederic Lecaille wrote: On 11/27/18 9:52 AM, Willy Tarreau wrote: Hi guys, On Tue, Nov 27, 2018 at 09:45:25AM +0100, Frederic Lecaille wrote: I put the script in the /reg-tests/ folder. Maybe it should have been besides the Makefile in the / root ? Yes I think

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-27 Thread Frederic Lecaille
On 11/27/18 9:52 AM, Willy Tarreau wrote: Hi guys, On Tue, Nov 27, 2018 at 09:45:25AM +0100, Frederic Lecaille wrote: I put the script in the /reg-tests/ folder. Maybe it should have been besides the Makefile in the / root ? Yes I think it should be placed at the same level as the Makefile

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-27 Thread Frederic Lecaille
On 11/25/18 4:59 PM, PiBa-NL wrote: Hi Frederic, Willy, Hi Pieter, Added the varnishtest script we have been discussing as a .patch this time. I put the script in the /reg-tests/ folder. Maybe it should have been besides the Makefile in the / root ? Yes I think it should be placed at the

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-11-23 Thread Frederic Lecaille
On 11/23/18 1:12 AM, PiBa-NL wrote: Hi Frederic, Hi Pieter, I still have a ' ' newline, with the IFS= but the \n and \012 didnt seem to work there.. Strangely on my PC with both bash and dash I do not have to change IFS value to parse HAPROXY_VERSION, TARGET and OPTIONS with "read"

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-11-22 Thread Frederic Lecaille
On 11/19/18 10:08 PM, PiBa-NL wrote: Hi Frederic, Willy, Hi Pieter, Thank you a lot again for this work Pieter. Hello Pieter, Do you intend to finalize this script? We would like to use it in haproxy sources. Note that varnishtest already uses TMPDIR variable in place of /tmp if it is

Re: varnishtest with H2>HTX>H1(keep-alive)

2018-11-19 Thread Frederic Lecaille
On 11/19/18 8:10 PM, PiBa-NL wrote: Hi Willy, Op 19-11-2018 om 4:37 schreef Willy Tarreau: Hi Pieter, On Mon, Nov 19, 2018 at 01:07:44AM +0100, PiBa-NL wrote: Hi List, I'm trying (and failing?) to write a H2>HTX>H1(keepalive) test. Using haproxy 1.9-dev6-05b9b64. Test vtc attached, i

Re: varnishtest with H2>HTX>H1(keep-alive)

2018-11-19 Thread Frederic Lecaille
On 11/19/18 1:07 AM, PiBa-NL wrote: Hi List, Hi Pieter, Christopher is CC'ed. As your mail is about reg-testing I took a look at it. I'm trying (and failing?) to write a H2>HTX>H1(keepalive) test. Using haproxy 1.9-dev6-05b9b64. Test vtc attached, i added the 'option http-use-htx' to the

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-11-19 Thread Frederic Lecaille
On 11/8/18 6:11 AM, Willy Tarreau wrote: Hi guys, On Wed, Nov 07, 2018 at 09:37:14AM +0100, Frederic Lecaille wrote: New 'version' of the script attached. It now supports a set of parameters to modify its behavior a little. And also checking for a 'version requirement'. So a H2 test doesn't

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-11-19 Thread Frederic Lecaille
On 11/8/18 6:11 AM, Willy Tarreau wrote: Hi guys, On Wed, Nov 07, 2018 at 09:37:14AM +0100, Frederic Lecaille wrote: New 'version' of the script attached. It now supports a set of parameters to modify its behavior a little. And also checking for a 'version requirement'. So a H2 test doesn't

Re: [PATCH] HTTP 103 response (Early Hints)

2018-11-13 Thread Frederic Lecaille
On 11/13/18 7:48 AM, Aleksandar Lazic wrote: Hi Fred. Hello Aleksandar, Sorry to be picky but I still think that there is some missing text in the documentation, as mentioned before. http://git.haproxy.org/?p=haproxy.git;a=commitdiff;h=06f5b6435ba99b7a6a034d27b56192e16249f6f0 MINOR: doc: 

[PATCH] HTTP 103 response (Early Hints)

2018-11-12 Thread Frederic Lecaille
Hello, Here is a little series of patches to implement a new http-request action named "early-hint" to add HTTP 103 responses prior to any other response with headers whose values are defined by log-format rules, as this is done with "(add|del)-header" action. Regards, Fred. >From

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-11-07 Thread Frederic Lecaille
On 10/28/18 8:01 PM, PiBa-NL wrote: Hi Frederic, Hello Pieter, Sorry again for this late reply. Op 19-10-2018 om 11:51 schreef Frederic Lecaille: The idea of the script sounds good to me. About the script itself it is a nice work which could be a good start. Thanks. Just a few details

Re: [PATCH] MINOR: cache: Add "Age" header.

2018-10-26 Thread Frederic Lecaille
On 10/26/2018 02:52 PM, Frederic Lecaille wrote: Hello, Here is a patch to handle the "Age" header for the cache. Everything is in the commit log. Here is a better patch with this diff between this latter one and the previous one: @@ -52,7 +52,7 @@ + age = 0; + c

[PATCH] MINOR: cache: Add "Age" header.

2018-10-26 Thread Frederic Lecaille
Hello, Here is a patch to handle the "Age" header for the cache. Everything is in the commit log. Regards, Fred. >From af5156e33de0a5a2f278cd6b8834e834c5401b35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Fri, 26 Oct 2018 14:29:22 +0200 Subject: [PATCH]

Re: [PATCHES] Cache for larger HTTP objects

2018-10-25 Thread Frederic Lecaille
On 10/25/2018 07:01 PM, William Lallemand wrote: Hi Fred! On Thu, Oct 25, 2018 at 10:59:43AM +0200, Frederic Lecaille wrote: Well, after having checked, haproxy could start with a cache bigger than 2047 MB on my PC due to parsing issue. I provide three patches. The first fixes the "tota

Re: [PATCHES] Cache for larger HTTP objects

2018-10-25 Thread Frederic Lecaille
On 10/24/2018 04:49 AM, Willy Tarreau wrote: Hi Fred, On Tue, Oct 23, 2018 at 02:57:05PM +0200, Frederic Lecaille wrote: Hello ML, Here is a serie of patches to make the cache capable of caching HTTP objects larger than a buffer. The 4th patch add "max-object-size" option to "

[PATCHES] Cache for larger HTTP objects

2018-10-23 Thread Frederic Lecaille
Hello ML, Here is a serie of patches to make the cache capable of caching HTTP objects larger than a buffer. The 4th patch add "max-object-size" option to "cache" section so that to limit the size of the HTTP objects to be cached. Do not hesitate to test them. Regards, Fred. >From

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-10-19 Thread Frederic Lecaille
On 10/19/2018 12:43 AM, PiBa-NL wrote: Hi Frederic, Hi Pieter, Do you have a little time to take a look at (the idea of) the script? The idea of the script sounds good to me. About the script itself it is a nice work which could be a good start. Just a few details below. Note that "cat

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-10-02 Thread Frederic Lecaille
On 10/01/2018 08:59 PM, PiBa-NL wrote: Hi Frederic, Op 1-10-2018 om 16:09 schreef Frederic Lecaille: - /connection/b0.vtc probably does not 'really' need abns@ sockets, so changing to unix@ would make it testable on more platforms? Correct. I agree I did not think to replace this part

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-10-01 Thread Frederic Lecaille
On 09/11/2018 04:51 PM, PiBa-NL wrote: Hi List, I was wondering how to best run the reg-tests that are 'valid' for FreeBSD. There are a 2 tests that use abns@ sockets, which seem not available on FreeBSD. Also 1 test is failing for a reason i'm not totally sure if its totally expected to or

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-10-01 Thread Frederic Lecaille
On 09/11/2018 04:51 PM, PiBa-NL wrote: Hi List, Hi, I was wondering how to best run the reg-tests that are 'valid' for FreeBSD. There are a 2 tests that use abns@ sockets, which seem not available on FreeBSD. Also 1 test is failing for a reason i'm not totally sure if its totally

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-01 Thread Frederic Lecaille
On 09/15/2018 02:03 AM, PiBa-NL wrote: Hi List, Willy, Hi Pieter, Sorry for this late reply. I am also sorry to tell you that -D option should not be used anymore because it as been recently broken. It adds an extra 2s delay on my PC. Without this option, on my PC the test fails but after

Re: [PATCH] REGTEST/MINOR: lua: Add reg testing files for 70d318c.

2018-09-04 Thread Frederic Lecaille
On 09/04/2018 04:01 PM, Frederic Lecaille wrote: Another reg testing file for a LUA bug fixed by 70d318c commit. Fred. The same reg testing file but with indentation fixes. >From 7f01f387563564f1ee5ca718b4ad7562baa599b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L

[PATCH] REGTEST/MINOR: lua: Add reg testing files for 70d318c.

2018-09-04 Thread Frederic Lecaille
Another reg testing file for a LUA bug fixed by 70d318c commit. Fred. >From ff46b36aa4d3ee0213ec0572f9ab3a7261233579 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Tue, 4 Sep 2018 15:58:14 +0200 Subject: [PATCH] REGTEST/MINOR: lua: Add reg testing files for

Re: [PATCH] REGTEST: stick-tables: Test expiration when used with table_*

2018-08-31 Thread Frederic Lecaille
Hi, I am coming back to this reg testing sent by Daniel which was very interesting because very complete and because there was a little detail to fix. On 06/21/2018 04:53 AM, Willy Tarreau wrote: Hi Daniel, On Wed, Jun 20, 2018 at 10:28:43AM -0400, Daniel Corbett wrote: +shell -expect

[PATCH] BUG/MAJOR: thread: lua: Wrong SSL context initialization.

2018-08-29 Thread Frederic Lecaille
This patch is in relation with one bug reproduced by the reg testing file sent by Pieter in this thread: https://www.mail-archive.com/haproxy@formilux.org/msg31079.html Must be checked by Thierry. Must be backported to 1.8. Note that Pieter reg testing files reg-tests/lua/b2.* come with

Re: lua script, 200% cpu usage with nbthread 3 - haproxy hangs - __spin_lock - HA-Proxy version 1.9-dev1-e3faf02 2018/08/25

2018-08-29 Thread Frederic Lecaille
On 08/28/2018 11:19 AM, Frederic Lecaille wrote: On 08/27/2018 10:46 PM, PiBa-NL wrote: Hi Frederic, Oliver, Hi Pieter, Thanks for your investigations :). I've made a little reg-test (files attached). Its probably not 'correct' to commit as-is, but should be enough to get a reproduction

Re: Haproxy 1.8 segfaults on misconfigured set server fqdn command

2018-08-28 Thread Frederic Lecaille
On 08/14/2018 11:27 AM, Lukas Tribus wrote: Hello, Hi, the "set server / fqdn " admin socket command requires the internal DNS resolver to be configured and enabled for that specific server. This is undocumented, and I will provide a doc fix soon. However, when the resolver is not

Re: lua script, 200% cpu usage with nbthread 3 - haproxy hangs - __spin_lock - HA-Proxy version 1.9-dev1-e3faf02 2018/08/25

2018-08-28 Thread Frederic Lecaille
On 08/27/2018 10:46 PM, PiBa-NL wrote: Hi Frederic, Oliver, Thanks for your investigations :). I've made a little reg-test (files attached). Its probably not 'correct' to commit as-is, but should be enough to get a reproduction.. I hope.. changing it to nbthread 1 makes it work every

Re: lua script, 200% cpu usage with nbthread 3 - haproxy hangs - __spin_lock - HA-Proxy version 1.9-dev1-e3faf02 2018/08/25

2018-08-28 Thread Frederic Lecaille
On 08/27/2018 10:46 PM, PiBa-NL wrote: Hi Frederic, Oliver, Hi Pieter, Thanks for your investigations :). I've made a little reg-test (files attached). Its probably not 'correct' to commit as-is, but should be enough to get a reproduction.. I hope.. changing it to nbthread 1 makes it work

Re: lua script, 200% cpu usage with nbthread 3 - haproxy hangs - __spin_lock - HA-Proxy version 1.9-dev1-e3faf02 2018/08/25

2018-08-27 Thread Frederic Lecaille
On 08/27/2018 03:09 PM, Olivier Houchard wrote: On Mon, Aug 27, 2018 at 02:29:42PM +0200, Frederic Lecaille wrote: On 08/27/2018 01:33 PM, Olivier Houchard wrote: Hi Pieter, On Sat, Aug 25, 2018 at 10:00:04PM +0200, PiBa-NL wrote: Hi List, Thierry, Olivier, Using a lua-socket

Re: lua script, 200% cpu usage with nbthread 3 - haproxy hangs - __spin_lock - HA-Proxy version 1.9-dev1-e3faf02 2018/08/25

2018-08-27 Thread Frederic Lecaille
On 08/27/2018 01:33 PM, Olivier Houchard wrote: Hi Pieter, On Sat, Aug 25, 2018 at 10:00:04PM +0200, PiBa-NL wrote: Hi List, Thierry, Olivier, Using a lua-socket with connect_ssl and haproxy running with nbthread 3.. results in haproxy hanging with 3 threads for me. This while using both

Re: lua script, 200% cpu usage with nbthread 3 - haproxy hangs - __spin_lock - HA-Proxy version 1.9-dev1-e3faf02 2018/08/25

2018-08-27 Thread Frederic Lecaille
On 08/25/2018 10:00 PM, PiBa-NL wrote: Hi List, Thierry, Olivier, Hi, Using a lua-socket with connect_ssl and haproxy running with nbthread 3.. results in haproxy hanging with 3 threads for me. If your configuration is simple do not hesitate to provide it. Perhaps we will be able to write

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-24 Thread Frederic Lecaille
On 08/22/2018 04:32 AM, Willy Tarreau wrote: On Wed, Aug 22, 2018 at 12:46:47AM +0200, Cyril Bonté wrote: Le 22/08/2018 à 00:40, Cyril Bonté a écrit : Hi again Willy, Le 21/08/2018 à 22:55, Cyril Bonté a écrit : Thanks for the diag. I don't remember changing anything around the proxy

Re: [PATCH] BUG/MINOR: lua: Bad HTTP client request duration.

2018-08-24 Thread Frederic Lecaille
On 08/24/2018 08:42 AM, Frederic Lecaille wrote: Here is a patch to fix the issue reported by Patrick in this thread (BUG: Tw is negative with lua sleep https://www.mail-archive.com/haproxy@formilux.org/msg30474.html). Note that I provide a reg testing file to test both HTTP and TCP LUA

[PATCH] BUG/MINOR: lua: Bad HTTP client request duration.

2018-08-24 Thread Frederic Lecaille
Here is a patch to fix the issue reported by Patrick in this thread (BUG: Tw is negative with lua sleep https://www.mail-archive.com/haproxy@formilux.org/msg30474.html). Note that I provide a reg testing file to test both HTTP and TCP LUA applet callbacks used when registering an HTTP or TCP

Re: BUG: Tw is negative with lua sleep

2018-08-23 Thread Frederic Lecaille
On 08/23/2018 09:47 AM, Thierry Fournier wrote: On 22 Aug 2018, at 06:00, Patrick Hemmer wrote: On 2018/7/18 09:03, Frederic Lecaille wrote: Hello Patrick, On 07/17/2018 03:59 PM, Patrick Hemmer wrote: Ping? -Patrick On 2018/6/22 15:10, Patrick Hemmer wrote: When using core.msleep

[PATCH] REGTEST/MINOR

2018-08-23 Thread Frederic Lecaille
Hi ML, Here are two patches for haproxy reg testing. Note that we have recently added an new feature to varnishtest so that to send commands to the CLI without running a shell, socat etc (https://varnish-cache.org/docs/trunk/reference/vtc.html#haproxy). This breaks reg-tests/spoe/h0.vtc

Re: [PATCH 1/1] TMP: Add reg-test to check scoping of txn:get_priv()

2018-08-22 Thread Frederic Lecaille
On 08/22/2018 04:20 PM, Tim Düsterhus wrote: Frederic, Am 22.08.2018 um 15:21 schrieb Frederic Lecaille: Thank you a lot for this reg testing file. Just a little detail (see below). You are correct of course. It was quickly cobbled together to provide a reproducer, not meant for committing

Re: [PATCH 1/1] TMP: Add reg-test to check scoping of txn:get_priv()

2018-08-22 Thread Frederic Lecaille
Hello Tim, Thank you a lot for this reg testing file. Just a little detail (see below). Also note that -run is a shorcut for -start -wait. Regards. On 08/22/2018 02:47 PM, Tim Duesterhus wrote: diff --git a/reg-tests/lua/h1.lua b/reg-tests/lua/h1.lua new file mode 100644 index

Re: Regexp

2018-07-24 Thread Frederic Lecaille
On 07/20/2018 12:03 AM, Aleksandar Lazic wrote: Hi. On 18/07/2018 13:10, Haim Ari wrote: Hello, Trying to set backend by regexp This regexp works outside of haproxy String: /1.0/manage/bu/ca?token=68bf68bf68bf68bf68bf=1212121212=123456789 Regexp:

Re: BUG: Tw is negative with lua sleep

2018-07-18 Thread Frederic Lecaille
Hello Patrick, On 07/17/2018 03:59 PM, Patrick Hemmer wrote: Ping? -Patrick On 2018/6/22 15:10, Patrick Hemmer wrote: When using core.msleep in lua, the %Tw metric is a negative value. For example with the following config: haproxy.cfg:         global             lua-load /tmp/haproxy.lua  

Re: url_param not matching key-only params (also testcases for fetchers)

2018-07-17 Thread Frederic Lecaille
Hello, On 07/16/2018 08:47 PM, Robin H. Johnson wrote: I looked in tests & reg-tests, but didn't see any clear way to add tests for verifying that fetchers work correctly. I think my co-worker found an edge-case on smp_fetch_url_param/smp_fetch_param. Have a look to the attached file to test

[PATCH] REGTEST/MINOR: Unexpected curl URL globling.

2018-07-13 Thread Frederic Lecaille
On 07/12/2018 05:52 PM, Willy Tarreau wrote: On Thu, Jul 12, 2018 at 11:05:30AM +0200, Frederic Lecaille wrote: This is a patch to fix the issue reported by Ilya Shipitsin in this thread. Applied, thank you Fred. Willy Another patch to fix a remaining issue with this boring VTC file

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

2018-07-13 Thread Frederic Lecaille
On 07/13/2018 10:17 AM, Илья Шипицин wrote: пт, 13 июл. 2018 г. в 13:08, Frederic Lecaille <mailto:flecai...@haproxy.com>>: On 07/13/2018 09:53 AM, Илья Шипицин wrote: > sorry, I did not test it on centos 7 > > https://gitlab.com/chipitsine/hapro

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

2018-07-13 Thread Frederic Lecaille
On 07/13/2018 09:53 AM, Илья Шипицин wrote: sorry, I did not test it on centos 7 https://gitlab.com/chipitsine/haproxy/-/jobs/81501288 (I could not find out what's that, error message is strange, I'll try to investigate on separate vm) чт, 12 июл. 2018 г. в 14:08, Frederic Lecaille

[PATCH] REGTEST/MINOR: Wrong URI syntax.

2018-07-12 Thread Frederic Lecaille
This is a patch to fix the issue reported by Ilya Shipitsin in this thread. Fred. >From 47ca7696d0ccca5989929940db323e9e9255ae4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Thu, 12 Jul 2018 10:48:06 +0200 Subject: [PATCH] REGTEST/MINOR: Wrong URI syntax.

Re: how h1_frt_addr is defined during reg tests?

2018-07-12 Thread Frederic Lecaille
On 07/11/2018 09:12 PM, Илья Шипицин wrote: Hello, I'm playing with reg tests. Sometimes they fail for weird reasons. (for example, fedora 28 on gitlab ci) https://gitlab.com/chipitsine/haproxy/-/jobs/81106855 curl -i -k https://${h1_frt_addr}:${h1_frt_port} became curl -i -k

Re: haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-11 Thread Frederic Lecaille
On 07/11/2018 10:41 AM, Frederic Lecaille wrote: On 07/10/2018 01:35 PM, Илья Шипицин wrote: Hello, Hello Ilya, I had an idea, what if we will run reg-tests with various sanitizers ? for example, https://gitlab.com/chipitsine/haproxy/-/jobs/80667862 (gcc + sanitize-address). can someone

[PATCH] BUG/MINOR: thread: log: Log buffers allocated twice by main, thread.

2018-07-11 Thread Frederic Lecaille
This is a patch to fix a very minor bug. But at least it helps in making reg tests with the address sanitizer passes. Fred. >From e75d5fee861d8f3da68238c337512c71d090ac8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Wed, 11 Jul 2018 10:31:29 +0200

Re: haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-11 Thread Frederic Lecaille
On 07/10/2018 01:35 PM, Илья Шипицин wrote: Hello, Hello Ilya, I had an idea, what if we will run reg-tests with various sanitizers ? for example, https://gitlab.com/chipitsine/haproxy/-/jobs/80667862 (gcc + sanitize-address). can someone confirm a bug there ? I confirm there is a

Re: how to run reg-tests ?

2018-07-10 Thread Frederic Lecaille
On 07/10/2018 12:57 PM, Илья Шипицин wrote: yahoo! green tests https://gitlab.com/chipitsine/haproxy/-/jobs/80660454 Nice :)

Re: how to run reg-tests ?

2018-07-10 Thread Frederic Lecaille
Hi, On 07/10/2018 12:02 PM, Илья Шипицин wrote: I use Fedora 28 if that matters. varnishtest installed from repo (dnf install varnish), it is varnish-5.2.1-4.fc28.x86_64 вт, 10 июл. 2018 г. в 14:58, Илья Шипицин >: HI, I cloned haproxy. built it

Re: [PATCH] REGTEST: stick-tables: Test expiration when used with table_*

2018-06-25 Thread Frederic Lecaille
On 06/21/2018 04:53 AM, Willy Tarreau wrote: Hi Daniel, On Wed, Jun 20, 2018 at 10:28:43AM -0400, Daniel Corbett wrote: +shell -expect "used:0" { +echo "show table http1" |socat ${tmpdir}/h1/stats.sock - ^ This is the point where it will start to

Re: how to run vtc files?

2018-06-21 Thread Frederic Lecaille
On 06/21/2018 04:13 AM, Willy Tarreau wrote: On Wed, Jun 20, 2018 at 04:39:36PM -0400, Daniel Corbett wrote: Hello, On 06/20/2018 03:34 PM, ??? wrote: hi [ilia@localhost haproxy]$ HAPROXY_PROGRAM=./haproxy varnishtest reg-tests/ssl/h0.vtc top   0.0 extmacro def

Re: [PATCH] REGTEST: stick-tables: Test expiration when used with table_*

2018-06-21 Thread Frederic Lecaille
On 06/20/2018 04:28 PM, Daniel Corbett wrote: Hello, Thanks for adding this integration Fred.  Great job! Attached is a new regression test to check for stick-tables expiration when they are used with table_* converters as noted in commit id: 3e60b11100cbc812b77029ca142b83ac7a314db1 Thanks,

Re: [PATCH] MINOR: reg-tests: Add a few regression testing files.

2018-06-20 Thread Frederic Lecaille
On 06/20/2018 10:06 AM, Willy Tarreau wrote: On Wed, Jun 20, 2018 at 09:47:25AM +0200, Frederic Lecaille wrote: Here is a few more reg testing files with a special one for Olivier (see reg-tests/seamless-reload/h0.vtc). Merged, thanks Fred. I think we should start to think about using

[PATCH] MINOR: reg-tests: Add a few regression testing files.

2018-06-20 Thread Frederic Lecaille
On 06/19/2018 10:18 AM, Willy Tarreau wrote: On Mon, Jun 18, 2018 at 07:50:38PM +0200, Frederic Lecaille wrote: Hello, Here is a simple patch to add a Makefile target to run all "*.vtc" regression testing files found in 'reg-tests' directory. (...) Thank you very much for this, Fr

[PATCH] MINOR: reg-tests: Add reg-tests/README file.

2018-06-19 Thread Frederic Lecaille
On 06/19/2018 10:18 AM, Willy Tarreau wrote: On Mon, Jun 18, 2018 at 07:50:38PM +0200, Frederic Lecaille wrote: Hello, Here is a simple patch to add a Makefile target to run all "*.vtc" regression testing files found in 'reg-tests' directory. (...) Thank you very much for this, Fr

[PATCH] MINOR: tests: First regression testing file.

2018-06-18 Thread Frederic Lecaille
Hello, Here is a simple patch to add a Makefile target to run all "*.vtc" regression testing files found in 'reg-tests' directory. It comes with a first VTC file in relation with f874a83 bug fix commit for LUA. This VTC file parent directory is 'reg-tests/lua'. I have copied and pasted the

[PATCH] BUG/MINOR: lua: Segfaults with wrong usage of types.

2018-06-15 Thread Frederic Lecaille
On 06/15/2018 02:28 PM, Frederic Lecaille wrote: On 06/15/2018 02:15 PM, Frederic Lecaille wrote: On 06/14/2018 11:05 PM, Patrick Hemmer wrote: Haproxy segfaults if you pass the wrong argument type to a converter. Example: haproxy.cfg: global     lua-load /tmp/haproxy.lua

Re: BUG: segfault with lua sample converters & wrong arg types

2018-06-15 Thread Frederic Lecaille
On 06/15/2018 02:15 PM, Frederic Lecaille wrote: On 06/14/2018 11:05 PM, Patrick Hemmer wrote: Haproxy segfaults if you pass the wrong argument type to a converter. Example: haproxy.cfg: global     lua-load /tmp/haproxy.lua frontend f1     mode http     bind :8000

Re: BUG: segfault with lua sample converters & wrong arg types

2018-06-15 Thread Frederic Lecaille
On 06/14/2018 11:05 PM, Patrick Hemmer wrote: Haproxy segfaults if you pass the wrong argument type to a converter. Example: haproxy.cfg:     global         lua-load /tmp/haproxy.lua     frontend f1         mode http         bind :8000         default_backend b1         http-request

Re: BUG: segfault with lua sample converters & wrong arg types

2018-06-15 Thread Frederic Lecaille
Hello Patrick, On 06/14/2018 11:05 PM, Patrick Hemmer wrote: Haproxy segfaults if you pass the wrong argument type to a converter. Example: haproxy.cfg:     global         lua-load /tmp/haproxy.lua     frontend f1         mode http         bind :8000         default_backend b1        

Re: regression testing for haproxy

2018-06-11 Thread Frederic Lecaille
On 06/09/2018 09:16 AM, Baptiste wrote: Hi Fred, Hi Baptiste, Amazing work. Looking forward to write some of those :) Yes for now on, *if possible*, it would be great to write a test file for each bug to come. . According to you, would it be compicated to automate tests on the DNS

  1   2   >